All of lore.kernel.org
 help / color / mirror / Atom feed
From: jacmet@sunsite.dk (Peter Korsgaard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] hw_random: add driver for atmel true hardware random number generator
Date: Thu, 06 Oct 2011 17:55:32 +0200	[thread overview]
Message-ID: <8762k23yiz.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20111006154904.GE12975@sirena.org.uk> (Mark Brown's message of "Thu, 6 Oct 2011 16:49:07 +0100")

>>>>> "Mark" == Mark Brown <broonie@opensource.wolfsonmicro.com> writes:

 Mark> On Thu, Oct 06, 2011 at 05:41:34PM +0200, Peter Korsgaard wrote:
 >> +	trng->clk = clk_get(&pdev->dev, NULL);
 >> +	if (IS_ERR(trng->clk))
 >> +		return PTR_ERR(trng->clk);
 >> +
 >> +	ret = clk_enable(trng->clk);
 >> +	if (ret)
 >> +		goto err_enable;

 Mark> Is it worth enabling the hardware enabled only when the device is open?

Potentially, though I doubt it uses significant power. I kept it like
this for simplicity, to match the other drivers and because hw_random
doesn't have an open/close callback (init is called right away in
hwrng_register or on current change).

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2011-10-06 15:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-06 15:41 [PATCH 1/2] sam9g45: add trng clock and platform device Peter Korsgaard
2011-10-06 15:41 ` [PATCH 2/2] hw_random: add driver for atmel true hardware random number generator Peter Korsgaard
2011-10-06 15:49   ` Mark Brown
2011-10-06 15:55     ` Peter Korsgaard [this message]
2011-10-06 16:02   ` Jamie Iles
2011-10-06 17:53     ` Peter Korsgaard
2011-10-07 10:09 ` [PATCH 1/2] sam9g45: add trng clock and platform device Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8762k23yiz.fsf@macbook.be.48ers.dk \
    --to=jacmet@sunsite.dk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.