From: Kevin Hilman <khilman@deeprootsystems.com>
To: Laine Walker-Avina <lwalkera@ieee.org>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH 5/5] OMAP: Make set_gpmc_timing_reg aware of the TIMEPARAGRANULARITY flag
Date: Tue, 06 Apr 2010 15:36:21 -0700 [thread overview]
Message-ID: <876344jjiy.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1270572668-2336-6-git-send-email-lwalkera@ieee.org> (Laine Walker-Avina's message of "Tue\, 6 Apr 2010 09\:51\:08 -0700")
Laine Walker-Avina <lwalkera@ieee.org> writes:
> Signed-off-by: Laine Walker-Avina <lwalkera@ieee.org>
All of the patches in this series should have a more descriptive
changelog. Typically that means answering "why?" to the subject, and
for more complicated series, also answering "how?"
[...]
> +#ifdef DEBUG
> + printk(KERN_INFO "GPMC_FCLK: %ld\n", gpmc_get_fclk_period());
> +#endif
should just use pr_debug(...)
Kevin
next prev parent reply other threads:[~2010-04-06 22:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-06 16:51 [PATCH 0/5] Initial change for merge of new board Laine Walker-Avina
2010-04-06 16:51 ` [PATCH 1/5] OMAP: Add in helper macros for the SDRAM timings Laine Walker-Avina
2010-04-06 16:51 ` [PATCH 2/5] OMAP: Convert the sdram-*.h timings to use the SDRAM timing macros Laine Walker-Avina
2010-04-06 16:51 ` [PATCH 3/5] OMAP: Add SDRAM timings for Micron mt46h16m32lf-6 Laine Walker-Avina
2010-04-06 16:51 ` [PATCH 4/5] OMAP: Add support for setting the divider for sys_clkout2 using clk_set_rate Laine Walker-Avina
2010-04-06 16:51 ` [PATCH 5/5] OMAP: Make set_gpmc_timing_reg aware of the TIMEPARAGRANULARITY flag Laine Walker-Avina
2010-04-06 22:36 ` Kevin Hilman [this message]
2010-07-29 21:44 ` [PATCH v2] " Laine Walker-Avina
2010-04-23 0:55 ` [PATCH 4/5] OMAP: Add support for setting the divider for sys_clkout2 using clk_set_rate Paul Walmsley
2010-05-18 22:04 ` Paul Walmsley
2010-04-06 17:17 ` [PATCH 1/5] OMAP: Add in helper macros for the SDRAM timings Felipe Balbi
2010-04-06 17:26 ` Laine Walker-Avina
2010-04-06 17:28 ` Felipe Balbi
2010-04-06 17:31 ` [PATCH v2 " Laine Walker-Avina
2010-04-23 0:48 ` [PATCH 0/5] Initial change for merge of new board Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=876344jjiy.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=lwalkera@ieee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.