All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kalle.valo@iki.fi>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: annotate sleeping driver ops
Date: Sat, 28 Nov 2009 23:08:52 +0200	[thread overview]
Message-ID: <87638u8ihn.fsf@purkki.valot.fi> (raw)
In-Reply-To: <1259440583.5428.32.camel@johannes.local> (Johannes Berg's message of "Sat\, 28 Nov 2009 21\:36\:23 +0100")

Johannes Berg <johannes@sipsolutions.net> writes:

> On Sat, 2009-11-28 at 22:19 +0200, Kalle Valo wrote:
>> To make it easier to notice cases of calling sleeping ops in atomic context,
>> annotate driver-ops.h with appropiate might_sleep() calls. At the same time,
>> also document in mac80211.h the op functions with missing contexts.
>> 
>> mac80211 doesn't seem to use get_tx_stats anywhere currently. Just to be on
>> the safe side, I documented it to be atomic, but hopefully the op can be
>> removed in the future.
>> 
>> Compile-tested only.
>
> Nice, thanks. Haven't reviewed it in detail, but I'll trust you :)
>
> Acked-by: Johannes Berg <johannes@sipsolutions.net>

Thanks for the trust! I'll, just in case, test the patch tomorrow both
with iwl3945 and wl1251 so that this trust doesn't backfire =)

But first some sleep.

-- 
Kalle Valo

  reply	other threads:[~2009-11-28 21:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-28 20:19 [PATCH] mac80211: annotate sleeping driver ops Kalle Valo
2009-11-28 20:36 ` Johannes Berg
2009-11-28 21:08   ` Kalle Valo [this message]
2009-11-28 21:00 ` Michael Buesch
2009-11-28 21:09   ` Kalle Valo
2009-11-29 20:16 ` Kalle Valo
     [not found] <20091216214202.17238.82313.stgit@tikku>
2009-12-17 12:50 ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87638u8ihn.fsf@purkki.valot.fi \
    --to=kalle.valo@iki.fi \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.