From: Kalle Valo <kalle.valo@iki.fi>
To: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: annotate sleeping driver ops
Date: Sun, 29 Nov 2009 22:16:27 +0200 [thread overview]
Message-ID: <87ws196q90.fsf@purkki.valot.fi> (raw)
In-Reply-To: <1259439566-26397-1-git-send-email-kalle.valo@iki.fi> (Kalle Valo's message of "Sat\, 28 Nov 2009 22\:19\:26 +0200")
Kalle Valo <kalle.valo@iki.fi> writes:
> To make it easier to notice cases of calling sleeping ops in atomic context,
> annotate driver-ops.h with appropiate might_sleep() calls. At the same time,
> also document in mac80211.h the op functions with missing contexts.
>
> mac80211 doesn't seem to use get_tx_stats anywhere currently. Just to be on
> the safe side, I documented it to be atomic, but hopefully the op can be
> removed in the future.
>
> Compile-tested only.
FWIW, I tested the patch with wl1251 and iwl3945 and no warnings visible.
--
Kalle Valo
next prev parent reply other threads:[~2009-11-29 20:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-28 20:19 [PATCH] mac80211: annotate sleeping driver ops Kalle Valo
2009-11-28 20:36 ` Johannes Berg
2009-11-28 21:08 ` Kalle Valo
2009-11-28 21:00 ` Michael Buesch
2009-11-28 21:09 ` Kalle Valo
2009-11-29 20:16 ` Kalle Valo [this message]
[not found] <20091216214202.17238.82313.stgit@tikku>
2009-12-17 12:50 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ws196q90.fsf@purkki.valot.fi \
--to=kalle.valo@iki.fi \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.