[PATCH] terminal is not set back to console

[PATCH] terminal is not set back to console

[Robert Millan]

[-- Attachment #1: Type: text/plain, Size: 461 bytes --]


When using gfxterm, and booting a kernel in this mode, Linux won't be able to
print anything to the console.  This patch fixes it so that terminal is set
back to normal console during deinitialisation.

Tested and known to work, although I'm not 1:1 sure if this is the right place
to do it.

-- 
Robert Millan

My spam trap is honeypot@aybabtu.com.  Note: this address is only intended
for spam harvesters.  Writing to it will get you added to my black list.

[-- Attachment #2: deinitialise_terminal.diff --]
[-- Type: text/x-diff, Size: 619 bytes --]


2007-05-03  Robert Millan  <rmh@aybabtu.com>

	* term/i386/pc/console.c (grub_console_fini): Call
	grub_term_set_current() before grub_term_unregister().

Index: term/i386/pc/console.c
===================================================================
RCS file: /sources/grub/grub2/term/i386/pc/console.c,v
retrieving revision 1.7
diff -u -r1.7 console.c
--- term/i386/pc/console.c	20 Aug 2005 05:26:51 -0000	1.7
+++ term/i386/pc/console.c	3 May 2007 18:42:08 -0000
@@ -148,5 +148,6 @@
 void
 grub_console_fini (void)
 {
+  grub_term_set_current (&grub_console_term);
   grub_term_unregister (&grub_console_term);
 }

Re: [PATCH] terminal is not set back to console

[Robert Millan]

On Thu, May 03, 2007 at 08:50:11PM +0200, Robert Millan wrote:
> 
> When using gfxterm, and booting a kernel in this mode, Linux won't be able to
> print anything to the console.  This patch fixes it so that terminal is set
> back to normal console during deinitialisation.
> 
> Tested and known to work, although I'm not 1:1 sure if this is the right place
> to do it.

Btw, should other platforms do the same?

-- 
Robert Millan

My spam trap is honeypot@aybabtu.com.  Note: this address is only intended
for spam harvesters.  Writing to it will get you added to my black list.

Re: [PATCH] terminal is not set back to console

[Yoshinori K. Okuji]

On Thursday 03 May 2007 20:50, Robert Millan wrote:
> When using gfxterm, and booting a kernel in this mode, Linux won't be able
> to print anything to the console.  This patch fixes it so that terminal is
> set back to normal console during deinitialisation.
>
> Tested and known to work, although I'm not 1:1 sure if this is the right
> place to do it.

Yes, this is good.

Thanks,
Okuji

Re: [PATCH] terminal is not set back to console

[Yoshinori K. Okuji]

On Thursday 03 May 2007 21:05, Robert Millan wrote:
> On Thu, May 03, 2007 at 08:50:11PM +0200, Robert Millan wrote:
> > When using gfxterm, and booting a kernel in this mode, Linux won't be
> > able to print anything to the console.  This patch fixes it so that
> > terminal is set back to normal console during deinitialisation.
> >
> > Tested and known to work, although I'm not 1:1 sure if this is the right
> > place to do it.
>
> Btw, should other platforms do the same?

Do you mean other terminals? Generally, yes. If you don' have any good reason, 
it is always nice to reset states to the original.

Okuji

Re: [PATCH] terminal is not set back to console

[Robert Millan]

On Thu, May 03, 2007 at 11:46:16PM +0200, Yoshinori K. Okuji wrote:
> On Thursday 03 May 2007 21:05, Robert Millan wrote:
> > On Thu, May 03, 2007 at 08:50:11PM +0200, Robert Millan wrote:
> > > When using gfxterm, and booting a kernel in this mode, Linux won't be
> > > able to print anything to the console.  This patch fixes it so that
> > > terminal is set back to normal console during deinitialisation.
> > >
> > > Tested and known to work, although I'm not 1:1 sure if this is the right
> > > place to do it.
> >
> > Btw, should other platforms do the same?
> 
> Do you mean other terminals? Generally, yes. If you don' have any good reason, 
> it is always nice to reset states to the original.

No, I really mean other platforms (i386/efi, etc).  My patch sets console as
the default terminal when unloading it.  It doesn't set state back to what
it was before loading console.  If other terminals did the same, results
would be undefined.

-- 
Robert Millan

My spam trap is honeypot@aybabtu.com.  Note: this address is only intended
for spam harvesters.  Writing to it will get you added to my black list.

Re: [PATCH] terminal is not set back to console

[Marco Gerards]

Robert Millan <rmh@aybabtu.com> writes:

> When using gfxterm, and booting a kernel in this mode, Linux won't be able to
> print anything to the console.  This patch fixes it so that terminal is set
> back to normal console during deinitialisation.
>
> Tested and known to work, although I'm not 1:1 sure if this is the right place
> to do it.

Feel free to apply this patch.

--
Marco

Re: [PATCH] terminal is not set back to console

[Robert Millan]

On Fri, May 04, 2007 at 10:30:33AM +0200, Marco Gerards wrote:
> Robert Millan <rmh@aybabtu.com> writes:
> 
> > When using gfxterm, and booting a kernel in this mode, Linux won't be able to
> > print anything to the console.  This patch fixes it so that terminal is set
> > back to normal console during deinitialisation.
> >
> > Tested and known to work, although I'm not 1:1 sure if this is the right place
> > to do it.
> 
> Feel free to apply this patch.

Ok, if you insist..

Committed.  I've left the other platforms untouched since I'm not familiar
about them.  Maybe that needs to be reviewed.

-- 
Robert Millan

My spam trap is honeypot@aybabtu.com.  Note: this address is only intended
for spam harvesters.  Writing to it will get you added to my black list.

Re: [PATCH] terminal is not set back to console

[Marco Gerards]

Robert Millan <rmh@aybabtu.com> writes:

> On Fri, May 04, 2007 at 10:30:33AM +0200, Marco Gerards wrote:
>> Robert Millan <rmh@aybabtu.com> writes:
>> 
>> > When using gfxterm, and booting a kernel in this mode, Linux won't be able to
>> > print anything to the console.  This patch fixes it so that terminal is set
>> > back to normal console during deinitialisation.
>> >
>> > Tested and known to work, although I'm not 1:1 sure if this is the right place
>> > to do it.
>> 
>> Feel free to apply this patch.
>
> Ok, if you insist..
>
> Committed.  I've left the other platforms untouched since I'm not familiar
> about them.  Maybe that needs to be reviewed.

If you want to fix those, please do.  But it is not that important.
The other platforms don't have multiple terminals so can't trigger
this problem.  Yet...

--
Marco