All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Rydberg <jrydberg@night.trouble.net>
To: grub-devel@gnu.org
Subject: [PATCH] Do not require console control protocol.
Date: Fri, 28 Jul 2006 00:15:40 +0200	[thread overview]
Message-ID: <8764hilmnn.fsf@night.trouble.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

Hi,

I would like to have the following patch committed.  Some EFI
implementations do not provide a console control protocol instance,
and it is covered by neither EFI or UEFI specifications.

~j

2006-07-28  Johan Rydberg  <jrydberg@gnu.org>

        * kern/efi/efi.c (grub_efi_set_text_mode): Assume console already
        is in text mode if there is no console control protocol instance
        available.



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: grub.efi-console-control.1.patch --]
[-- Type: text/x-patch, Size: 579 bytes --]

Index: kern/efi/efi.c
===================================================================
RCS file: /sources/grub/grub2/kern/efi/efi.c,v
retrieving revision 1.7
diff -u -r1.7 efi.c
--- kern/efi/efi.c	27 May 2006 21:09:25 -0000	1.7
+++ kern/efi/efi.c	27 Jul 2006 22:01:49 -0000
@@ -125,7 +125,9 @@
 
   c = grub_efi_locate_protocol (&console_control_guid, 0);
   if (! c)
-    return 0;
+    /* No console control protocol instance available, assume it is
+       already in text mode. */
+    return 1;
   
   if (c->get_mode (c, &mode, 0, 0) != GRUB_EFI_SUCCESS)
     return 0;

             reply	other threads:[~2006-07-27 22:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-27 22:15 Johan Rydberg [this message]
2006-07-27 22:22 ` [PATCH] Do not require console control protocol Yoshinori K. Okuji
2006-07-28 10:20   ` Johan Rydberg
2006-07-29 11:22     ` Yoshinori K. Okuji

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8764hilmnn.fsf@night.trouble.net \
    --to=jrydberg@night.trouble.net \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.