All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/4] ALSA: seq: ump: Fix Note On/Off and key pressure conversion
@ 2026-11-16  3:03 HyeongJun An
  2026-11-16  3:03 ` [PATCH 1/4] ALSA: seq: ump: Don't turn a zero key pressure into a Note Off HyeongJun An
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: HyeongJun An @ 2026-11-16  3:03 UTC (permalink / raw)
  To: Takashi Iwai
  Cc: Jaroslav Kysela, Mark Brown, Shuah Khan, linux-sound,
	linux-kselftest, linux-kernel, HyeongJun An

Hello Takashi,

While extending seq-ump-test, I found three conversion bugs in
seq_ump_convert.c. In each case the UMP core or the other sequencer
path already does the right thing, and the fix follows it.

Patches 1-3 are the fixes. They also apply to for-linus. Patch 4 adds
the tests on top of seq-ump-test.c in for-next.

Without patches 1-3, the new tests midi1_key_pressure,
ump_midi1_to_midi2_note and ump_midi2_to_midi1_note fail and the other
25 pass. With them, all 28 pass.

Prepared with Claude Code (Claude Opus 5.5). Tested on x86_64 under
qemu, on sound/for-next.

Best regards,
HyeongJun An

HyeongJun An (4):
  ALSA: seq: ump: Don't turn a zero key pressure into a Note Off
  ALSA: seq: ump: Convert a zero-velocity Note On to Note Off for MIDI
    2.0
  ALSA: seq: ump: Keep a soft MIDI 2.0 Note On from becoming a Note Off
  selftests/alsa: Test the sequencer UMP Note On/Off conversion

 sound/core/seq/seq_ump_convert.c            |  10 +-
 tools/testing/selftests/alsa/seq-ump-test.c | 187 +++++++++++++++++++-
 2 files changed, 188 insertions(+), 9 deletions(-)

-- 
2.43.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-11-16 12:17 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-16  3:03 [PATCH 0/4] ALSA: seq: ump: Fix Note On/Off and key pressure conversion HyeongJun An
2026-11-16  3:03 ` [PATCH 1/4] ALSA: seq: ump: Don't turn a zero key pressure into a Note Off HyeongJun An
2026-11-16  3:03 ` [PATCH 2/4] ALSA: seq: ump: Convert a zero-velocity Note On to Note Off for MIDI 2.0 HyeongJun An
2026-11-16  3:03 ` [PATCH 3/4] ALSA: seq: ump: Keep a soft MIDI 2.0 Note On from becoming a Note Off HyeongJun An
2026-11-16  3:03 ` [PATCH 4/4] selftests/alsa: Test the sequencer UMP Note On/Off conversion HyeongJun An
2026-11-16 12:17 ` [PATCH 0/4] ALSA: seq: ump: Fix Note On/Off and key pressure conversion Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.