[PATCH 0/1] fix error handling in client

[PATCH 0/1] fix error handling in client

[Hannes Diethelm]

Hello

While writing the doc, I found a mistake in the last patch. If desired, I can also resend the
last patch with this fixes in one patch.

Regards
Hannes

Hannes Diethelm (1):
  tidbits: net-udp: fix error handling in client

 tidbits/oob-net-udp.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

-- 
2.47.3

[PATCH 1/1] tidbits: net-udp: fix error handling in client

[Hannes Diethelm]

Also fix mistake in comment

Signed-off-by: Hannes Diethelm <hannes.diethelm@gmail.com>
---
 tidbits/oob-net-udp.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tidbits/oob-net-udp.c b/tidbits/oob-net-udp.c
index 3cd7cb2..11b8459 100644
--- a/tidbits/oob-net-udp.c
+++ b/tidbits/oob-net-udp.c
@@ -8,7 +8,7 @@
  * The server mode [-S] receives a packet from on a given
  * port and sends a response to the sender's ip/port.
  *
- * The client mode [-S] sends a packet to a port/ip
+ * The client mode [-C] sends a packet to a port/ip
  * and receives the response from a server. The round
  * trip time is measured.
  *
@@ -443,6 +443,8 @@ int main(int argc, char *argv[])
 		 */
 		ret = evl_net_solicit(s, (const struct sockaddr *)&addr,
 				EVL_NEIGH_PERMANENT);
+		if (ret)
+			error(1, -ret, "evl_net_solicit()");
 
 		client(s, text, mcount, &addr, iter, delay);
 	} else if (mode == SERVER) {
-- 
2.47.3

Re: [PATCH 1/1] tidbits: net-udp: fix error handling in client

[Philippe Gerum]

Hannes Diethelm <hannes.diethelm@gmail.com> writes:

> Also fix mistake in comment
>
> Signed-off-by: Hannes Diethelm <hannes.diethelm@gmail.com>
> ---
>  tidbits/oob-net-udp.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tidbits/oob-net-udp.c b/tidbits/oob-net-udp.c
> index 3cd7cb2..11b8459 100644
> --- a/tidbits/oob-net-udp.c
> +++ b/tidbits/oob-net-udp.c
> @@ -8,7 +8,7 @@
>   * The server mode [-S] receives a packet from on a given
>   * port and sends a response to the sender's ip/port.
>   *
> - * The client mode [-S] sends a packet to a port/ip
> + * The client mode [-C] sends a packet to a port/ip
>   * and receives the response from a server. The round
>   * trip time is measured.
>   *
> @@ -443,6 +443,8 @@ int main(int argc, char *argv[])
>  		 */
>  		ret = evl_net_solicit(s, (const struct sockaddr *)&addr,
>  				EVL_NEIGH_PERMANENT);
> +		if (ret)
> +			error(1, -ret, "evl_net_solicit()");
>  
>  		client(s, text, mcount, &addr, iter, delay);
>  	} else if (mode == SERVER) {

Merged, thanks.

-- 
Philippe.

Re: [PATCH 0/1] fix error handling in client

[Philippe Gerum]

Hannes Diethelm <hannes.diethelm@gmail.com> writes:

> Hello
>
> While writing the doc, I found a mistake in the last patch. If desired, I can also resend the
> last patch with this fixes in one patch.

No need for this, thanks. Merged upstream.

-- 
Philippe.