[PATCH 1/1] usb: xhci: avoid noisy 'Starting the controller' message.

[PATCH 1/1] usb: xhci: avoid noisy 'Starting the controller' message.

[Heinrich Schuchardt]

We should avoid overwhelming users with non-essential messages.

The message 'Starting the controller' is not written for EHCI.
We should not write it for XHCI either.

Adjust the Python test accordingly.

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
 drivers/usb/host/xhci.c   | 2 +-
 test/py/tests/test_usb.py | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index 3ee1f67190f..15d81da4447 100644
--- a/drivers/usb/host/xhci.c
+++ b/drivers/usb/host/xhci.c
@@ -158,7 +158,7 @@ static int xhci_start(struct xhci_hcor *hcor)
 	u32 temp;
 	int ret;
 
-	puts("Starting the controller\n");
+	debug("Starting the controller\n");
 	temp = xhci_readl(&hcor->or_usbcmd);
 	temp |= (CMD_RUN);
 	xhci_writel(&hcor->or_usbcmd, temp);
diff --git a/test/py/tests/test_usb.py b/test/py/tests/test_usb.py
index 1dcd0834f55..9226d1c174d 100644
--- a/test/py/tests/test_usb.py
+++ b/test/py/tests/test_usb.py
@@ -58,7 +58,7 @@ def test_usb_start(ubman):
     assert 'USB init failed' not in output
     assert 'starting USB...' in output
 
-    if 'Starting the controller' in output:
+    if ubman.config.buildconfig.get('config_usb_xhci_hcd'):
         assert 'USB XHCI' in output
 
     output = ubman.run_command('echo $?')
@@ -104,7 +104,7 @@ def test_usb_reset(ubman):
     assert 'USB init failed' not in output
     assert 'resetting USB...' in output
 
-    if 'Starting the controller' in output:
+    if ubman.config.buildconfig.get('config_usb_xhci_hcd'):
         assert 'USB XHCI' in output
 
     output = ubman.run_command('echo $?')
-- 
2.51.0

Re: [PATCH 1/1] usb: xhci: avoid noisy 'Starting the controller' message.

[Mattijs Korpershoek]

Hi Heinrich,

Thank you for the patch.

On Fri, Nov 28, 2025 at 07:46, Heinrich Schuchardt <heinrich.schuchardt@canonical.com> wrote:

> We should avoid overwhelming users with non-essential messages.
>
> The message 'Starting the controller' is not written for EHCI.
> We should not write it for XHCI either.
>
> Adjust the Python test accordingly.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>

> ---
>  drivers/usb/host/xhci.c   | 2 +-
>  test/py/tests/test_usb.py | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
>