Re: [PATCH] mtd: rawnand: qcom: finish converting register to FIELD_PREP

From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	 Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	linux-mtd@lists.infradead.org,  linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: rawnand: qcom: finish converting register to FIELD_PREP
Date: Mon, 10 Feb 2025 16:15:38 +0100	[thread overview]
Message-ID: <877c5xu8yt.fsf@bootlin.com> (raw)
In-Reply-To: <20250209145439.19047-1-ansuelsmth@gmail.com> (Christian Marangi's message of "Sun, 9 Feb 2025 15:54:32 +0100")

Hello Christian,

On 09/02/2025 at 15:54:32 +01, Christian Marangi <ansuelsmth@gmail.com> wrote:

> With some research in some obscure old QSDK, it was possible to find the
> MASK of the last register there were still set with raw shift and
> convert them to FIELD_PREP API.
>
> This is only a cleanup and modernize the code a bit and doesn't make
> any behaviour change.
>
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> ---
>  drivers/mtd/nand/raw/qcom_nandc.c    | 36 ++++++++++++++--------------

I'm fine with your two patches. I was about to apply them, but the first
one needs to go through fixes, whereas the second through next, and they
are dependent on each other. I propose the following modification:
- create patch 1/2 with the content of the cleanup done just below, but
  only adapted to the very specific spot that is touched by the fix "fix
  broken config...". It would be a prerequisite for the fix.
- patch 2/2 would be the content of "fix broken config..."

And aside, a totally independent patch easy to apply on -rc1 with the
rest of this patch.

Would that work for you?

Thanks,
Miquèl