All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Raphael Gallais-Pou <rgallaispou@gmail.com>
Cc: Patrice Chotard <patrice.chotard@foss.st.com>,
	 Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	 Adrian Hunter <adrian.hunter@intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	 Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 Damien Le Moal <dlemoal@kernel.org>,
	 Niklas Cassel <cassel@kernel.org>,
	 Alexandre Torgue <alexandre.torgue@foss.st.com>,
	 Jose Abreu <joabreu@synopsys.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	 "David S. Miller" <davem@davemloft.net>,
	 Eric Dumazet <edumazet@google.com>,
	 Jakub Kicinski <kuba@kernel.org>,
	 Paolo Abeni <pabeni@redhat.com>,
	 Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	 Mark Brown <broonie@kernel.org>,
	linux-arm-kernel@lists.infradead.org,  linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org,  linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,  linux-ide@vger.kernel.org,
	netdev@vger.kernel.org,
	 linux-stm32@st-md-mailman.stormreply.com,
	linux-spi@vger.kernel.org
Subject: Re: [PATCH 3/6] mtd: st_spi_fsm: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr()
Date: Mon, 30 Dec 2024 09:46:52 +0100	[thread overview]
Message-ID: <877c7ha77n.fsf@bootlin.com> (raw)
In-Reply-To: <20241229-update_pm_macro-v1-3-c7d4c4856336@gmail.com> (Raphael Gallais-Pou's message of "Sun, 29 Dec 2024 00:32:42 +0100")

Hello Raphael,

On 29/12/2024 at 00:32:42 +01, Raphael Gallais-Pou <rgallaispou@gmail.com> wrote:

> Letting the compiler remove these functions when the kernel is built
> without CONFIG_PM_SLEEP support is simpler and less error prone than the
> use of #ifdef based kernel configuration guards.

If that does not lead to any warning, I'm fine. However this kind of
change is better received subsystem-wide than platform-wide, if you ever
wish to go this route.

> Link: https://lore.kernel.org/all/20240716180010.126987-1-rgallaispou@gmail.com

This link however seems irrelevant.

> Signed-off-by: Raphael Gallais-Pou <rgallaispou@gmail.com>

Thanks,
Miquèl


WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Raphael Gallais-Pou <rgallaispou@gmail.com>
Cc: Patrice Chotard <patrice.chotard@foss.st.com>,
	 Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	 Adrian Hunter <adrian.hunter@intel.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	 Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 Damien Le Moal <dlemoal@kernel.org>,
	 Niklas Cassel <cassel@kernel.org>,
	 Alexandre Torgue <alexandre.torgue@foss.st.com>,
	 Jose Abreu <joabreu@synopsys.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	 "David S. Miller" <davem@davemloft.net>,
	 Eric Dumazet <edumazet@google.com>,
	 Jakub Kicinski <kuba@kernel.org>,
	 Paolo Abeni <pabeni@redhat.com>,
	 Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	 Mark Brown <broonie@kernel.org>,
	linux-arm-kernel@lists.infradead.org,  linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org,  linux-mmc@vger.kernel.org,
	linux-mtd@lists.infradead.org,  linux-ide@vger.kernel.org,
	netdev@vger.kernel.org,
	 linux-stm32@st-md-mailman.stormreply.com,
	linux-spi@vger.kernel.org
Subject: Re: [PATCH 3/6] mtd: st_spi_fsm: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr()
Date: Mon, 30 Dec 2024 09:46:52 +0100	[thread overview]
Message-ID: <877c7ha77n.fsf@bootlin.com> (raw)
In-Reply-To: <20241229-update_pm_macro-v1-3-c7d4c4856336@gmail.com> (Raphael Gallais-Pou's message of "Sun, 29 Dec 2024 00:32:42 +0100")

Hello Raphael,

On 29/12/2024 at 00:32:42 +01, Raphael Gallais-Pou <rgallaispou@gmail.com> wrote:

> Letting the compiler remove these functions when the kernel is built
> without CONFIG_PM_SLEEP support is simpler and less error prone than the
> use of #ifdef based kernel configuration guards.

If that does not lead to any warning, I'm fine. However this kind of
change is better received subsystem-wide than platform-wide, if you ever
wish to go this route.

> Link: https://lore.kernel.org/all/20240716180010.126987-1-rgallaispou@gmail.com

This link however seems irrelevant.

> Signed-off-by: Raphael Gallais-Pou <rgallaispou@gmail.com>

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2024-12-30  8:48 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-28 23:32 [PATCH 0/6] Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr() Raphael Gallais-Pou
2024-12-28 23:32 ` Raphael Gallais-Pou
2024-12-28 23:32 ` [PATCH 1/6] usb: dwc3: st: " Raphael Gallais-Pou
2024-12-28 23:32   ` Raphael Gallais-Pou
2024-12-28 23:32 ` [PATCH 2/6] mmc: sdhci-st: " Raphael Gallais-Pou
2024-12-28 23:32   ` Raphael Gallais-Pou
2024-12-29  1:39   ` kernel test robot
2024-12-29  1:39     ` kernel test robot
2024-12-29  5:38   ` kernel test robot
2024-12-29  5:38     ` kernel test robot
2024-12-28 23:32 ` [PATCH 3/6] mtd: st_spi_fsm: " Raphael Gallais-Pou
2024-12-28 23:32   ` Raphael Gallais-Pou
2024-12-30  8:46   ` Miquel Raynal [this message]
2024-12-30  8:46     ` Miquel Raynal
2024-12-28 23:32 ` [PATCH 4/6] ahci: st: " Raphael Gallais-Pou
2024-12-28 23:32   ` Raphael Gallais-Pou
2024-12-28 23:32 ` [PATCH 5/6] net: stmmac: sti: " Raphael Gallais-Pou
2024-12-28 23:32   ` Raphael Gallais-Pou
2024-12-28 23:32 ` [PATCH 6/6] spi: st: " Raphael Gallais-Pou
2024-12-28 23:32   ` Raphael Gallais-Pou
2024-12-29  1:28   ` kernel test robot
2024-12-29  1:28     ` kernel test robot
2025-01-06 13:08 ` [PATCH 0/6] " Mark Brown
2025-01-06 13:08   ` Mark Brown
2025-01-07  0:31   ` Raphaël Gallais-Pou
2025-01-07  0:31     ` Raphaël Gallais-Pou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877c7ha77n.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=adrian.hunter@intel.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=broonie@kernel.org \
    --cc=cassel@kernel.org \
    --cc=davem@davemloft.net \
    --cc=dlemoal@kernel.org \
    --cc=edumazet@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=joabreu@synopsys.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=patrice.chotard@foss.st.com \
    --cc=rgallaispou@gmail.com \
    --cc=richard@nod.at \
    --cc=ulf.hansson@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.