From: Michael Ellerman <mpe@ellerman.id.au>
To: Jason Gunthorpe <jgg@ziepe.ca>, Shivaprasad G Bhat <sbhat@linux.ibm.com>
Cc: svaidy@linux.ibm.com, robh@kernel.org, jroedel@suse.de,
kvm@vger.kernel.org, gbatra@linux.vnet.ibm.com, aik@ozlabs.ru,
alex.williamson@redhat.com, linux-kernel@vger.kernel.org,
aneesh.kumar@kernel.org, brking@linux.vnet.ibm.com,
tpearson@raptorengineering.com, npiggin@gmail.com,
naveen.n.rao@linux.ibm.com, vaibhav@linux.ibm.com,
msuchanek@suse.de, linuxppc-dev@lists.ozlabs.org, aik@amd.com
Subject: Re: [RFC PATCH 1/3] powerpc/pseries/iommu: Bring back userspace view for single level TCE tables
Date: Fri, 22 Mar 2024 16:49:43 +1100 [thread overview]
Message-ID: <877chuke88.fsf@mail.lhotse> (raw)
In-Reply-To: <20240319143202.GA66976@ziepe.ca>
Jason Gunthorpe <jgg@ziepe.ca> writes:
> On Tue, Mar 12, 2024 at 01:14:20PM -0500, Shivaprasad G Bhat wrote:
>> The commit 090bad39b237a ("powerpc/powernv: Add indirect levels to
>> it_userspace") which implemented the tce indirect levels
>> support for PowerNV ended up removing the single level support
>> which existed by default(generic tce_iommu_userspace_view_alloc/free()
>> calls). On pSeries the TCEs are single level, and the allocation
>> of userspace view is lost with the removal of generic code.
>
> :( :(
>
> If this has been broken since 2018 and nobody cared till now can we
> please go in a direction of moving this code to the new iommu APIs
> instead of doubling down on more of this old stuff that apparently
> almost nobody cares about ??
It's broken *on pseries* (Linux as a guest), but it works fine on
powernv (aka bare metal, aka Linux as Hypervisor).
What's changed is folks are now testing it on pseries with Linux as a
nested hypervisor.
cheers
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Jason Gunthorpe <jgg@ziepe.ca>, Shivaprasad G Bhat <sbhat@linux.ibm.com>
Cc: tpearson@raptorengineering.com, alex.williamson@redhat.com,
linuxppc-dev@lists.ozlabs.org, npiggin@gmail.com,
christophe.leroy@csgroup.eu, aneesh.kumar@kernel.org,
naveen.n.rao@linux.ibm.com, gbatra@linux.vnet.ibm.com,
brking@linux.vnet.ibm.com, aik@ozlabs.ru, robh@kernel.org,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org, aik@amd.com,
msuchanek@suse.de, jroedel@suse.de, vaibhav@linux.ibm.com,
svaidy@linux.ibm.com
Subject: Re: [RFC PATCH 1/3] powerpc/pseries/iommu: Bring back userspace view for single level TCE tables
Date: Fri, 22 Mar 2024 16:49:43 +1100 [thread overview]
Message-ID: <877chuke88.fsf@mail.lhotse> (raw)
In-Reply-To: <20240319143202.GA66976@ziepe.ca>
Jason Gunthorpe <jgg@ziepe.ca> writes:
> On Tue, Mar 12, 2024 at 01:14:20PM -0500, Shivaprasad G Bhat wrote:
>> The commit 090bad39b237a ("powerpc/powernv: Add indirect levels to
>> it_userspace") which implemented the tce indirect levels
>> support for PowerNV ended up removing the single level support
>> which existed by default(generic tce_iommu_userspace_view_alloc/free()
>> calls). On pSeries the TCEs are single level, and the allocation
>> of userspace view is lost with the removal of generic code.
>
> :( :(
>
> If this has been broken since 2018 and nobody cared till now can we
> please go in a direction of moving this code to the new iommu APIs
> instead of doubling down on more of this old stuff that apparently
> almost nobody cares about ??
It's broken *on pseries* (Linux as a guest), but it works fine on
powernv (aka bare metal, aka Linux as Hypervisor).
What's changed is folks are now testing it on pseries with Linux as a
nested hypervisor.
cheers
next prev parent reply other threads:[~2024-03-22 5:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 18:14 [RFC PATCH 0/3] powerpc: pSeries: vfio: iommu: Re-enable support for SPAPR TCE VFIO Shivaprasad G Bhat
2024-03-12 18:14 ` Shivaprasad G Bhat
2024-03-12 18:14 ` [RFC PATCH 1/3] powerpc/pseries/iommu: Bring back userspace view for single level TCE tables Shivaprasad G Bhat
2024-03-12 18:14 ` Shivaprasad G Bhat
2024-03-19 14:32 ` Jason Gunthorpe
2024-03-19 14:32 ` Jason Gunthorpe
2024-03-19 18:36 ` Timothy Pearson
2024-03-19 18:36 ` Timothy Pearson
2024-10-03 13:38 ` Jason Gunthorpe
2024-03-20 15:29 ` Shivaprasad G Bhat
2024-03-20 15:29 ` Shivaprasad G Bhat
2024-03-22 5:49 ` Michael Ellerman [this message]
2024-03-22 5:49 ` Michael Ellerman
2024-03-12 18:14 ` [RFC PATCH 2/3] powerpc/iommu: Move pSeries specific functions to pseries/iommu.c Shivaprasad G Bhat
2024-03-12 18:14 ` Shivaprasad G Bhat
2024-03-12 18:14 ` [RFC PATCH 3/3] pseries/iommu: Enable DDW for VFIO TCE create Shivaprasad G Bhat
2024-03-12 18:14 ` Shivaprasad G Bhat
2024-03-13 12:53 ` Michael Ellerman
2024-03-13 12:53 ` Michael Ellerman
2024-03-26 4:56 ` Shivaprasad G Bhat
2024-03-26 4:56 ` Shivaprasad G Bhat
2024-03-14 15:10 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877chuke88.fsf@mail.lhotse \
--to=mpe@ellerman.id.au \
--cc=aik@amd.com \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=aneesh.kumar@kernel.org \
--cc=brking@linux.vnet.ibm.com \
--cc=gbatra@linux.vnet.ibm.com \
--cc=jgg@ziepe.ca \
--cc=jroedel@suse.de \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=msuchanek@suse.de \
--cc=naveen.n.rao@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=robh@kernel.org \
--cc=sbhat@linux.ibm.com \
--cc=svaidy@linux.ibm.com \
--cc=tpearson@raptorengineering.com \
--cc=vaibhav@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.