From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: sasha.neftin@intel.com, netdev@vger.kernel.org,
kurt@linutronix.de, jesse.brandeburg@intel.com,
linux-kernel@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
anthony.l.nguyen@intel.com,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Jakub Kicinski <kuba@kernel.org>,
intel-wired-lan@lists.osuosl.org, Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Intel-wired-lan] [iwl-net v1 2/2] igb: Fix missing time sync events
Date: Tue, 20 Feb 2024 09:30:33 -0800 [thread overview]
Message-ID: <877ciz59hi.fsf@intel.com> (raw)
In-Reply-To: <ZdDk9AHE8svlNbbl@hoboy.vegasvil.org>
Richard Cochran <richardcochran@gmail.com> writes:
> On Sat, Feb 17, 2024 at 07:05:07AM -0800, Richard Cochran wrote:
>
>> Does setting ICR.Time_Sync[TXTS] also clear ICR.Time_Sync[RXTS] ?
>>
>> That is what you seem to be saying.
>
> Okay, so you really mean that if the _same_ bit becomes set between
> the read and the acknowledgment, then that event will be missed,
> right?
>
Yeah, I will reword the commit messages so it's clearer that it's the
same bit.
> In that case, thank you for fixing this more than nine year old bug!
>
> Acked-by: Richard Cochran <richardcochran@gmail.com>
>
>
Thank you,
--
Vinicius
WARNING: multiple messages have this Message-ID (diff)
From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: intel-wired-lan@lists.osuosl.org, sasha.neftin@intel.com,
kurt@linutronix.de, anthony.l.nguyen@intel.com,
jesse.brandeburg@intel.com,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [iwl-net v1 2/2] igb: Fix missing time sync events
Date: Tue, 20 Feb 2024 09:30:33 -0800 [thread overview]
Message-ID: <877ciz59hi.fsf@intel.com> (raw)
In-Reply-To: <ZdDk9AHE8svlNbbl@hoboy.vegasvil.org>
Richard Cochran <richardcochran@gmail.com> writes:
> On Sat, Feb 17, 2024 at 07:05:07AM -0800, Richard Cochran wrote:
>
>> Does setting ICR.Time_Sync[TXTS] also clear ICR.Time_Sync[RXTS] ?
>>
>> That is what you seem to be saying.
>
> Okay, so you really mean that if the _same_ bit becomes set between
> the read and the acknowledgment, then that event will be missed,
> right?
>
Yeah, I will reword the commit messages so it's clearer that it's the
same bit.
> In that case, thank you for fixing this more than nine year old bug!
>
> Acked-by: Richard Cochran <richardcochran@gmail.com>
>
>
Thank you,
--
Vinicius
next prev parent reply other threads:[~2024-02-20 17:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-17 1:04 [Intel-wired-lan] [iwl-net v1 0/2] igc/igb: Fix missing time sync events Vinicius Costa Gomes
2024-02-17 1:04 ` [Intel-wired-lan] [iwl-net v1 1/2] igc: " Vinicius Costa Gomes
2024-02-17 1:04 ` Vinicius Costa Gomes
2024-02-18 15:40 ` [Intel-wired-lan] " Kurt Kanzenbach
2024-02-18 15:40 ` Kurt Kanzenbach
2024-02-17 1:04 ` [Intel-wired-lan] [iwl-net v1 2/2] igb: " Vinicius Costa Gomes
2024-02-17 1:04 ` Vinicius Costa Gomes
2024-02-17 15:05 ` [Intel-wired-lan] " Richard Cochran
2024-02-17 15:05 ` Richard Cochran
2024-02-17 16:55 ` [Intel-wired-lan] " Richard Cochran
2024-02-17 16:55 ` Richard Cochran
2024-02-20 17:30 ` Vinicius Costa Gomes [this message]
2024-02-20 17:30 ` Vinicius Costa Gomes
2024-02-17 15:13 ` [Intel-wired-lan] [iwl-net v1 0/2] igc/igb: " Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ciz59hi.fsf@intel.com \
--to=vinicius.gomes@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=sasha.neftin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.