All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH 0/4] DP DSC min/max src bpc fixes
@ 2023-11-07  4:17 Ankit Nautiyal
  2023-11-07  4:17 ` [Intel-gfx] [PATCH 1/4] drm/i915/dp: Simplify checks for helper intel_dp_dsc_max_src_input_bpc Ankit Nautiyal
                   ` (7 more replies)
  0 siblings, 8 replies; 18+ messages in thread
From: Ankit Nautiyal @ 2023-11-07  4:17 UTC (permalink / raw)
  To: intel-gfx; +Cc: jani.nikula

Use helpers for source min/max src bpc appropriately for dp mst case and
to limit max_requested_bpc property min/max values. 

Rev2: Dropped patch to limit max_requested_bpc based on src DSC bpc
limits. Instead added change to ignore max_requested_bpc if its
too low for DSC.

Ankit Nautiyal (4):
  drm/i915/dp: Simplify checks for helper intel_dp_dsc_max_src_input_bpc
  drm/i915/dp: Fix the max DSC bpc supported by source
  drm/i915/dp_mst: Use helpers to get dsc min/max input bpc
  drm/i915/dp: Ignore max_requested_bpc if its too low for DSC

 drivers/gpu/drm/i915/display/intel_dp.c     | 33 ++++++++++++++-------
 drivers/gpu/drm/i915/display/intel_dp.h     |  2 ++
 drivers/gpu/drm/i915/display/intel_dp_mst.c | 11 +++----
 3 files changed, 29 insertions(+), 17 deletions(-)

-- 
2.40.1


^ permalink raw reply	[flat|nested] 18+ messages in thread
* [Intel-gfx] [PATCH 0/4] DP DSC min/max src bpc fixes
@ 2023-11-23  4:27 Ankit Nautiyal
  2023-11-23  4:27 ` [Intel-gfx] [PATCH 1/4] drm/i915/dp: Simplify checks for helper intel_dp_dsc_max_src_input_bpc Ankit Nautiyal
  0 siblings, 1 reply; 18+ messages in thread
From: Ankit Nautiyal @ 2023-11-23  4:27 UTC (permalink / raw)
  To: intel-gfx; +Cc: jani.nikula

Use helpers for source min/max src bpc appropriately for dp mst case and
to limit max_requested_bpc property min/max values. 

Rev2: Dropped patch to limit max_requested_bpc based on src DSC bpc
limits. Instead added change to ignore max_requested_bpc if its
too low for DSC.

Rev3: Updated patch#1 commit message.

Rev4: Rebased.

Ankit Nautiyal (4):
  drm/i915/dp: Simplify checks for helper intel_dp_dsc_max_src_input_bpc
  drm/i915/dp: Fix the max DSC bpc supported by source
  drm/i915/dp_mst: Use helpers to get dsc min/max input bpc
  drm/i915/dp: Ignore max_requested_bpc if its too low for DSC

 drivers/gpu/drm/i915/display/intel_dp.c     | 33 ++++++++++++++-------
 drivers/gpu/drm/i915/display/intel_dp.h     |  2 ++
 drivers/gpu/drm/i915/display/intel_dp_mst.c | 11 +++----
 3 files changed, 29 insertions(+), 17 deletions(-)

-- 
2.40.1


^ permalink raw reply	[flat|nested] 18+ messages in thread
* [Intel-gfx] [PATCH 1/4] drm/i915/dp: Simplify checks for helper intel_dp_dsc_max_src_input_bpc
@ 2023-11-08 15:15 Ankit Nautiyal
  0 siblings, 0 replies; 18+ messages in thread
From: Ankit Nautiyal @ 2023-11-08 15:15 UTC (permalink / raw)
  To: 20231107041740.3718419-2-ankit.k.nautiyal, intel-gfx; +Cc: jani.nikula

In helper intel_dp_dsc_max_src_input_bpc it is assumed that platforms
earlier to ICL do not support DSC, and the function returns 0 for
those platforms.

Use HAS_DSC macro instead and return 0 for platforms that do not support
DSC.

v2: Updated commit message with clarification. (Jani)

Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 5391b2a83405..30ea4820b210 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -1569,13 +1569,14 @@ intel_dp_compute_link_config_wide(struct intel_dp *intel_dp,
 static
 u8 intel_dp_dsc_max_src_input_bpc(struct drm_i915_private *i915)
 {
+	if (!HAS_DSC(i915))
+		return 0;
+
 	/* Max DSC Input BPC for ICL is 10 and for TGL+ is 12 */
-	if (DISPLAY_VER(i915) >= 12)
-		return 12;
 	if (DISPLAY_VER(i915) == 11)
 		return 10;
 
-	return 0;
+	return 12;
 }
 
 int intel_dp_dsc_compute_max_bpp(const struct intel_connector *connector,
-- 
2.40.1


^ permalink raw reply related	[flat|nested] 18+ messages in thread
* [Intel-gfx] [PATCH 0/4] DP DSC min/max src bpc fixes
@ 2023-10-25 12:13 Ankit Nautiyal
  2023-10-25 12:13 ` [Intel-gfx] [PATCH 1/4] drm/i915/dp: Simplify checks for helper intel_dp_dsc_max_src_input_bpc Ankit Nautiyal
  0 siblings, 1 reply; 18+ messages in thread
From: Ankit Nautiyal @ 2023-10-25 12:13 UTC (permalink / raw)
  To: intel-gfx; +Cc: jani.nikula

Use helpers for source min/max src bpc appropriately for dp mst case and
to limit max_requested_bpc property min/max values. 

Ankit Nautiyal (4):
  drm/i915/dp: Simplify checks for helper intel_dp_dsc_max_src_input_bpc
  drm/i915/dp: Fix the max DSC bpc supported by source
  drm/i915/dp_mst: Use helpers to get dsc min/max input bpc
  drm/i915/dp: Limit max_requested_bpc based on src DSC bpc limits

 drivers/gpu/drm/i915/display/intel_dp.c     | 24 ++++++++++++++-------
 drivers/gpu/drm/i915/display/intel_dp.h     |  2 ++
 drivers/gpu/drm/i915/display/intel_dp_mst.c | 11 ++++------
 3 files changed, 22 insertions(+), 15 deletions(-)

-- 
2.40.1


^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2023-11-23  4:33 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-07  4:17 [Intel-gfx] [PATCH 0/4] DP DSC min/max src bpc fixes Ankit Nautiyal
2023-11-07  4:17 ` [Intel-gfx] [PATCH 1/4] drm/i915/dp: Simplify checks for helper intel_dp_dsc_max_src_input_bpc Ankit Nautiyal
2023-11-07  9:58   ` Jani Nikula
2023-11-08  4:02     ` Nautiyal, Ankit K
2023-11-16 14:54   ` Ankit Nautiyal
2023-11-07  4:17 ` [Intel-gfx] [PATCH 2/4] drm/i915/dp: Fix the max DSC bpc supported by source Ankit Nautiyal
2023-11-07  4:17 ` [Intel-gfx] [PATCH 3/4] drm/i915/dp_mst: Use helpers to get dsc min/max input bpc Ankit Nautiyal
2023-11-09  6:36   ` Kandpal, Suraj
2023-11-07  4:17 ` [Intel-gfx] [PATCH 4/4] drm/i915/dp: Ignore max_requested_bpc if its too low for DSC Ankit Nautiyal
2023-11-09  6:49   ` Kandpal, Suraj
2023-11-15  9:01     ` Nautiyal, Ankit K
2023-11-07  5:01 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for DP DSC min/max src bpc fixes (rev2) Patchwork
2023-11-07  5:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-11-07 14:09 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-11-16 20:08 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for DP DSC min/max src bpc fixes (rev4) Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2023-11-23  4:27 [Intel-gfx] [PATCH 0/4] DP DSC min/max src bpc fixes Ankit Nautiyal
2023-11-23  4:27 ` [Intel-gfx] [PATCH 1/4] drm/i915/dp: Simplify checks for helper intel_dp_dsc_max_src_input_bpc Ankit Nautiyal
2023-11-08 15:15 Ankit Nautiyal
2023-10-25 12:13 [Intel-gfx] [PATCH 0/4] DP DSC min/max src bpc fixes Ankit Nautiyal
2023-10-25 12:13 ` [Intel-gfx] [PATCH 1/4] drm/i915/dp: Simplify checks for helper intel_dp_dsc_max_src_input_bpc Ankit Nautiyal

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.