All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: <ath12k@lists.infradead.org>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 2/2] wifi: ath12k: fix undefined behavior with __fls in dp
Date: Tue, 22 Aug 2023 16:27:39 +0300	[thread overview]
Message-ID: <877cpni4vo.fsf@kernel.org> (raw)
In-Reply-To: <ab94c255-8ac3-4b2a-a7a5-af40058ad6e6@quicinc.com> (Jeff Johnson's message of "Mon, 21 Aug 2023 08:27:53 -0700")

Jeff Johnson <quic_jjohnson@quicinc.com> writes:

> On 8/21/2023 6:03 AM, Harshitha Prem wrote:
>> When max virtual ap interfaces are configured in all the bands
>> with ACS and hostapd restart is done every 60s,
>> a crash is observed at random times because of handling the
>> uninitialized peer fragments with fragment id of packet as 0.
>> "__fls" would have an undefined behavior if the argument is passed
>> as "0". Hence, added changes to handle the same.
>> Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7
>> devices")
>
> this should be in the last section with the Signed-off-by
>
> see
> <https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes>

I can fix that in the pending branch, no need to resend because of this.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
ath12k mailing list
ath12k@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/ath12k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@kernel.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: <ath12k@lists.infradead.org>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2 2/2] wifi: ath12k: fix undefined behavior with __fls in dp
Date: Tue, 22 Aug 2023 16:27:39 +0300	[thread overview]
Message-ID: <877cpni4vo.fsf@kernel.org> (raw)
In-Reply-To: <ab94c255-8ac3-4b2a-a7a5-af40058ad6e6@quicinc.com> (Jeff Johnson's message of "Mon, 21 Aug 2023 08:27:53 -0700")

Jeff Johnson <quic_jjohnson@quicinc.com> writes:

> On 8/21/2023 6:03 AM, Harshitha Prem wrote:
>> When max virtual ap interfaces are configured in all the bands
>> with ACS and hostapd restart is done every 60s,
>> a crash is observed at random times because of handling the
>> uninitialized peer fragments with fragment id of packet as 0.
>> "__fls" would have an undefined behavior if the argument is passed
>> as "0". Hence, added changes to handle the same.
>> Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7
>> devices")
>
> this should be in the last section with the Signed-off-by
>
> see
> <https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes>

I can fix that in the pending branch, no need to resend because of this.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2023-08-22 13:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-21 13:03 [PATCH v2 0/2] wifi: ath12k: Ignore fragments from uninitialized peer Harshitha Prem
2023-08-21 13:03 ` Harshitha Prem
2023-08-21 13:03 ` [PATCH v2 1/2] wifi: ath12k: Ignore fragments from uninitialized peer in dp Harshitha Prem
2023-08-21 13:03   ` Harshitha Prem
2023-09-05 13:26   ` Kalle Valo
2023-09-05 13:26     ` Kalle Valo
2023-08-21 13:03 ` [PATCH v2 2/2] wifi: ath12k: fix undefined behavior with __fls " Harshitha Prem
2023-08-21 13:03   ` Harshitha Prem
2023-08-21 15:27   ` Jeff Johnson
2023-08-22 13:27     ` Kalle Valo [this message]
2023-08-22 13:27       ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cpni4vo.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=ath12k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=quic_jjohnson@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.