All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Jordan Niethe <jniethe5@gmail.com>, linuxppc-dev@lists.ozlabs.org
Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, npiggin@gmail.com,
	mikey@neuling.org, paulus@ozlabs.org, vaibhav@linux.ibm.com,
	sbhat@linux.ibm.com, gautam@linux.ibm.com,
	kconsul@linux.vnet.ibm.com, amachhiw@linux.vnet.ibm.com,
	Jordan Niethe <jniethe5@gmail.com>
Subject: Re: [PATCH v3 5/6] KVM: PPC: Add support for nestedv2 guests
Date: Thu, 17 Aug 2023 12:23:58 +0000	[thread overview]
Message-ID: <877cpteu1t.fsf@mail.lhotse> (raw)
In-Reply-To: <20230807014553.1168699-6-jniethe5@gmail.com>

Jordan Niethe <jniethe5@gmail.com> writes:
> A series of hcalls have been added to the PAPR which allow a regular
> guest partition to create and manage guest partitions of its own. KVM
> already had an interface that allowed this on powernv platforms. This
> existing interface will now be called "nestedv1". The newly added PAPR
> interface will be called "nestedv2".  PHYP will support the nestedv2
> interface. At this time the host side of the nestedv2 interface has not
> been implemented on powernv but there is no technical reason why it
> could not be added.

Some build errors with powernv_defconfig, I haven't dug into them but
presumably some ifdefs needed.

  ../arch/powerpc/kvm/book3s_hv_nestedv2.c: In function ‘kvmhv_nestedv2_vcpu_create’:
  ../arch/powerpc/kvm/book3s_hv_nestedv2.c:954:14: error: implicit declaration of function ‘plpar_guest_create_vcpu’ [-Werror=implicit-function-declaration]
    954 |         rc = plpar_guest_create_vcpu(0, vcpu->kvm->arch.lpid, vcpu->vcpu_id);
        |              ^~~~~~~~~~~~~~~~~~~~~~~
  ../arch/powerpc/kvm/guest-state-buffer.c: In function ‘kvmppc_gsb_send’:
  ../arch/powerpc/kvm/guest-state-buffer.c:592:14: error: implicit declaration of function ‘plpar_guest_set_state’ [-Werror=implicit-function-declaration]
    592 |         rc = plpar_guest_set_state(hflags, gsb->guest_id, gsb->vcpu_id,
        |              ^~~~~~~~~~~~~~~~~~~~~
  ../arch/powerpc/kvm/guest-state-buffer.c: In function ‘kvmppc_gsb_recv’:
  ../arch/powerpc/kvm/guest-state-buffer.c:617:14: error: implicit declaration of function ‘plpar_guest_get_state’ [-Werror=implicit-function-declaration]
    617 |         rc = plpar_guest_get_state(hflags, gsb->guest_id, gsb->vcpu_id,


cheers

WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Jordan Niethe <jniethe5@gmail.com>, linuxppc-dev@lists.ozlabs.org
Cc: mikey@neuling.org, sbhat@linux.ibm.com, kvm@vger.kernel.org,
	amachhiw@linux.vnet.ibm.com, Jordan Niethe <jniethe5@gmail.com>,
	gautam@linux.ibm.com, npiggin@gmail.com, kvm-ppc@vger.kernel.org,
	vaibhav@linux.ibm.com, kconsul@linux.vnet.ibm.com
Subject: Re: [PATCH v3 5/6] KVM: PPC: Add support for nestedv2 guests
Date: Thu, 17 Aug 2023 22:23:58 +1000	[thread overview]
Message-ID: <877cpteu1t.fsf@mail.lhotse> (raw)
In-Reply-To: <20230807014553.1168699-6-jniethe5@gmail.com>

Jordan Niethe <jniethe5@gmail.com> writes:
> A series of hcalls have been added to the PAPR which allow a regular
> guest partition to create and manage guest partitions of its own. KVM
> already had an interface that allowed this on powernv platforms. This
> existing interface will now be called "nestedv1". The newly added PAPR
> interface will be called "nestedv2".  PHYP will support the nestedv2
> interface. At this time the host side of the nestedv2 interface has not
> been implemented on powernv but there is no technical reason why it
> could not be added.

Some build errors with powernv_defconfig, I haven't dug into them but
presumably some ifdefs needed.

  ../arch/powerpc/kvm/book3s_hv_nestedv2.c: In function ‘kvmhv_nestedv2_vcpu_create’:
  ../arch/powerpc/kvm/book3s_hv_nestedv2.c:954:14: error: implicit declaration of function ‘plpar_guest_create_vcpu’ [-Werror=implicit-function-declaration]
    954 |         rc = plpar_guest_create_vcpu(0, vcpu->kvm->arch.lpid, vcpu->vcpu_id);
        |              ^~~~~~~~~~~~~~~~~~~~~~~
  ../arch/powerpc/kvm/guest-state-buffer.c: In function ‘kvmppc_gsb_send’:
  ../arch/powerpc/kvm/guest-state-buffer.c:592:14: error: implicit declaration of function ‘plpar_guest_set_state’ [-Werror=implicit-function-declaration]
    592 |         rc = plpar_guest_set_state(hflags, gsb->guest_id, gsb->vcpu_id,
        |              ^~~~~~~~~~~~~~~~~~~~~
  ../arch/powerpc/kvm/guest-state-buffer.c: In function ‘kvmppc_gsb_recv’:
  ../arch/powerpc/kvm/guest-state-buffer.c:617:14: error: implicit declaration of function ‘plpar_guest_get_state’ [-Werror=implicit-function-declaration]
    617 |         rc = plpar_guest_get_state(hflags, gsb->guest_id, gsb->vcpu_id,


cheers

WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Jordan Niethe <jniethe5@gmail.com>, linuxppc-dev@lists.ozlabs.org
Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, npiggin@gmail.com,
	mikey@neuling.org, paulus@ozlabs.org, vaibhav@linux.ibm.com,
	sbhat@linux.ibm.com, gautam@linux.ibm.com,
	kconsul@linux.vnet.ibm.com, amachhiw@linux.vnet.ibm.com,
	Jordan Niethe <jniethe5@gmail.com>
Subject: Re: [PATCH v3 5/6] KVM: PPC: Add support for nestedv2 guests
Date: Thu, 17 Aug 2023 22:23:58 +1000	[thread overview]
Message-ID: <877cpteu1t.fsf@mail.lhotse> (raw)
In-Reply-To: <20230807014553.1168699-6-jniethe5@gmail.com>

Jordan Niethe <jniethe5@gmail.com> writes:
> A series of hcalls have been added to the PAPR which allow a regular
> guest partition to create and manage guest partitions of its own. KVM
> already had an interface that allowed this on powernv platforms. This
> existing interface will now be called "nestedv1". The newly added PAPR
> interface will be called "nestedv2".  PHYP will support the nestedv2
> interface. At this time the host side of the nestedv2 interface has not
> been implemented on powernv but there is no technical reason why it
> could not be added.

Some build errors with powernv_defconfig, I haven't dug into them but
presumably some ifdefs needed.

  ../arch/powerpc/kvm/book3s_hv_nestedv2.c: In function ‘kvmhv_nestedv2_vcpu_create’:
  ../arch/powerpc/kvm/book3s_hv_nestedv2.c:954:14: error: implicit declaration of function ‘plpar_guest_create_vcpu’ [-Werror=implicit-function-declaration]
    954 |         rc = plpar_guest_create_vcpu(0, vcpu->kvm->arch.lpid, vcpu->vcpu_id);
        |              ^~~~~~~~~~~~~~~~~~~~~~~
  ../arch/powerpc/kvm/guest-state-buffer.c: In function ‘kvmppc_gsb_send’:
  ../arch/powerpc/kvm/guest-state-buffer.c:592:14: error: implicit declaration of function ‘plpar_guest_set_state’ [-Werror=implicit-function-declaration]
    592 |         rc = plpar_guest_set_state(hflags, gsb->guest_id, gsb->vcpu_id,
        |              ^~~~~~~~~~~~~~~~~~~~~
  ../arch/powerpc/kvm/guest-state-buffer.c: In function ‘kvmppc_gsb_recv’:
  ../arch/powerpc/kvm/guest-state-buffer.c:617:14: error: implicit declaration of function ‘plpar_guest_get_state’ [-Werror=implicit-function-declaration]
    617 |         rc = plpar_guest_get_state(hflags, gsb->guest_id, gsb->vcpu_id,


cheers

  parent reply	other threads:[~2023-08-17 12:23 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-07  1:45 [PATCH v3 0/6] KVM: PPC: Nested APIv2 guest support Jordan Niethe
2023-08-07  1:45 ` Jordan Niethe
2023-08-07  1:45 ` Jordan Niethe
2023-08-07  1:45 ` [PATCH v3 1/6] KVM: PPC: Use getters and setters for vcpu register state Jordan Niethe
2023-08-07  1:45   ` Jordan Niethe
2023-08-07  1:45   ` Jordan Niethe
2023-08-14  8:08   ` Nicholas Piggin
2023-08-14  8:08     ` Nicholas Piggin
2023-08-14  8:08     ` Nicholas Piggin
2023-08-16  3:11     ` Jordan Niethe
2023-08-16  3:11       ` Jordan Niethe
2023-08-16  3:11       ` Jordan Niethe
2023-08-17  3:25   ` Michael Ellerman
2023-08-17  3:25     ` Michael Ellerman
2023-08-17  3:25     ` Michael Ellerman
2023-08-07  1:45 ` [PATCH v3 2/6] KVM: PPC: Rename accessor generator macros Jordan Niethe
2023-08-07  1:45   ` Jordan Niethe
2023-08-07  1:45   ` Jordan Niethe
2023-08-14  8:27   ` Nicholas Piggin
2023-08-14  8:27     ` Nicholas Piggin
2023-08-14  8:27     ` Nicholas Piggin
2023-08-16  3:20     ` Jordan Niethe
2023-08-16  3:20       ` Jordan Niethe
2023-08-16  3:20       ` Jordan Niethe
2023-08-07  1:45 ` [PATCH v3 3/6] KVM: PPC: Add helper library for Guest State Buffers Jordan Niethe
2023-08-07  1:45   ` Jordan Niethe
2023-08-07  1:45   ` Jordan Niethe
2023-08-07  1:45 ` [PATCH v3 4/6] KVM: PPC: Book3s HV: Hold LPIDs in an unsigned long Jordan Niethe
2023-08-07  1:45   ` Jordan Niethe
2023-08-07  1:45   ` Jordan Niethe
2023-08-14  8:12   ` Nicholas Piggin
2023-08-14  8:12     ` Nicholas Piggin
2023-08-14  8:12     ` Nicholas Piggin
2023-08-15 10:45     ` Michael Ellerman
2023-08-15 10:45       ` Michael Ellerman
2023-08-15 10:45       ` Michael Ellerman
2023-08-16  3:21       ` Jordan Niethe
2023-08-16  3:21         ` Jordan Niethe
2023-08-16  3:21         ` Jordan Niethe
2023-08-16  3:14     ` Jordan Niethe
2023-08-16  3:14       ` Jordan Niethe
2023-08-16  3:14       ` Jordan Niethe
2023-08-14  8:15   ` David Laight
2023-08-16  3:19     ` Jordan Niethe
2023-08-16  3:19       ` Jordan Niethe
2023-08-17 12:21   ` Michael Ellerman
2023-08-17 12:21     ` Michael Ellerman
2023-08-17 12:21     ` Michael Ellerman
2023-08-07  1:45 ` [PATCH v3 5/6] KVM: PPC: Add support for nestedv2 guests Jordan Niethe
2023-08-07  1:45   ` Jordan Niethe
2023-08-07  1:45   ` Jordan Niethe
2023-08-17  4:19   ` Michael Ellerman
2023-08-17  4:19     ` Michael Ellerman
2023-08-17  4:19     ` Michael Ellerman
2023-08-17 12:23   ` Michael Ellerman [this message]
2023-08-17 12:23     ` Michael Ellerman
2023-08-17 12:23     ` Michael Ellerman
2023-08-07  1:45 ` [PATCH v3 6/6] docs: powerpc: Document nested KVM on POWER Jordan Niethe
2023-08-07  1:45   ` Jordan Niethe
2023-08-07  1:45   ` Jordan Niethe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cpteu1t.fsf@mail.lhotse \
    --to=mpe@ellerman.id.au \
    --cc=amachhiw@linux.vnet.ibm.com \
    --cc=gautam@linux.ibm.com \
    --cc=jniethe5@gmail.com \
    --cc=kconsul@linux.vnet.ibm.com \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mikey@neuling.org \
    --cc=npiggin@gmail.com \
    --cc=paulus@ozlabs.org \
    --cc=sbhat@linux.ibm.com \
    --cc=vaibhav@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.