All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/i915/dsi: Explicit first_line_bpg_offset assignment for DSI
@ 2023-08-07 14:27 Suraj Kandpal
  2023-08-07 15:48 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
                   ` (14 more replies)
  0 siblings, 15 replies; 24+ messages in thread
From: Suraj Kandpal @ 2023-08-07 14:27 UTC (permalink / raw)
  To: intel-gfx; +Cc: juha-pekka.heikkila, william.tseng

Assign explicit value of 12 at 8bpp as per Table E2 of DSC 1.1 for DSI
panels even though we already use calculations from CModel for
first_line_bpg_offset.
The reason being some DSI monitors may have not have added the
change in errata for the calculation of first_line_bpg_offset.

Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
---
 drivers/gpu/drm/i915/display/icl_dsi.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/icl_dsi.c
index f7ebc146f96d..2376d5000d78 100644
--- a/drivers/gpu/drm/i915/display/icl_dsi.c
+++ b/drivers/gpu/drm/i915/display/icl_dsi.c
@@ -1585,6 +1585,11 @@ static int gen11_dsi_dsc_compute_config(struct intel_encoder *encoder,
 	if (ret)
 		return ret;
 
+	/* From Table E-2 in DSC 1.1*/
+	if (vdsc_cfg->dsc_version_minor == 1 &&
+	    vdsc_cfg->bits_per_pixel == 128)
+		vdsc_cfg->first_line_bpg_offset = 12;
+
 	/* DSI specific sanity checks on the common code */
 	drm_WARN_ON(&dev_priv->drm, vdsc_cfg->vbr_enable);
 	drm_WARN_ON(&dev_priv->drm, vdsc_cfg->simple_422);
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 24+ messages in thread

end of thread, other threads:[~2023-08-16 15:50 UTC | newest]

Thread overview: 24+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-07 14:27 [Intel-gfx] [PATCH] drm/i915/dsi: Explicit first_line_bpg_offset assignment for DSI Suraj Kandpal
2023-08-07 15:48 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2023-08-07 15:48 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-08-07 15:56 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-08-07 21:06 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-08-08  8:06 ` [Intel-gfx] [PATCH] " Tseng, William
2023-08-08  8:40 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dsi: Explicit first_line_bpg_offset assignment for DSI (rev2) Patchwork
2023-08-08  8:40 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-08-08  8:55 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-08-08 15:40 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-08-14 12:52 ` [Intel-gfx] [PATCH] drm/i915/dsi: Explicit first_line_bpg_offset assignment for DSI Suraj Kandpal
2023-08-14 15:06 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dsi: Explicit first_line_bpg_offset assignment for DSI (rev3) Patchwork
2023-08-14 15:06 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-08-14 15:26 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-08-14 18:28 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-08-15 19:33 ` [Intel-gfx] [PATCH] drm/i915/dsi: Explicit first_line_bpg_offset assignment for DSI Jani Nikula
2023-08-16  6:14   ` Kandpal, Suraj
2023-08-16  9:55     ` Jani Nikula
2023-08-16 10:31       ` Jani Nikula
2023-08-16 10:40         ` Kandpal, Suraj
2023-08-16 10:45           ` Kandpal, Suraj
2023-08-16 12:15             ` Jani Nikula
2023-08-16 11:58           ` Jani Nikula
2023-08-16 15:50             ` Kandpal, Suraj

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.