All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: mhi@lists.linux.dev,  ath11k@lists.infradead.org,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH v4 1/3] bus: mhi: host: allow MHI client drivers to provide the firmware via a pointer
Date: Thu, 03 Aug 2023 21:31:51 +0300	[thread overview]
Message-ID: <877cqcyo2w.fsf@kernel.org> (raw)
In-Reply-To: <20230802110110.GD57374@thinkpad> (Manivannan Sadhasivam's message of "Wed, 2 Aug 2023 16:31:10 +0530")

Manivannan Sadhasivam <mani@kernel.org> writes:

> On Thu, Jul 27, 2023 at 01:04:28PM +0300, Kalle Valo wrote:
>> From: Kalle Valo <quic_kvalo@quicinc.com>
>> 
>> Currently MHI loads the firmware image from the path provided by client
>> devices. ath11k needs to support firmware image embedded along with meta data
>> (named as firmware-2.bin). So allow the client driver to request the firmware
>> file from user space on it's own and provide the firmware image data and size
>> to MHI via a pointer struct mhi_controller::fw_data.
>> 
>> This is an optional feature, if fw_data is NULL MHI load the firmware using the
>> name from struct mhi_controller::fw_image string as before.
>> 
>> Tested with ath11k and WCN6855 hw2.0.
>> 
>> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
>
> Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
>
> I can apply this for 6.6 and then you can merge ath11k changes for
> 6.7.

Yeah, to keep things simple please apply patch 1 for v6.6. Then I'll
apply patches 2-3 for v6.7 (after fixing Jeff's findings).

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@kernel.org>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: mhi@lists.linux.dev,  ath11k@lists.infradead.org,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH v4 1/3] bus: mhi: host: allow MHI client drivers to provide the firmware via a pointer
Date: Thu, 03 Aug 2023 21:31:51 +0300	[thread overview]
Message-ID: <877cqcyo2w.fsf@kernel.org> (raw)
In-Reply-To: <20230802110110.GD57374@thinkpad> (Manivannan Sadhasivam's message of "Wed, 2 Aug 2023 16:31:10 +0530")

Manivannan Sadhasivam <mani@kernel.org> writes:

> On Thu, Jul 27, 2023 at 01:04:28PM +0300, Kalle Valo wrote:
>> From: Kalle Valo <quic_kvalo@quicinc.com>
>> 
>> Currently MHI loads the firmware image from the path provided by client
>> devices. ath11k needs to support firmware image embedded along with meta data
>> (named as firmware-2.bin). So allow the client driver to request the firmware
>> file from user space on it's own and provide the firmware image data and size
>> to MHI via a pointer struct mhi_controller::fw_data.
>> 
>> This is an optional feature, if fw_data is NULL MHI load the firmware using the
>> name from struct mhi_controller::fw_image string as before.
>> 
>> Tested with ath11k and WCN6855 hw2.0.
>> 
>> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
>
> Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
>
> I can apply this for 6.6 and then you can merge ath11k changes for
> 6.7.

Yeah, to keep things simple please apply patch 1 for v6.6. Then I'll
apply patches 2-3 for v6.7 (after fixing Jeff's findings).

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2023-08-03 18:31 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-27 10:04 [PATCH v4 0/3] wifi: ath11k: support firmware-2.bin Kalle Valo
2023-07-27 10:04 ` Kalle Valo
2023-07-27 10:04 ` [PATCH v4 1/3] bus: mhi: host: allow MHI client drivers to provide the firmware via a pointer Kalle Valo
2023-07-27 10:04   ` Kalle Valo
2023-08-01  4:20   ` Jeffrey Hugo
2023-08-01  4:20     ` Jeffrey Hugo
2023-08-02 11:01   ` Manivannan Sadhasivam
2023-08-02 11:01     ` Manivannan Sadhasivam
2023-08-03 18:31     ` Kalle Valo [this message]
2023-08-03 18:31       ` Kalle Valo
2023-08-04  6:40   ` Manivannan Sadhasivam
2023-08-04  6:40     ` Manivannan Sadhasivam
2023-07-27 10:04 ` [PATCH v4 2/3] wifi: ath11k: qmi: refactor ath11k_qmi_m3_load() Kalle Valo
2023-07-27 10:04   ` Kalle Valo
2023-07-27 16:47   ` Jeff Johnson
2023-07-27 16:47     ` Jeff Johnson
2023-10-19  9:53     ` Kalle Valo
2023-10-19  9:53       ` Kalle Valo
2023-10-25  9:54   ` Kalle Valo
2023-10-25  9:54     ` Kalle Valo
2023-07-27 10:04 ` [PATCH v4 3/3] wifi: ath11k: add firmware-2.bin support Kalle Valo
2023-07-27 10:04   ` Kalle Valo
2023-07-27 17:12   ` Jeff Johnson
2023-07-27 17:12     ` Jeff Johnson
2023-10-19 13:27     ` Kalle Valo
2023-10-19 13:27       ` Kalle Valo
2023-10-19 15:22       ` Jeff Johnson
2023-10-19 15:22         ` Jeff Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cqcyo2w.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=ath11k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=mhi@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.