From: Cornelia Huck <cohuck@redhat.com>
To: Parav Pandit <parav@nvidia.com>, Halil Pasic <pasic@linux.ibm.com>
Cc: "mst@redhat.com" <mst@redhat.com>,
"virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"sgarzare@redhat.com" <sgarzare@redhat.com>,
"virtio-comment@lists.oasis-open.org"
<virtio-comment@lists.oasis-open.org>,
Shahaf Shuler <shahafs@nvidia.com>
Subject: Re: [virtio-comment] RE: [virtio-dev] [PATCH v13 03/11] content: Rename confusing queue_notify_data and vqn names
Date: Tue, 18 Apr 2023 14:31:40 +0200 [thread overview]
Message-ID: <877cu974nn.fsf@redhat.com> (raw)
In-Reply-To: <PH0PR12MB5481881DEA4B7B7E182510E0DC9D9@PH0PR12MB5481.namprd12.prod.outlook.com>
On Tue, Apr 18 2023, Parav Pandit <parav@nvidia.com> wrote:
>> From: Halil Pasic <pasic@linux.ibm.com>
>> Sent: Tuesday, April 18, 2023 7:40 AM
>>
>> IMHO VIRTIO_F_NOTIFY_CONFIG_DATA should remain aligned with
>> VIRTIO_F_NOTIFICATION_DATA in one way or another. Thus way out would be
>> to do something like:
>> virtio_pci_common_cfg.queue_notify_data -> queue_notif_config_data
>>
>> I think as editors Connie and Michael should have the most say in this though.
>
> Are you ok with above name?
I still need to read through the whole thing.
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com>
To: Parav Pandit <parav@nvidia.com>, Halil Pasic <pasic@linux.ibm.com>
Cc: "mst@redhat.com" <mst@redhat.com>,
"virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"sgarzare@redhat.com" <sgarzare@redhat.com>,
"virtio-comment@lists.oasis-open.org"
<virtio-comment@lists.oasis-open.org>,
Shahaf Shuler <shahafs@nvidia.com>
Subject: [virtio-dev] Re: [virtio-comment] RE: [virtio-dev] [PATCH v13 03/11] content: Rename confusing queue_notify_data and vqn names
Date: Tue, 18 Apr 2023 14:31:40 +0200 [thread overview]
Message-ID: <877cu974nn.fsf@redhat.com> (raw)
In-Reply-To: <PH0PR12MB5481881DEA4B7B7E182510E0DC9D9@PH0PR12MB5481.namprd12.prod.outlook.com>
On Tue, Apr 18 2023, Parav Pandit <parav@nvidia.com> wrote:
>> From: Halil Pasic <pasic@linux.ibm.com>
>> Sent: Tuesday, April 18, 2023 7:40 AM
>>
>> IMHO VIRTIO_F_NOTIFY_CONFIG_DATA should remain aligned with
>> VIRTIO_F_NOTIFICATION_DATA in one way or another. Thus way out would be
>> to do something like:
>> virtio_pci_common_cfg.queue_notify_data -> queue_notif_config_data
>>
>> I think as editors Connie and Michael should have the most say in this though.
>
> Are you ok with above name?
I still need to read through the whole thing.
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2023-04-18 12:31 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 19:23 [virtio-comment] [PATCH v13 00/11] Rename queue number to queue index Parav Pandit
2023-04-11 19:23 ` [virtio-dev] " Parav Pandit
2023-04-11 19:23 ` [virtio-comment] [PATCH v13 01/11] content: Add vq index text Parav Pandit
2023-04-11 19:23 ` [virtio-dev] " Parav Pandit
2023-04-18 14:12 ` [virtio-comment] " Halil Pasic
2023-04-18 14:12 ` [virtio-dev] " Halil Pasic
2023-04-11 19:23 ` [virtio-comment] [PATCH v13 02/11] content.tex Replace virtqueue number with index Parav Pandit
2023-04-11 19:23 ` [virtio-dev] " Parav Pandit
2023-04-11 19:23 ` [virtio-comment] [PATCH v13 03/11] content: Rename confusing queue_notify_data and vqn names Parav Pandit
2023-04-11 19:23 ` [virtio-dev] " Parav Pandit
2023-04-17 3:41 ` [virtio-comment] " Halil Pasic
2023-04-17 3:41 ` Halil Pasic
2023-04-17 20:53 ` [virtio-comment] " Parav Pandit
2023-04-17 20:53 ` Parav Pandit
2023-04-18 6:04 ` [virtio-comment] " Michael S. Tsirkin
2023-04-18 6:04 ` Michael S. Tsirkin
2023-04-18 11:39 ` [virtio-comment] " Halil Pasic
2023-04-18 11:39 ` Halil Pasic
2023-04-18 11:43 ` [virtio-comment] " Michael S. Tsirkin
2023-04-18 11:43 ` Michael S. Tsirkin
2023-04-18 12:13 ` [virtio-comment] " Parav Pandit
2023-04-18 12:13 ` Parav Pandit
2023-04-18 12:06 ` [virtio-comment] " Parav Pandit
2023-04-18 12:06 ` Parav Pandit
2023-04-18 12:31 ` Cornelia Huck [this message]
2023-04-18 12:31 ` [virtio-dev] Re: [virtio-comment] " Cornelia Huck
2023-04-18 13:17 ` [virtio-comment] " Cornelia Huck
2023-04-18 13:17 ` Cornelia Huck
2023-04-11 19:23 ` [virtio-comment] [PATCH v13 04/11] transport-pci: Avoid first vq index reference Parav Pandit
2023-04-11 19:23 ` [virtio-dev] " Parav Pandit
2023-04-11 19:23 ` [virtio-comment] [PATCH v13 05/11] transport-mmio: Rename QueueNum register Parav Pandit
2023-04-11 19:23 ` [virtio-dev] " Parav Pandit
2023-04-11 19:23 ` [virtio-comment] [PATCH v13 06/11] transport-mmio: Avoid referring to zero based index Parav Pandit
2023-04-11 19:23 ` [virtio-dev] " Parav Pandit
2023-04-11 19:23 ` [virtio-comment] [PATCH v13 07/11] transport-ccw: Rename queue depth/size to other transports Parav Pandit
2023-04-11 19:23 ` [virtio-dev] " Parav Pandit
2023-04-11 19:23 ` [virtio-comment] [PATCH v13 08/11] transport-ccw: Refer to the vq by its index Parav Pandit
2023-04-11 19:23 ` [virtio-dev] " Parav Pandit
2023-04-18 16:54 ` [virtio-comment] " Halil Pasic
2023-04-18 16:54 ` [virtio-dev] " Halil Pasic
2023-04-11 19:23 ` [virtio-comment] [PATCH v13 09/11] virtio-net: Avoid duplicate receive queue example Parav Pandit
2023-04-11 19:23 ` [virtio-dev] " Parav Pandit
2023-04-11 19:23 ` [virtio-comment] [PATCH v13 10/11] virtio-net: Describe RSS using rss rq id Parav Pandit
2023-04-11 19:23 ` [virtio-dev] " Parav Pandit
2023-04-11 19:23 ` [virtio-comment] [PATCH v13 11/11] virtio-net: Update vqn to vq_index for cvq cmds Parav Pandit
2023-04-11 19:23 ` [virtio-dev] " Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cu974nn.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=mst@redhat.com \
--cc=parav@nvidia.com \
--cc=pasic@linux.ibm.com \
--cc=sgarzare@redhat.com \
--cc=shahafs@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.