All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, "Catalin Marinas" <catalin.marinas@arm.com>,
	"Andrew Jones" <andrew.jones@linux.dev>,
	"Usama Arif" <usama.arif@bytedance.com>,
	"Bagas Sanjaya" <bagasdotme@gmail.com>,
	"Ben Gardon" <bgardon@google.com>,
	"Maciej S . Szmigiero" <maciej.szmigiero@oracle.com>,
	"Will Deacon" <will@kernel.org>,
	kvmarm@lists.cs.columbia.edu,
	"Marek Szyprowski" <m.szyprowski@samsung.com>,
	"Steven Price" <steven.price@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Anshuman Khandual" <anshuman.khandual@arm.com>,
	"Arnaldo Carvalho de Melo" <acme@kernel.org>,
	"Mark Brown" <broonie@kernel.org>,
	kvmarm@lists.linux.dev, "Peter Collingbourne" <pcc@google.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Cornelia Huck" <cohuck@redhat.com>,
	"Zhiyuan Dai" <daizhiyuan@phytium.com.cn>,
	"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [GIT PULL] KVM/arm64 updates for 6.2
Date: Wed, 07 Dec 2022 07:49:08 +0000	[thread overview]
Message-ID: <877cz3u00b.wl-maz@kernel.org> (raw)
In-Reply-To: <28e7f298-972b-2cb8-df80-951076724c73@redhat.com>

On Tue, 06 Dec 2022 21:43:43 +0000,
Paolo Bonzini <pbonzini@redhat.com> wrote:
> 
> On 12/6/22 19:20, Mark Brown wrote:
> >> I almost suggested doing that on multiple occasions this cycle, but ultimately
> >> decided not to because it would effectively mean splitting series that touch KVM
> >> and selftests into different trees, which would create a different kind of
> >> dependency hell.  Or maybe a hybrid approach where series that only (or mostly?)
> >> touch selftests go into a dedicated tree?
> > 
> > Some other subsystems do have a separate branch for kselftests.  One
> > fairly common occurrence is that the selftests branch ends up failing to
> > build independently because someone adds new ABI together with a
> > selftest but the patches adding the ABI don't end up on the same branch
> > as the tests which try to use them.  That is of course resolvable but
> > it's a common friction point.
> 
> Yeah, the right solution is simply to merge selftests changes
> separately from the rest and use topic branches.

Don't know if this is what you have in mind, but I think that we
should use topic branches for *everything*. The only things for which
I don't use a separate branch are the odd drive-by patches, of the
spelling fix persuasion.

That's what we do for arm64 and the IRQ subsystem. It is a bit more
involved at queuing time, but makes dropping series from -next
extremely easy, without affecting the history. And crucially, it gives
everyone a hint to base their stuff on a stable commit, not a random
"tip of kvm/queue as of three days ago".

	M.

-- 
Without deviation from the norm, progress is not possible.
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Mark Brown" <broonie@kernel.org>,
	"Sean Christopherson" <seanjc@google.com>,
	"Andrew Jones" <andrew.jones@linux.dev>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Anshuman Khandual" <anshuman.khandual@arm.com>,
	"Arnaldo Carvalho de Melo" <acme@kernel.org>,
	"Bagas Sanjaya" <bagasdotme@gmail.com>,
	"Ben Gardon" <bgardon@google.com>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"Cornelia Huck" <cohuck@redhat.com>,
	"Fuad Tabba" <tabba@google.com>, "Gavin Shan" <gshan@redhat.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"James Morse" <james.morse@arm.com>,
	"Maciej S . Szmigiero" <maciej.szmigiero@oracle.com>,
	"Marek Szyprowski" <m.szyprowski@samsung.com>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Oliver Upton" <oliver.upton@linux.dev>,
	"Peter Collingbourne" <pcc@google.com>,
	"Peter Xu" <peterx@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Quentin Perret" <qperret@google.com>,
	"Reiji Watanabe" <reijiw@google.com>,
	"Ricardo Koller" <ricarkol@google.com>,
	"Ryan Roberts" <ryan.roberts@arm.com>,
	"Steven Price" <steven.price@arm.com>,
	"Usama Arif" <usama.arif@bytedance.com>,
	"Vincent Donnefort" <vdonnefort@google.com>,
	"Will Deacon" <will@kernel.org>,
	"Zhiyuan Dai" <daizhiyuan@phytium.com.cn>,
	"Suzuki K Poulose" <suzuki.poulose@arm.com>,
	"Alexandru Elisei" <alexandru.elisei@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	kvmarm@lists.cs.columbia.edu, kvmarm@lists.linux.dev,
	kvm@vger.kernel.org
Subject: Re: [GIT PULL] KVM/arm64 updates for 6.2
Date: Wed, 07 Dec 2022 07:49:08 +0000	[thread overview]
Message-ID: <877cz3u00b.wl-maz@kernel.org> (raw)
Message-ID: <20221207074908.W8i1SyxQJeasex45KiMC-arow5zcnxiu2tyQgNTaaG4@z> (raw)
In-Reply-To: <28e7f298-972b-2cb8-df80-951076724c73@redhat.com>

On Tue, 06 Dec 2022 21:43:43 +0000,
Paolo Bonzini <pbonzini@redhat.com> wrote:
> 
> On 12/6/22 19:20, Mark Brown wrote:
> >> I almost suggested doing that on multiple occasions this cycle, but ultimately
> >> decided not to because it would effectively mean splitting series that touch KVM
> >> and selftests into different trees, which would create a different kind of
> >> dependency hell.  Or maybe a hybrid approach where series that only (or mostly?)
> >> touch selftests go into a dedicated tree?
> > 
> > Some other subsystems do have a separate branch for kselftests.  One
> > fairly common occurrence is that the selftests branch ends up failing to
> > build independently because someone adds new ABI together with a
> > selftest but the patches adding the ABI don't end up on the same branch
> > as the tests which try to use them.  That is of course resolvable but
> > it's a common friction point.
> 
> Yeah, the right solution is simply to merge selftests changes
> separately from the rest and use topic branches.

Don't know if this is what you have in mind, but I think that we
should use topic branches for *everything*. The only things for which
I don't use a separate branch are the odd drive-by patches, of the
spelling fix persuasion.

That's what we do for arm64 and the IRQ subsystem. It is a bit more
involved at queuing time, but makes dropping series from -next
extremely easy, without affecting the history. And crucially, it gives
everyone a hint to base their stuff on a stable commit, not a random
"tip of kvm/queue as of three days ago".

	M.

-- 
Without deviation from the norm, progress is not possible.

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Mark Brown" <broonie@kernel.org>,
	"Sean Christopherson" <seanjc@google.com>,
	"Andrew Jones" <andrew.jones@linux.dev>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Anshuman Khandual" <anshuman.khandual@arm.com>,
	"Arnaldo Carvalho de Melo" <acme@kernel.org>,
	"Bagas Sanjaya" <bagasdotme@gmail.com>,
	"Ben Gardon" <bgardon@google.com>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"Cornelia Huck" <cohuck@redhat.com>,
	"Fuad Tabba" <tabba@google.com>, "Gavin Shan" <gshan@redhat.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"James Morse" <james.morse@arm.com>,
	"Maciej S . Szmigiero" <maciej.szmigiero@oracle.com>,
	"Marek Szyprowski" <m.szyprowski@samsung.com>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Oliver Upton" <oliver.upton@linux.dev>,
	"Peter Collingbourne" <pcc@google.com>,
	"Peter Xu" <peterx@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Quentin Perret" <qperret@google.com>,
	"Reiji Watanabe" <reijiw@google.com>,
	"Ricardo Koller" <ricarkol@google.com>,
	"Ryan Roberts" <ryan.roberts@arm.com>,
	"Steven Price" <steven.price@arm.com>,
	"Usama Arif" <usama.arif@bytedance.com>,
	"Vincent Donnefort" <vdonnefort@google.com>,
	"Will Deacon" <will@kernel.org>,
	"Zhiyuan Dai" <daizhiyuan@phytium.com.cn>,
	"Suzuki K Poulose" <suzuki.poulose@arm.com>,
	"Alexandru Elisei" <alexandru.elisei@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	kvmarm@lists.cs.columbia.edu, kvmarm@lists.linux.dev,
	kvm@vger.kernel.org
Subject: Re: [GIT PULL] KVM/arm64 updates for 6.2
Date: Wed, 07 Dec 2022 07:49:08 +0000	[thread overview]
Message-ID: <877cz3u00b.wl-maz@kernel.org> (raw)
In-Reply-To: <28e7f298-972b-2cb8-df80-951076724c73@redhat.com>

On Tue, 06 Dec 2022 21:43:43 +0000,
Paolo Bonzini <pbonzini@redhat.com> wrote:
> 
> On 12/6/22 19:20, Mark Brown wrote:
> >> I almost suggested doing that on multiple occasions this cycle, but ultimately
> >> decided not to because it would effectively mean splitting series that touch KVM
> >> and selftests into different trees, which would create a different kind of
> >> dependency hell.  Or maybe a hybrid approach where series that only (or mostly?)
> >> touch selftests go into a dedicated tree?
> > 
> > Some other subsystems do have a separate branch for kselftests.  One
> > fairly common occurrence is that the selftests branch ends up failing to
> > build independently because someone adds new ABI together with a
> > selftest but the patches adding the ABI don't end up on the same branch
> > as the tests which try to use them.  That is of course resolvable but
> > it's a common friction point.
> 
> Yeah, the right solution is simply to merge selftests changes
> separately from the rest and use topic branches.

Don't know if this is what you have in mind, but I think that we
should use topic branches for *everything*. The only things for which
I don't use a separate branch are the odd drive-by patches, of the
spelling fix persuasion.

That's what we do for arm64 and the IRQ subsystem. It is a bit more
involved at queuing time, but makes dropping series from -next
extremely easy, without affecting the history. And crucially, it gives
everyone a hint to base their stuff on a stable commit, not a random
"tip of kvm/queue as of three days ago".

	M.

-- 
Without deviation from the norm, progress is not possible.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-12-07  7:51 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-05 15:58 [GIT PULL] KVM/arm64 updates for 6.2 Marc Zyngier
2022-12-05 15:58 ` Marc Zyngier
2022-12-05 15:58 ` Marc Zyngier
2022-12-06 17:41 ` Paolo Bonzini
2022-12-06 17:41   ` Paolo Bonzini
2022-12-06 17:41   ` Paolo Bonzini
2022-12-06 18:10   ` Sean Christopherson
2022-12-06 18:10     ` Sean Christopherson
2022-12-06 18:10     ` Sean Christopherson
2022-12-06 18:20     ` Mark Brown
2022-12-06 18:20       ` Mark Brown
2022-12-06 18:20       ` Mark Brown
2022-12-06 21:43       ` Paolo Bonzini
2022-12-06 21:43         ` Paolo Bonzini
2022-12-06 21:43         ` Paolo Bonzini
2022-12-07  7:49         ` Marc Zyngier [this message]
2022-12-07  7:49           ` Marc Zyngier
2022-12-07  7:49           ` Marc Zyngier
2022-12-09  8:08           ` Paolo Bonzini
2022-12-09  8:08             ` Paolo Bonzini
2022-12-09  8:08             ` Paolo Bonzini
2022-12-06 19:27   ` Marc Zyngier
2022-12-06 19:27     ` Marc Zyngier
2022-12-06 19:27     ` Marc Zyngier
2022-12-07 21:51   ` Oliver Upton
2022-12-07 21:51     ` Oliver Upton
2022-12-07 21:51     ` Oliver Upton
2022-12-09 16:56     ` Paolo Bonzini
2022-12-09 16:56       ` Paolo Bonzini
2022-12-09 16:56       ` Paolo Bonzini
2022-12-09 17:05       ` Oliver Upton
2022-12-09 17:05         ` Oliver Upton
2022-12-09 17:05         ` Oliver Upton
2022-12-09 17:07         ` Paolo Bonzini
2022-12-09 17:07           ` Paolo Bonzini
2022-12-09 17:07           ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cz3u00b.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=acme@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=andrew.jones@linux.dev \
    --cc=anshuman.khandual@arm.com \
    --cc=bagasdotme@gmail.com \
    --cc=bgardon@google.com \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=cohuck@redhat.com \
    --cc=daizhiyuan@phytium.com.cn \
    --cc=kuba@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=m.szyprowski@samsung.com \
    --cc=maciej.szmigiero@oracle.com \
    --cc=pbonzini@redhat.com \
    --cc=pcc@google.com \
    --cc=philmd@linaro.org \
    --cc=steven.price@arm.com \
    --cc=usama.arif@bytedance.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.