From: Takashi Iwai <tiwai@suse.de>
To: Jaroslav Kysela <perex@perex.cz>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: usb-audio: Fix regression with Dell Dock jack detection
Date: Wed, 02 Nov 2022 12:59:49 +0100 [thread overview]
Message-ID: <877d0dtvm2.wl-tiwai@suse.de> (raw)
In-Reply-To: <9b0c4f2d-1856-a80d-ad9d-9b34436fdc1c@perex.cz>
On Wed, 02 Nov 2022 12:53:48 +0100,
Jaroslav Kysela wrote:
>
> On 02. 11. 22 12:34, Takashi Iwai wrote:
> > The recent commit added Jack controls to Dell Dock, but it added with
> > iface = SNDRV_CTL_ELEM_IFACE_CARD. Unfortunately this doesn't match
> > with the changes in user-space UCM profile, which expects iface =
> > SNDRV_CTL_ELEM_IFACE_MIXER as default. This mismatch resulted in the
> > non-working profile, and the Dell Dock is gone on pipewire /
> > PulseAudio after the kernel update.
> >
> > Fix the regression by adjusting the iface of the new ctl elements to
> > *_MIXER.
>
> Hi Takashi,
>
> UCM expects SNDRV_CTL_ELEM_IFACE_CARD for jacks by default. Which
> change do you refer? I would drop this patch.
It's about ucm2/USB-Audio/Dell/WD15-Dock-HiFi.conf, the JackControl
entries. For example,
JackControl "Headphone Jack"
expects the mixer element. The bad thing is that the complete card
entry disappears because of inconsistency.
If you modify the entry as
JackControl "name='Headphone Jack',iface=CARD"
it would work. But the fact that other JackControl stuff works, it's
better to align the USB-audio with IFACE_MIXER, I guess.
Takashi
next prev parent reply other threads:[~2022-11-02 12:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 11:34 [PATCH] ALSA: usb-audio: Fix regression with Dell Dock jack detection Takashi Iwai
2022-11-02 11:53 ` Jaroslav Kysela
2022-11-02 11:59 ` Takashi Iwai [this message]
2022-11-02 12:05 ` Takashi Iwai
2022-11-02 12:18 ` Jaroslav Kysela
2022-11-02 12:45 ` Takashi Iwai
2022-11-02 14:05 ` Jaroslav Kysela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877d0dtvm2.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.