From: Andreas Schwab <schwab@linux-m68k.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
LKML <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [git pull] drm for 5.19-rc1
Date: Tue, 07 Jun 2022 18:50:27 +0200 [thread overview]
Message-ID: <877d5s2zak.fsf@igel.home> (raw)
In-Reply-To: <CAMuHMdXb5-gOVRsQx6tDqjQMD9cC-p=o56VuF2cBPWyMFRgHMA@mail.gmail.com> (Geert Uytterhoeven's message of "Tue, 7 Jun 2022 12:22:41 +0200")
On Jun 07 2022, Geert Uytterhoeven wrote:
> On Wed, May 25, 2022 at 4:49 PM Dave Airlie <airlied@gmail.com> wrote:
>> drm/amdgpu: add nbio v7_7_0 ip headers
>
> These header files are heavy users of large constants lacking the "U"
> suffix e.g.:
>
> #define NB_ADAPTER_ID__SUBSYSTEM_ID_MASK 0xFFFF0000L
>
> Assigning this to unsigned long on 32-bit will trigger a signed integer
> overflow, which is technically UB, and causes "error: initializer
> element is not constant" warnings with gcc-5 and -std-gnu11, cfr. [1]
That shouldn't happen here, as hexadecimal constants will be of unsigned
type if they don't fit in the corresponding signed type.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
WARNING: multiple messages have this Message-ID (diff)
From: Andreas Schwab <schwab@linux-m68k.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Dave Airlie <airlied@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
dri-devel <dri-devel@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [git pull] drm for 5.19-rc1
Date: Tue, 07 Jun 2022 18:50:27 +0200 [thread overview]
Message-ID: <877d5s2zak.fsf@igel.home> (raw)
In-Reply-To: <CAMuHMdXb5-gOVRsQx6tDqjQMD9cC-p=o56VuF2cBPWyMFRgHMA@mail.gmail.com> (Geert Uytterhoeven's message of "Tue, 7 Jun 2022 12:22:41 +0200")
On Jun 07 2022, Geert Uytterhoeven wrote:
> On Wed, May 25, 2022 at 4:49 PM Dave Airlie <airlied@gmail.com> wrote:
>> drm/amdgpu: add nbio v7_7_0 ip headers
>
> These header files are heavy users of large constants lacking the "U"
> suffix e.g.:
>
> #define NB_ADAPTER_ID__SUBSYSTEM_ID_MASK 0xFFFF0000L
>
> Assigning this to unsigned long on 32-bit will trigger a signed integer
> overflow, which is technically UB, and causes "error: initializer
> element is not constant" warnings with gcc-5 and -std-gnu11, cfr. [1]
That shouldn't happen here, as hexadecimal constants will be of unsigned
type if they don't fit in the corresponding signed type.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2022-06-07 16:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 6:06 [git pull] drm for 5.19-rc1 Dave Airlie
2022-05-25 6:06 ` Dave Airlie
2022-05-25 23:23 ` Linus Torvalds
2022-05-25 23:23 ` Linus Torvalds
2022-05-26 0:09 ` pr-tracker-bot
2022-05-26 0:09 ` pr-tracker-bot
2022-06-07 10:22 ` Geert Uytterhoeven
2022-06-07 10:22 ` Geert Uytterhoeven
2022-06-07 16:50 ` Andreas Schwab [this message]
2022-06-07 16:50 ` Andreas Schwab
2022-06-07 18:15 ` Linus Torvalds
2022-06-07 18:15 ` Linus Torvalds
2022-06-07 19:12 ` Geert Uytterhoeven
2022-06-07 19:12 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877d5s2zak.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=arnd@arndb.de \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.