From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Murthy, Arun R" <arun.r.murthy@intel.com>,
"Modem, Bhanuprakash" <bhanuprakash.modem@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
"ville.syrjala@linux.intel.com" <ville.syrjala@linux.intel.com>,
"harry.wentland@amd.com" <harry.wentland@amd.com>,
"Sharma, Swati2" <swati2.sharma@intel.com>
Subject: RE: [Intel-gfx] [V2 1/3] drm/debug: Expose connector's max supported bpc via debugfs
Date: Mon, 02 May 2022 14:49:44 +0300 [thread overview]
Message-ID: <877d74rw6f.fsf@intel.com> (raw)
In-Reply-To: <DM6PR11MB31778E7D4B07EC0B429EA593BAFC9@DM6PR11MB3177.namprd11.prod.outlook.com>
On Fri, 29 Apr 2022, "Murthy, Arun R" <arun.r.murthy@intel.com> wrote:
>> +static int output_bpc_show(struct seq_file *m, void *data) {
>
> Can we have a meaningful name instead of 'm' ?
> Upon changing this parameter name, you can have my
> Reviewed-By: Arun R Murthy <arun.r.murthy@intel.com>
Please keep 'm'. It's by far the most common name for struct seq_file *
in the kernel:
$ git grep -o "struct seq_file \*[a-zA-Z0-9_]\+" | sed 's/^.*:struct seq_file \*//' | sort | uniq -c | sort -rn | head -5
2212 m
1219 seq
1126 s
135 sf
121 file
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Murthy, Arun R" <arun.r.murthy@intel.com>,
"Modem, Bhanuprakash" <bhanuprakash.modem@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
"ville.syrjala@linux.intel.com" <ville.syrjala@linux.intel.com>,
"harry.wentland@amd.com" <harry.wentland@amd.com>,
"Sharma, Swati2" <swati2.sharma@intel.com>
Subject: Re: [Intel-gfx] [V2 1/3] drm/debug: Expose connector's max supported bpc via debugfs
Date: Mon, 02 May 2022 14:49:44 +0300 [thread overview]
Message-ID: <877d74rw6f.fsf@intel.com> (raw)
In-Reply-To: <DM6PR11MB31778E7D4B07EC0B429EA593BAFC9@DM6PR11MB3177.namprd11.prod.outlook.com>
On Fri, 29 Apr 2022, "Murthy, Arun R" <arun.r.murthy@intel.com> wrote:
>> +static int output_bpc_show(struct seq_file *m, void *data) {
>
> Can we have a meaningful name instead of 'm' ?
> Upon changing this parameter name, you can have my
> Reviewed-By: Arun R Murthy <arun.r.murthy@intel.com>
Please keep 'm'. It's by far the most common name for struct seq_file *
in the kernel:
$ git grep -o "struct seq_file \*[a-zA-Z0-9_]\+" | sed 's/^.*:struct seq_file \*//' | sort | uniq -c | sort -rn | head -5
2212 m
1219 seq
1126 s
135 sf
121 file
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2022-05-02 11:49 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 9:51 [V2 0/3] Expose max and current bpc via debugfs Bhanuprakash Modem
2022-04-11 9:51 ` [Intel-gfx] " Bhanuprakash Modem
2022-04-11 9:51 ` [V2 1/3] drm/debug: Expose connector's max supported " Bhanuprakash Modem
2022-04-11 9:51 ` [Intel-gfx] " Bhanuprakash Modem
2022-04-12 3:07 ` Murthy, Arun R
2022-04-12 3:07 ` Murthy, Arun R
2022-04-12 4:03 ` Modem, Bhanuprakash
2022-04-29 14:27 ` Murthy, Arun R
2022-04-29 14:27 ` Murthy, Arun R
2022-05-02 11:49 ` Jani Nikula [this message]
2022-05-02 11:49 ` Jani Nikula
2022-05-02 18:51 ` Harry Wentland
2022-05-02 18:51 ` [Intel-gfx] " Harry Wentland
2022-04-11 9:51 ` [V2 2/3] drm/i915/display/debug: Expose crtc current " Bhanuprakash Modem
2022-04-11 9:51 ` [Intel-gfx] " Bhanuprakash Modem
2022-04-12 3:10 ` Murthy, Arun R
2022-04-12 3:10 ` Murthy, Arun R
2022-05-16 8:39 ` Jani Nikula
2022-05-16 8:39 ` Jani Nikula
2022-04-11 9:51 ` [V2 3/3] drm/amd/display: Move connector debugfs to drm Bhanuprakash Modem
2022-04-11 9:51 ` [Intel-gfx] " Bhanuprakash Modem
2022-04-29 14:32 ` Murthy, Arun R
2022-04-29 14:32 ` Murthy, Arun R
2022-05-02 13:28 ` Modem, Bhanuprakash
2022-05-02 13:38 ` Harry Wentland
2022-05-02 14:27 ` Modem, Bhanuprakash
2022-05-02 14:29 ` Harry Wentland
2022-05-02 18:54 ` Harry Wentland
2022-05-16 8:39 ` Jani Nikula
2022-05-18 5:38 ` Modem, Bhanuprakash
2022-05-18 14:08 ` Harry Wentland
2022-05-02 18:51 ` Harry Wentland
2022-05-02 18:51 ` [Intel-gfx] " Harry Wentland
2022-04-11 12:40 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for Expose max and current bpc via debugfs Patchwork
2022-04-13 20:39 ` [Intel-gfx] ✓ Fi.CI.BAT: success for Expose max and current bpc via debugfs (rev2) Patchwork
2022-04-13 22:22 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-05-06 10:54 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Expose max and current bpc via debugfs (rev3) Patchwork
2022-05-06 11:03 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-05-06 14:03 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-05-06 15:55 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Expose max and current bpc via debugfs (rev4) Patchwork
2022-05-06 16:05 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-05-06 18:35 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-05-08 16:57 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Expose max and current bpc via debugfs (rev5) Patchwork
2022-05-08 17:21 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-05-08 19:53 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-05-09 6:36 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Expose max and current bpc via debugfs (rev6) Patchwork
2022-05-09 6:58 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-05-09 17:37 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Expose max and current bpc via debugfs (rev7) Patchwork
2022-05-09 18:03 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-05-10 2:16 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-05-10 11:18 ` [V2 0/3] Expose max and current bpc via debugfs Modem, Bhanuprakash
2022-05-10 11:18 ` [Intel-gfx] " Modem, Bhanuprakash
2022-05-17 8:33 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Expose max and current bpc via debugfs (rev8) Patchwork
2022-05-19 13:51 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Expose max and current bpc via debugfs (rev9) Patchwork
-- strict thread matches above, loose matches on Subject: below --
2022-04-08 6:53 [PATCH 1/3] drm/debug: Expose connector's max supported bpc via debugfs Bhanuprakash Modem
2022-04-11 3:57 ` [Intel-gfx] [V2 " Bhanuprakash Modem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877d74rw6f.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=arun.r.murthy@intel.com \
--cc=bhanuprakash.modem@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=swati2.sharma@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.