From: Kalle Valo <kvalo@kernel.org>
To: Bernard Zhao <zhaojunkui2008@126.com>
Cc: Jakub Kicinski <kubakici@wp.pl>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
bernard@vivo.com
Subject: Re: [PATCH] net/wireless: add debugfs exit function
Date: Fri, 22 Apr 2022 08:57:25 +0300 [thread overview]
Message-ID: <877d7hoe2i.fsf@kernel.org> (raw)
In-Reply-To: <20220422012830.342993-1-zhaojunkui2008@126.com> (Bernard Zhao's message of "Thu, 21 Apr 2022 18:28:30 -0700")
Bernard Zhao <zhaojunkui2008@126.com> writes:
> This patch add exit debugfs function to mt7601u.
> Debugfs need to be cleanup when module is unloaded or load fail.
"load fail"? Please be more specific, are you saying that the second
module load fails or what?
> drivers/net/wireless/mediatek/mt7601u/debugfs.c | 9 +++++++--
> drivers/net/wireless/mediatek/mt7601u/init.c | 1 +
> drivers/net/wireless/mediatek/mt7601u/mt7601u.h | 1 +
The title should be:
mt7601u: add debugfs exit function
> --- a/drivers/net/wireless/mediatek/mt7601u/debugfs.c
> +++ b/drivers/net/wireless/mediatek/mt7601u/debugfs.c
> @@ -9,6 +9,8 @@
> #include "mt7601u.h"
> #include "eeprom.h"
>
> +static struct dentry *dir;
How will this work when there are multiple mt7601u devices? Because of
that, avoid using non-const static variables.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@kernel.org>
To: Bernard Zhao <zhaojunkui2008@126.com>
Cc: Jakub Kicinski <kubakici@wp.pl>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
bernard@vivo.com
Subject: Re: [PATCH] net/wireless: add debugfs exit function
Date: Fri, 22 Apr 2022 08:57:25 +0300 [thread overview]
Message-ID: <877d7hoe2i.fsf@kernel.org> (raw)
In-Reply-To: <20220422012830.342993-1-zhaojunkui2008@126.com> (Bernard Zhao's message of "Thu, 21 Apr 2022 18:28:30 -0700")
Bernard Zhao <zhaojunkui2008@126.com> writes:
> This patch add exit debugfs function to mt7601u.
> Debugfs need to be cleanup when module is unloaded or load fail.
"load fail"? Please be more specific, are you saying that the second
module load fails or what?
> drivers/net/wireless/mediatek/mt7601u/debugfs.c | 9 +++++++--
> drivers/net/wireless/mediatek/mt7601u/init.c | 1 +
> drivers/net/wireless/mediatek/mt7601u/mt7601u.h | 1 +
The title should be:
mt7601u: add debugfs exit function
> --- a/drivers/net/wireless/mediatek/mt7601u/debugfs.c
> +++ b/drivers/net/wireless/mediatek/mt7601u/debugfs.c
> @@ -9,6 +9,8 @@
> #include "mt7601u.h"
> #include "eeprom.h"
>
> +static struct dentry *dir;
How will this work when there are multiple mt7601u devices? Because of
that, avoid using non-const static variables.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@kernel.org>
To: Bernard Zhao <zhaojunkui2008@126.com>
Cc: Jakub Kicinski <kubakici@wp.pl>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
bernard@vivo.com
Subject: Re: [PATCH] net/wireless: add debugfs exit function
Date: Fri, 22 Apr 2022 08:57:25 +0300 [thread overview]
Message-ID: <877d7hoe2i.fsf@kernel.org> (raw)
In-Reply-To: <20220422012830.342993-1-zhaojunkui2008@126.com> (Bernard Zhao's message of "Thu, 21 Apr 2022 18:28:30 -0700")
Bernard Zhao <zhaojunkui2008@126.com> writes:
> This patch add exit debugfs function to mt7601u.
> Debugfs need to be cleanup when module is unloaded or load fail.
"load fail"? Please be more specific, are you saying that the second
module load fails or what?
> drivers/net/wireless/mediatek/mt7601u/debugfs.c | 9 +++++++--
> drivers/net/wireless/mediatek/mt7601u/init.c | 1 +
> drivers/net/wireless/mediatek/mt7601u/mt7601u.h | 1 +
The title should be:
mt7601u: add debugfs exit function
> --- a/drivers/net/wireless/mediatek/mt7601u/debugfs.c
> +++ b/drivers/net/wireless/mediatek/mt7601u/debugfs.c
> @@ -9,6 +9,8 @@
> #include "mt7601u.h"
> #include "eeprom.h"
>
> +static struct dentry *dir;
How will this work when there are multiple mt7601u devices? Because of
that, avoid using non-const static variables.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-22 5:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 1:28 [PATCH] net/wireless: add debugfs exit function Bernard Zhao
2022-04-22 1:28 ` Bernard Zhao
2022-04-22 1:28 ` Bernard Zhao
2022-04-22 5:57 ` Kalle Valo [this message]
2022-04-22 5:57 ` Kalle Valo
2022-04-22 5:57 ` Kalle Valo
2022-04-22 6:37 ` z
2022-04-22 6:37 ` z
2022-04-22 6:37 ` z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877d7hoe2i.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=bernard@vivo.com \
--cc=davem@davemloft.net \
--cc=kubakici@wp.pl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=zhaojunkui2008@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.