All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: marcandre.lureau@redhat.com
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 26/27] tests: replace free_all() usage with g_auto
Date: Wed, 16 Mar 2022 13:32:59 +0100	[thread overview]
Message-ID: <877d8u5b7o.fsf@pond.sub.org> (raw)
In-Reply-To: <20220316095459.2613885-1-marcandre.lureau@redhat.com> (marcandre lureau's message of "Wed, 16 Mar 2022 13:54:59 +0400")

marcandre.lureau@redhat.com writes:

> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Use more idiomatic glib/auto-style code.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

This is a bit of an improvement, but by its own, it's a rather weak
justification for the previous patch.  Do you have more uses of
g_autoptr in the pipe?



  reply	other threads:[~2022-03-16 12:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-16  9:54 [PATCH 26/27] tests: replace free_all() usage with g_auto marcandre.lureau
2022-03-16 12:32 ` Markus Armbruster [this message]
2022-03-16 12:53   ` Marc-André Lureau
2022-03-16 13:00     ` Markus Armbruster
2022-03-16 13:11       ` Marc-André Lureau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877d8u5b7o.fsf@pond.sub.org \
    --to=armbru@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.