From: Markus Armbruster <armbru@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH 26/27] tests: replace free_all() usage with g_auto
Date: Wed, 16 Mar 2022 14:00:24 +0100 [thread overview]
Message-ID: <87bky6xdav.fsf@pond.sub.org> (raw)
In-Reply-To: <CAMxuvazfG9y4wODW3rHL_Xj9+H1SwDy8aESZKW89hwU=k7LLjg@mail.gmail.com> ("Marc-André Lureau"'s message of "Wed, 16 Mar 2022 16:53:05 +0400")
Marc-André Lureau <marcandre.lureau@redhat.com> writes:
> Hi
>
> On Wed, Mar 16, 2022 at 4:33 PM Markus Armbruster <armbru@redhat.com> wrote:
>>
>> marcandre.lureau@redhat.com writes:
>>
>> > From: Marc-André Lureau <marcandre.lureau@redhat.com>
>> >
>> > Use more idiomatic glib/auto-style code.
>> >
>> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>>
>> This is a bit of an improvement, but by its own, it's a rather weak
>> justification for the previous patch. Do you have more uses of
>> g_autoptr in the pipe?
>
>
> There are a lot of similar g_auto cleanups to be done in qemu code
> base for QObject types. But I started with those tests, because they
> use a pretty unorthodox free_all pattern and that shouldn't be
> repeated.
Would it make sense to add this the list of bite-sized tasks?
next prev parent reply other threads:[~2022-03-16 13:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-16 9:54 [PATCH 26/27] tests: replace free_all() usage with g_auto marcandre.lureau
2022-03-16 12:32 ` Markus Armbruster
2022-03-16 12:53 ` Marc-André Lureau
2022-03-16 13:00 ` Markus Armbruster [this message]
2022-03-16 13:11 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bky6xdav.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.