Re: [RFC V1 02/11] arm64/perf: Add register definitions for BRBE

From: Marc Zyngier <maz@kernel.org>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	linux-perf-users@vger.kernel.org
Subject: Re: [RFC V1 02/11] arm64/perf: Add register definitions for BRBE
Date: Mon, 24 Jan 2022 14:05:27 +0000	[thread overview]
Message-ID: <877dap8c0o.wl-maz@kernel.org> (raw)
In-Reply-To: <1642998653-21377-3-git-send-email-anshuman.khandual@arm.com>

On Mon, 24 Jan 2022 04:30:44 +0000,
Anshuman Khandual <anshuman.khandual@arm.com> wrote:
> 
> This adds BRBE related register definitions and various other related field
> macros there in. These will be used subsequently in a BRBE driver which is
> being added later on.
> 
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Marc Zyngier <maz@kernel.org>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> ---
>  arch/arm64/include/asm/sysreg.h | 216 ++++++++++++++++++++++++++++++++
>  1 file changed, 216 insertions(+)
> 
> diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/sysreg.h
> index 898bee0004ae..d8fd7e806a47 100644
> --- a/arch/arm64/include/asm/sysreg.h
> +++ b/arch/arm64/include/asm/sysreg.h
> @@ -141,6 +141,218 @@
>  #define SYS_DBGDTRTX_EL0		sys_reg(2, 3, 0, 5, 0)
>  #define SYS_DBGVCR32_EL2		sys_reg(2, 4, 0, 7, 0)
>  
> +/*
> + * BRBINF<N>_EL1 Encoding: [2, 1, 8, CRm, op2]
> + *
> + * derived as <CRm> = c{N<3:0>} <op2> = (N<4>x4 + 0)
> + */
> +#define SYS_BRBINF0_EL1			sys_reg(2, 1, 8, 0, 0)
> +#define SYS_BRBINF1_EL1			sys_reg(2, 1, 8, 1, 0)
> +#define SYS_BRBINF2_EL1			sys_reg(2, 1, 8, 2, 0)
> +#define SYS_BRBINF3_EL1			sys_reg(2, 1, 8, 3, 0)
> +#define SYS_BRBINF4_EL1			sys_reg(2, 1, 8, 4, 0)
> +#define SYS_BRBINF5_EL1			sys_reg(2, 1, 8, 5, 0)
> +#define SYS_BRBINF6_EL1			sys_reg(2, 1, 8, 6, 0)
> +#define SYS_BRBINF7_EL1			sys_reg(2, 1, 8, 7, 0)
> +#define SYS_BRBINF8_EL1			sys_reg(2, 1, 8, 8, 0)
> +#define SYS_BRBINF9_EL1			sys_reg(2, 1, 8, 9, 0)

[snip]

Since the architecture gives you the formula to build these, why do
you enumerate each and every register encoding? I'd rather see
something like:

#define __SYS_BRBINFO(n) sys_reg(2, 1, 8, ((n) & 0xf), (((n) & 0x10)) >> 2)
#define SYS_BRBINF0_EL1	__SYS_BRBINFO(0)
[...]

and something similar for all the new registers that come in packs of
32... We already have similar things for AMU, PMU, GIC and co.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.