All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Dmitry Voronetskiy <davoronetskiy@gmail.com>
Cc: qemu-devel@nongnu.org,  qemu-trivial@nongnu.org,
	 Dmitry Voronetskiy <vda1999@yandex.ru>
Subject: Re: [PATCH] Signed-off-by: Dmitry Voronetskiy <vda1999@yandex.ru>
Date: Tue, 18 May 2021 09:23:14 +0200	[thread overview]
Message-ID: <877djwtsil.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20210517084055.24792-1-davoronetskiy@gmail.com> (Dmitry Voronetskiy's message of "Mon, 17 May 2021 11:40:55 +0300")

Dmitry Voronetskiy <davoronetskiy@gmail.com> writes:

> From: Dmitry Voronetskiy <vda1999@yandex.ru>
>
> the value passed to strerror should be positive

Your commit message is out of order :)

With that fixed:
Reviewed-by: Markus Armbruster <armbru@redhat.com>

How did you track these down?



WARNING: multiple messages have this Message-ID (diff)
From: Markus Armbruster <armbru@redhat.com>
To: Dmitry Voronetskiy <davoronetskiy@gmail.com>
Cc: qemu-trivial@nongnu.org, Dmitry Voronetskiy <vda1999@yandex.ru>,
	qemu-devel@nongnu.org
Subject: Re: [PATCH] Signed-off-by: Dmitry Voronetskiy <vda1999@yandex.ru>
Date: Tue, 18 May 2021 09:23:14 +0200	[thread overview]
Message-ID: <877djwtsil.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20210517084055.24792-1-davoronetskiy@gmail.com> (Dmitry Voronetskiy's message of "Mon, 17 May 2021 11:40:55 +0300")

Dmitry Voronetskiy <davoronetskiy@gmail.com> writes:

> From: Dmitry Voronetskiy <vda1999@yandex.ru>
>
> the value passed to strerror should be positive

Your commit message is out of order :)

With that fixed:
Reviewed-by: Markus Armbruster <armbru@redhat.com>

How did you track these down?



  reply	other threads:[~2021-05-18  7:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-17  8:40 [PATCH] Signed-off-by: Dmitry Voronetskiy <vda1999@yandex.ru> Dmitry Voronetskiy
2021-05-18  7:23 ` Markus Armbruster [this message]
2021-05-18  7:23   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877djwtsil.fsf@dusky.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=davoronetskiy@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=vda1999@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.