From: "Chubb, Peter (Data61, Kensington NSW)" <Peter.Chubb@data61.csiro.au>
To: AlexChen <alex.chen@huawei.com>
Cc: "alistair@alistair23.me" <alistair@alistair23.me>,
Peter Maydell <peter.maydell@linaro.org>,
"jcd@tribudubois.net" <jcd@tribudubois.net>,
"peter.chubb@nicta.com.au" <peter.chubb@nicta.com.au>,
qemu-arm <qemu-arm@nongnu.org>, QEMU <qemu-devel@nongnu.org>,
QEMU Trivial <qemu-trivial@nongnu.org>,
"zhang.zhanghailiang@huawei.com" <zhang.zhanghailiang@huawei.com>
Subject: Re: [PATCH] ssi: Fix bad printf format specifiers
Date: Wed, 4 Nov 2020 21:39:55 +0000 [thread overview]
Message-ID: <877dr06btl.wl-Peter.Chubb@data61.csiro.au> (raw)
In-Reply-To: <5FA280F5.8060902@huawei.com>
>>>>> "AlexChen" == AlexChen <alex.chen@huawei.com> writes:
AlexChen> We should use printf format specifier "%u" instead of "%d"
AlexChen> for argument of type "unsigned int".
AlexChen> Reported-by: Euler Robot <euler.robot@huawei.com>
AlexChen>Signed-off-by: Alex Chen <alex.chen@huawei.com> ---
LGTM,
add
Reviewed-By: Peter Chubb <peter.chubb@data61.csiro.au>
--
Peter Chubb Tel: +61 2 9490 5852 http://ts.data61.csiro.au/
Trustworthy Systems Group CSIRO's Data61
WARNING: multiple messages have this Message-ID (diff)
From: "Chubb, Peter (Data61, Kensington NSW)" <Peter.Chubb@data61.csiro.au>
To: AlexChen <alex.chen@huawei.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
"zhang.zhanghailiang@huawei.com" <zhang.zhanghailiang@huawei.com>,
QEMU Trivial <qemu-trivial@nongnu.org>,
"alistair@alistair23.me" <alistair@alistair23.me>,
QEMU <qemu-devel@nongnu.org>,
"jcd@tribudubois.net" <jcd@tribudubois.net>,
qemu-arm <qemu-arm@nongnu.org>,
"peter.chubb@nicta.com.au" <peter.chubb@nicta.com.au>
Subject: Re: [PATCH] ssi: Fix bad printf format specifiers
Date: Wed, 4 Nov 2020 21:39:55 +0000 [thread overview]
Message-ID: <877dr06btl.wl-Peter.Chubb@data61.csiro.au> (raw)
In-Reply-To: <5FA280F5.8060902@huawei.com>
>>>>> "AlexChen" == AlexChen <alex.chen@huawei.com> writes:
AlexChen> We should use printf format specifier "%u" instead of "%d"
AlexChen> for argument of type "unsigned int".
AlexChen> Reported-by: Euler Robot <euler.robot@huawei.com>
AlexChen>Signed-off-by: Alex Chen <alex.chen@huawei.com> ---
LGTM,
add
Reviewed-By: Peter Chubb <peter.chubb@data61.csiro.au>
--
Peter Chubb Tel: +61 2 9490 5852 http://ts.data61.csiro.au/
Trustworthy Systems Group CSIRO's Data61
next prev parent reply other threads:[~2020-11-04 21:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 10:22 [PATCH] ssi: Fix bad printf format specifiers AlexChen
2020-11-04 10:22 ` AlexChen
2020-11-04 16:21 ` Alistair Francis
2020-11-04 16:21 ` Alistair Francis
2020-11-04 17:58 ` Peter Maydell
2020-11-04 17:58 ` Peter Maydell
2020-11-04 21:39 ` Chubb, Peter (Data61, Kensington NSW) [this message]
2020-11-04 21:39 ` Chubb, Peter (Data61, Kensington NSW)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dr06btl.wl-Peter.Chubb@data61.csiro.au \
--to=peter.chubb@data61.csiro.au \
--cc=alex.chen@huawei.com \
--cc=alistair@alistair23.me \
--cc=jcd@tribudubois.net \
--cc=peter.chubb@nicta.com.au \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.