All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Anshuman Gupta <anshuman.gupta@intel.com>,
	Uma Shankar <uma.shankar@intel.com>
Cc: kai.vehmanen@intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [v5] drm/i915/display: Enable DP Display Audio WA
Date: Thu, 16 Apr 2020 13:13:12 +0300	[thread overview]
Message-ID: <877dyf4u2v.fsf@intel.com> (raw)
In-Reply-To: <20200416095828.GK5533@intel.com>

On Thu, 16 Apr 2020, Anshuman Gupta <anshuman.gupta@intel.com> wrote:
> 	IMHO with control flow this function above initilization is not required.
> 	u may remove this initilization if u agree, while pushing the patch. 

I don't recommend anyone changing anything even remotely functional
while pushing. I'm fine with doing comment and whitepace changes, and as
a rule nothing else.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2020-04-16 10:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-16  7:47 [Intel-gfx] [v5] drm/i915/display: Enable DP Display Audio WA Uma Shankar
2020-04-16  8:13 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/display: Enable DP Display Audio WA (rev5) Patchwork
2020-04-16  8:19 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-04-16  9:58 ` [Intel-gfx] [v5] drm/i915/display: Enable DP Display Audio WA Anshuman Gupta
2020-04-16 10:13   ` Jani Nikula [this message]
2020-04-16 10:16     ` Shankar, Uma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dyf4u2v.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=anshuman.gupta@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=kai.vehmanen@intel.com \
    --cc=uma.shankar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.