[PATCH][SMB3.1.1 POSIX] Change noisy debug message to an FYI

[PATCH][SMB3.1.1 POSIX] Change noisy debug message to an FYI

[Steve French]

[-- Attachment #1: Type: text/plain, Size: 172 bytes --]

    The noisy posix error message in readdir was supposed
    to be an FYI (not enabled by default)
      CIFS VFS: XXX dev 66306, reparse 0, mode 755


-- 
Thanks,

Steve

[-- Attachment #2: 0001-smb3-change-noisy-error-message-to-FYI.patch --]
[-- Type: text/x-patch, Size: 990 bytes --]

From 23273272271fe27b7cff9ba9f962c9804b17abcd Mon Sep 17 00:00:00 2001
From: Steve French <stfrench@microsoft.com>
Date: Thu, 9 Apr 2020 01:07:38 -0500
Subject: [PATCH] smb3: change noisy error message to FYI

The noisy posix error message in readdir was supposed
to be an FYI (not enabled by default)
  CIFS VFS: XXX dev 66306, reparse 0, mode 755

Signed-off-by: Steve French <stfrench@microsoft.com>
---
 fs/cifs/readdir.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/cifs/readdir.c b/fs/cifs/readdir.c
index 19e4a5d3b4ca..423d85c1ba6f 100644
--- a/fs/cifs/readdir.c
+++ b/fs/cifs/readdir.c
@@ -246,7 +246,7 @@ cifs_posix_to_fattr(struct cifs_fattr *fattr, struct smb2_posix_info *info,
 	 */
 	fattr->cf_mode = le32_to_cpu(info->Mode) & ~S_IFMT;
 
-	cifs_dbg(VFS, "XXX dev %d, reparse %d, mode %o",
+	cifs_dbg(FYI, "XXX dev %d, reparse %d, mode %o",
 		 le32_to_cpu(info->DeviceId),
 		 le32_to_cpu(info->ReparseTag),
 		 le32_to_cpu(info->Mode));
-- 
2.20.1

Re: [PATCH][SMB3.1.1 POSIX] Change noisy debug message to an FYI

[Aurélien Aptel]

Steve French <smfrench@gmail.com> writes:
>     The noisy posix error message in readdir was supposed
>     to be an FYI (not enabled by default)
>       CIFS VFS: XXX dev 66306, reparse 0, mode 755

Oops, the XXX was not supposed to be there either. Can you remove it?

Cheers,
-- 
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)

Re: [PATCH][SMB3.1.1 POSIX] Change noisy debug message to an FYI

[Steve French]

[-- Attachment #1: Type: text/plain, Size: 679 bytes --]

Updated


On Thu, Apr 9, 2020 at 4:55 AM Aurélien Aptel <aaptel@suse.com> wrote:
>
> Steve French <smfrench@gmail.com> writes:
> >     The noisy posix error message in readdir was supposed
> >     to be an FYI (not enabled by default)
> >       CIFS VFS: XXX dev 66306, reparse 0, mode 755
>
> Oops, the XXX was not supposed to be there either. Can you remove it?
>
> Cheers,
> --
> Aurélien Aptel / SUSE Labs Samba Team
> GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
> SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
> GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)



-- 
Thanks,

Steve

[-- Attachment #2: 0001-smb3-change-noisy-error-message-to-FYI.patch --]
[-- Type: text/x-patch, Size: 1045 bytes --]

From 23273272271fe27b7cff9ba9f962c9804b17abcd Mon Sep 17 00:00:00 2001
From: Steve French <stfrench@microsoft.com>
Date: Thu, 9 Apr 2020 01:07:38 -0500
Subject: [PATCH] smb3: change noisy error message to FYI

The noisy posix error message in readdir was supposed
to be an FYI (not enabled by default)
  CIFS VFS: XXX dev 66306, reparse 0, mode 755

Signed-off-by: Steve French <stfrench@microsoft.com>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
---
 fs/cifs/readdir.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/cifs/readdir.c b/fs/cifs/readdir.c
index 19e4a5d3b4ca..423d85c1ba6f 100644
--- a/fs/cifs/readdir.c
+++ b/fs/cifs/readdir.c
@@ -246,7 +246,7 @@ cifs_posix_to_fattr(struct cifs_fattr *fattr, struct smb2_posix_info *info,
 	 */
 	fattr->cf_mode = le32_to_cpu(info->Mode) & ~S_IFMT;
 
-	cifs_dbg(VFS, "XXX dev %d, reparse %d, mode %o",
+	cifs_dbg(FYI, "posix fattr: dev %d, reparse %d, mode %o",
 		 le32_to_cpu(info->DeviceId),
 		 le32_to_cpu(info->ReparseTag),
 		 le32_to_cpu(info->Mode));
-- 
2.20.1