All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH/next 2/2] package/libnice: add optional dependency to openssl
Date: Sun, 01 Sep 2019 11:06:34 +0300	[thread overview]
Message-ID: <877e6sbfud.fsf@tarshish> (raw)
In-Reply-To: <aj9s3gx121.ln2@ID-313208.user.individual.net>

Hi Bernd,

On Sun, Sep 01 2019, Bernd Kuhls wrote:
> Am Sat, 31 Aug 2019 23:07:35 +0300 schrieb Baruch Siach:
>
>>> -	select BR2_PACKAGE_GNUTLS
>>> +	select BR2_PACKAGE_OPENSSL if !BR2_PACKAGE_GNUTLS
>> 
>> Is there a reason to change the default selected crypto library from
>> Gnutls to Openssl?
>
> yes, if
>
> 	select BR2_PACKAGE_GNUTLS if !BR2_PACKAGE_OPENSSL
>
> is used, menuconfig throws this warning:
>
> package/openssl/Config.in:4:error: recursive dependency detected!
> package/openssl/Config.in:4:	symbol BR2_PACKAGE_OPENSSL is selected by BR2_PACKAGE_GNUTLS
> package/gnutls/Config.in:1:	symbol BR2_PACKAGE_GNUTLS is selected by BR2_PACKAGE_OPENSSL

I see.

I think this should be mentioned in the commit log. Especially since
Config.in defaults to openssl, while .mk defaults to gnutls.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

  reply	other threads:[~2019-09-01  8:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-31 13:04 [Buildroot] [PATCH/next 1/2] package/libnice: bump version to 0.1.16 Bernd Kuhls
2019-08-31 13:04 ` [Buildroot] [PATCH/next 2/2] package/libnice: add optional dependency to openssl Bernd Kuhls
2019-08-31 20:07   ` Baruch Siach
2019-09-01  7:46     ` Bernd Kuhls
2019-09-01  8:06       ` Baruch Siach [this message]
2019-12-16 21:16   ` Thomas Petazzoni
2019-12-16 21:14 ` [Buildroot] [PATCH/next 1/2] package/libnice: bump version to 0.1.16 Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877e6sbfud.fsf@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.