All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH/next 2/2] package/libnice: add optional dependency to openssl
Date: Sat, 31 Aug 2019 23:07:35 +0300	[thread overview]
Message-ID: <87ftlhayk8.fsf@tarshish> (raw)
In-Reply-To: <20190831130417.7725-2-bernd.kuhls@t-online.de>

Hi Bernd,

On Sat, Aug 31 2019, Bernd Kuhls wrote:
> Support for OpenSSL was added in version 0.1.15:
> https://lists.freedesktop.org/archives/nice/2018-December/001443.html
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/libnice/Config.in  |  2 +-
>  package/libnice/libnice.mk | 10 +++++++++-
>  2 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/package/libnice/Config.in b/package/libnice/Config.in
> index af8e814618..1f62c0b5c8 100644
> --- a/package/libnice/Config.in
> +++ b/package/libnice/Config.in
> @@ -4,7 +4,7 @@ config BR2_PACKAGE_LIBNICE
>  	depends on BR2_USE_WCHAR # libglib2
>  	depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2
>  	depends on BR2_USE_MMU # fork()
> -	select BR2_PACKAGE_GNUTLS
> +	select BR2_PACKAGE_OPENSSL if !BR2_PACKAGE_GNUTLS

Is there a reason to change the default selected crypto library from
Gnutls to Openssl?

baruch

>  	select BR2_PACKAGE_LIBGLIB2
>  	help
>  	  Libnice is an implementation of the IETF's Interactive
> diff --git a/package/libnice/libnice.mk b/package/libnice/libnice.mk
> index b2fea4d66c..4921deab33 100644
> --- a/package/libnice/libnice.mk
> +++ b/package/libnice/libnice.mk
> @@ -8,9 +8,17 @@ LIBNICE_VERSION = 0.1.16
>  LIBNICE_SITE = http://nice.freedesktop.org/releases
>  LIBNICE_LICENSE = MPL-1.1 or LGPL-2.1
>  LIBNICE_LICENSE_FILES = COPYING COPYING.MPL COPYING.LGPL
> -LIBNICE_DEPENDENCIES = gnutls libglib2 host-pkgconf
> +LIBNICE_DEPENDENCIES = libglib2 host-pkgconf
>  LIBNICE_INSTALL_STAGING = YES
>
> +ifeq ($(BR2_PACKAGE_GNUTLS),y)
> +LIBNICE_CONF_OPTS += --without-openssl
> +LIBNICE_DEPENDENCIES += gnutls
> +else
> +LIBNICE_CONF_OPTS += --with-openssl=$(STAGING_DIR)/usr
> +LIBNICE_DEPENDENCIES += openssl
> +endif
> +
>  ifeq ($(BR2_PACKAGE_GST_PLUGINS_BASE),y)
>  LIBNICE_CONF_OPTS += --with-gstreamer-0.10
>  LIBNICE_DEPENDENCIES += gst-plugins-base


--
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

  reply	other threads:[~2019-08-31 20:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-31 13:04 [Buildroot] [PATCH/next 1/2] package/libnice: bump version to 0.1.16 Bernd Kuhls
2019-08-31 13:04 ` [Buildroot] [PATCH/next 2/2] package/libnice: add optional dependency to openssl Bernd Kuhls
2019-08-31 20:07   ` Baruch Siach [this message]
2019-09-01  7:46     ` Bernd Kuhls
2019-09-01  8:06       ` Baruch Siach
2019-12-16 21:16   ` Thomas Petazzoni
2019-12-16 21:14 ` [Buildroot] [PATCH/next 1/2] package/libnice: bump version to 0.1.16 Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftlhayk8.fsf@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.