From: Markus Armbruster <armbru@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Makefile: remove unused variables
Date: Tue, 06 Aug 2019 07:48:43 +0200 [thread overview]
Message-ID: <877e7qsv2c.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <87imrasv8m.fsf@dusky.pond.sub.org> (Markus Armbruster's message of "Tue, 06 Aug 2019 07:44:57 +0200")
Markus Armbruster <armbru@redhat.com> writes:
> Paolo Bonzini <pbonzini@redhat.com> writes:
>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>> Makefile | 4 ----
>> 1 file changed, 4 deletions(-)
>>
>> diff --git a/Makefile b/Makefile
>> index 73fbba0..7b0e2f4 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -429,10 +429,6 @@ dummy := $(call unnest-vars,, \
>> io-obj-y \
>> common-obj-y \
>> common-obj-m \
>> - ui-obj-y \
>> - ui-obj-m \
>> - audio-obj-y \
>> - audio-obj-m \
>> trace-obj-y)
>>
>> include $(SRC_PATH)/tests/Makefile.include
>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
Hmm... the two go back to
commit 08a05b379ac56430cbb748882ff1b48dc9fe8729
Author: Gerd Hoffmann <kraxel@redhat.com>
Date: Tue Mar 6 08:40:49 2018 +0100
build: enable audio modules
Add audio/ to common-obj-m variable.
Also run both audio and ui variables through unnest-vars.
This avoids sdl.mo (exists in both audio/ and ui/) name clashes.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Message-id: 20180306074053.22856-4-kraxel@redhat.com
Gerd, anything funny going on here, or is Paolo's patch okay?
next prev parent reply other threads:[~2019-08-06 5:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 22:09 [Qemu-devel] [PATCH] Makefile: remove unused variables Paolo Bonzini
2019-08-06 5:44 ` Markus Armbruster
2019-08-06 5:48 ` Markus Armbruster [this message]
2019-08-06 6:40 ` Gerd Hoffmann
2019-08-06 7:04 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877e7qsv2c.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.