All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Wen Gong <wgong@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH v3] ath10k: support NET_DETECT WoWLAN feature
Date: Tue, 04 Sep 2018 12:15:28 +0300	[thread overview]
Message-ID: <877ek18vyn.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1534402113-14337-1-git-send-email-wgong@codeaurora.org> (Wen Gong's message of "Thu, 16 Aug 2018 14:48:33 +0800")

Wen Gong <wgong@codeaurora.org> writes:

> For WoWLAN support, it expect to support wake up based on discovery of
> one or more known SSIDs. This is the WIPHY_WOWLAN_NET_DETECT feature,
> which shows up as an NL80211 feature flag.
>
> With an upgrade iw, this shows up in 'iw phy' as:
> WoWLAN support:
> * wake up on network detection, up to 16 match sets
> And it can use command:
> "iw phy0 wowlan enable net-detect interval 5000 delay 30 freqs 2412
> matches ssid foo" to configure the parameters of net detect.
>
> Firmware will do scan by the configured parameters after suspend and
> wakeup if it found matched SSIDs. Tested with QCA6174 hw3.0 with
> firmware WLAN.RM.4.4.1-00110-QCARMSWPZ-1.
>
> Signed-off-by: Wen Gong <wgong@codeaurora.org>

[...]

> +/* Request FW to start PNO operation */
> +static struct sk_buff *ath10k_wmi_tlv_op_gen_config_pno_start
> +				(struct ath10k *ar,
> +				u32 vdev_id,
> +				struct wmi_pno_scan_req *pno)
> +{
> +	struct wmi_tlv_wow_nlo_config_cmd *cmd;
> +	struct wmi_tlv *tlv;
> +	struct sk_buff *skb;
> +	struct nlo_configured_parameters *nlo_list;
> +	u32 *channel_list;

[...]

> +	channel_list = (u32 *)ptr;
> +	for (i = 0; i < cmd->num_of_channels; i++)
> +		channel_list[i] = pno->a_networks[0].channels[i];

channel_list does not look endian safe to me, I'll change this to use
__le32.

> +enum wmi_nlo_cipher_algorithm {
> +	WMI_NLO_CIPHER_ALGO_NONE           = 0x00,
> +	WMI_NLO_CIPHER_ALGO_WEP40          = 0x01,
> +	WMI_NLO_CIPHER_ALGO_TKIP           = 0x02,
> +	WMI_NLO_CIPHER_ALGO_CCMP           = 0x04,
> +	WMI_NLO_CIPHER_ALGO_WEP104         = 0x05,
> +	WMI_NLO_CIPHER_ALGO_BIP            = 0x06,
> +	WMI_NLO_CIPHER_ALGO_WPA_USE_GROUP  = 0x100,
> +	WMI_NLO_CIPHER_ALGO_RSN_USE_GROUP  = 0x100,

Two defines with the same value 0x100, is this really correct?

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Wen Gong <wgong@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3] ath10k: support NET_DETECT WoWLAN feature
Date: Tue, 04 Sep 2018 12:15:28 +0300	[thread overview]
Message-ID: <877ek18vyn.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1534402113-14337-1-git-send-email-wgong@codeaurora.org> (Wen Gong's message of "Thu, 16 Aug 2018 14:48:33 +0800")

Wen Gong <wgong@codeaurora.org> writes:

> For WoWLAN support, it expect to support wake up based on discovery of
> one or more known SSIDs. This is the WIPHY_WOWLAN_NET_DETECT feature,
> which shows up as an NL80211 feature flag.
>
> With an upgrade iw, this shows up in 'iw phy' as:
> WoWLAN support:
> * wake up on network detection, up to 16 match sets
> And it can use command:
> "iw phy0 wowlan enable net-detect interval 5000 delay 30 freqs 2412
> matches ssid foo" to configure the parameters of net detect.
>
> Firmware will do scan by the configured parameters after suspend and
> wakeup if it found matched SSIDs. Tested with QCA6174 hw3.0 with
> firmware WLAN.RM.4.4.1-00110-QCARMSWPZ-1.
>
> Signed-off-by: Wen Gong <wgong@codeaurora.org>

[...]

> +/* Request FW to start PNO operation */
> +static struct sk_buff *ath10k_wmi_tlv_op_gen_config_pno_start
> +				(struct ath10k *ar,
> +				u32 vdev_id,
> +				struct wmi_pno_scan_req *pno)
> +{
> +	struct wmi_tlv_wow_nlo_config_cmd *cmd;
> +	struct wmi_tlv *tlv;
> +	struct sk_buff *skb;
> +	struct nlo_configured_parameters *nlo_list;
> +	u32 *channel_list;

[...]

> +	channel_list = (u32 *)ptr;
> +	for (i = 0; i < cmd->num_of_channels; i++)
> +		channel_list[i] = pno->a_networks[0].channels[i];

channel_list does not look endian safe to me, I'll change this to use
__le32.

> +enum wmi_nlo_cipher_algorithm {
> +	WMI_NLO_CIPHER_ALGO_NONE           = 0x00,
> +	WMI_NLO_CIPHER_ALGO_WEP40          = 0x01,
> +	WMI_NLO_CIPHER_ALGO_TKIP           = 0x02,
> +	WMI_NLO_CIPHER_ALGO_CCMP           = 0x04,
> +	WMI_NLO_CIPHER_ALGO_WEP104         = 0x05,
> +	WMI_NLO_CIPHER_ALGO_BIP            = 0x06,
> +	WMI_NLO_CIPHER_ALGO_WPA_USE_GROUP  = 0x100,
> +	WMI_NLO_CIPHER_ALGO_RSN_USE_GROUP  = 0x100,

Two defines with the same value 0x100, is this really correct?

-- 
Kalle Valo

  reply	other threads:[~2018-09-04  9:15 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-16  6:48 [PATCH v3] ath10k: support NET_DETECT WoWLAN feature Wen Gong
2018-08-16  6:48 ` Wen Gong
2018-09-04  9:15 ` Kalle Valo [this message]
2018-09-04  9:15   ` Kalle Valo
2018-09-04 11:18   ` [EXTERNAL] " Wen Gong
2018-09-04 11:18     ` Wen Gong
2018-09-04 11:43     ` Kalle Valo
2018-09-04 11:43       ` Kalle Valo
2018-09-05  2:51       ` Wen Gong
2018-09-05  2:51         ` Wen Gong
2018-10-12 15:37         ` Kalle Valo
2018-10-12 15:37           ` Kalle Valo
2018-10-13 17:18 ` Kalle Valo
2018-10-13 17:18 ` Kalle Valo
2018-11-14 22:59 ` Brian Norris
2018-11-14 22:59   ` Brian Norris
2019-09-17 16:32   ` Brian Norris
2019-09-17 16:32     ` Brian Norris
2019-09-18 14:03     ` Kalle Valo
2019-09-18 14:03       ` Kalle Valo
2019-09-20  0:52       ` Brian Norris
2019-09-20  0:52         ` Brian Norris
2019-09-20  2:55       ` Wen Gong
2019-09-20  2:55         ` Wen Gong
2019-09-20  7:32         ` Kalle Valo
2019-09-20  7:32           ` Kalle Valo
2019-09-20  9:37           ` Wen Gong
2019-09-20  9:37             ` Wen Gong
2019-10-03  0:58           ` Brian Norris
2019-10-03  0:58             ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877ek18vyn.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@codeaurora.org \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=wgong@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.