All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, linuxppc-dev@lists.ozlabs.org
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
	Alex Williamson <alex.williamson@redhat.com>,
	kvm-ppc@vger.kernel.org,
	David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH kernel v2 0/2] KVM: PPC: Check if IOMMU page is contained in the pinned physical page
Date: Fri, 29 Jun 2018 01:55:40 +0000	[thread overview]
Message-ID: <877emiwe3n.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20180626055926.27703-1-aik@ozlabs.ru>

Alexey Kardashevskiy <aik@ozlabs.ru> writes:

> This is to improve page boundaries checking and should probably
> be cc:stable. I came accross this while debugging nvlink2 passthrough
> but the lack of checking might be exploited by the existing userspace.

Do you really mean "exploited" ? As in there's a security issue?

Your change log for patch 2 sort of suggests that but then says that
without the fix you just hit an error in vfio code.

So I'm not clear on what the exposure is.

cheers

WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, linuxppc-dev@lists.ozlabs.org
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
	Alex Williamson <alex.williamson@redhat.com>,
	kvm-ppc@vger.kernel.org,
	David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH kernel v2 0/2] KVM: PPC: Check if IOMMU page is contained in the pinned physical page
Date: Fri, 29 Jun 2018 11:55:40 +1000	[thread overview]
Message-ID: <877emiwe3n.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20180626055926.27703-1-aik@ozlabs.ru>

Alexey Kardashevskiy <aik@ozlabs.ru> writes:

> This is to improve page boundaries checking and should probably
> be cc:stable. I came accross this while debugging nvlink2 passthrough
> but the lack of checking might be exploited by the existing userspace.

Do you really mean "exploited" ? As in there's a security issue?

Your change log for patch 2 sort of suggests that but then says that
without the fix you just hit an error in vfio code.

So I'm not clear on what the exposure is.

cheers

  parent reply	other threads:[~2018-06-29  1:55 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-26  5:59 [PATCH kernel v2 0/2] KVM: PPC: Check if IOMMU page is contained in the pinned physical page Alexey Kardashevskiy
2018-06-26  5:59 ` Alexey Kardashevskiy
2018-06-26  5:59 ` [PATCH kernel v2 1/2] vfio/spapr: Use IOMMU pageshift rather than pagesize Alexey Kardashevskiy
2018-06-26  5:59   ` Alexey Kardashevskiy
2018-06-30 19:56   ` Alex Williamson
2018-06-30 19:56     ` Alex Williamson
2018-06-26  5:59 ` [PATCH kernel v2 2/2] KVM: PPC: Check if IOMMU page is contained in the pinned physical page Alexey Kardashevskiy
2018-06-26  5:59   ` Alexey Kardashevskiy
2018-06-29  4:12   ` David Gibson
2018-06-29  4:12     ` David Gibson
2018-06-29  4:51     ` Alexey Kardashevskiy
2018-06-29  4:51       ` Alexey Kardashevskiy
2018-06-29  4:57       ` David Gibson
2018-06-29  4:57         ` David Gibson
2018-06-29  5:18         ` Alexey Kardashevskiy
2018-06-29  5:18           ` Alexey Kardashevskiy
2018-06-29  7:07           ` Alexey Kardashevskiy
2018-06-29  7:07             ` Alexey Kardashevskiy
2018-07-02  4:08             ` David Gibson
2018-07-02  4:08               ` David Gibson
2018-07-02  4:33               ` Alexey Kardashevskiy
2018-07-02  4:33                 ` Alexey Kardashevskiy
2018-07-02  4:52                 ` David Gibson
2018-07-02  4:52                   ` David Gibson
2018-07-02  6:32                   ` Alexey Kardashevskiy
2018-07-02  6:32                     ` Alexey Kardashevskiy
2018-07-03  1:36                     ` David Gibson
2018-07-03  1:36                       ` David Gibson
2018-06-29  1:55 ` Michael Ellerman [this message]
2018-06-29  1:55   ` [PATCH kernel v2 0/2] " Michael Ellerman
2018-06-29  3:00   ` Alexey Kardashevskiy
2018-06-29  3:00     ` Alexey Kardashevskiy
2018-06-29  4:14     ` David Gibson
2018-06-29  4:14       ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877emiwe3n.fsf@concordia.ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=aik@ozlabs.ru \
    --cc=alex.williamson@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.