* [PATCH] Revert "drm/i915: Ignore panel type from OpRegion on SKL"
@ 2017-03-08 14:33 ville.syrjala
2017-03-08 14:53 ` Jani Nikula
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: ville.syrjala @ 2017-03-08 14:33 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula, Daniel Vetter, James Bottomley
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
This reverts commit bb10d4ec3be4b069bfb61c60ca4f708f58f440f1.
Since commit c8ebfad7a063 ("drm/i915: Ignore OpRegion panel type except
on select machines") we ignore the OpRegion panel type except for
specific machines (handled via a DMI match), so having SKL explicitly
excluded from using the OpRegion panel type is redundant. So let's
remove the SKL check.
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/intel_opregion.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c
index 4a862a358c70..2e870da8927a 100644
--- a/drivers/gpu/drm/i915/intel_opregion.c
+++ b/drivers/gpu/drm/i915/intel_opregion.c
@@ -1061,16 +1061,5 @@ intel_opregion_get_panel_type(struct drm_i915_private *dev_priv)
return -ENODEV;
}
- /*
- * FIXME On Dell XPS 13 9350 the OpRegion panel type (0) gives us
- * low vswing for eDP, whereas the VBT panel type (2) gives us normal
- * vswing instead. Low vswing results in some display flickers, so
- * let's simply ignore the OpRegion panel type on SKL for now.
- */
- if (IS_SKYLAKE(dev_priv)) {
- DRM_DEBUG_KMS("Ignoring OpRegion panel type (%d)\n", ret - 1);
- return -ENODEV;
- }
-
return ret - 1;
}
--
2.10.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] Revert "drm/i915: Ignore panel type from OpRegion on SKL"
2017-03-08 14:33 [PATCH] Revert "drm/i915: Ignore panel type from OpRegion on SKL" ville.syrjala
@ 2017-03-08 14:53 ` Jani Nikula
2017-03-14 10:25 ` Ville Syrjälä
2017-03-08 18:53 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-03-13 21:17 ` ✓ Fi.CI.BAT: success " Patchwork
2 siblings, 1 reply; 5+ messages in thread
From: Jani Nikula @ 2017-03-08 14:53 UTC (permalink / raw)
To: ville.syrjala, intel-gfx; +Cc: James Bottomley, Daniel Vetter
On Wed, 08 Mar 2017, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> This reverts commit bb10d4ec3be4b069bfb61c60ca4f708f58f440f1.
>
> Since commit c8ebfad7a063 ("drm/i915: Ignore OpRegion panel type except
> on select machines") we ignore the OpRegion panel type except for
> specific machines (handled via a DMI match), so having SKL explicitly
> excluded from using the OpRegion panel type is redundant. So let's
> remove the SKL check.
>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/intel_opregion.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c
> index 4a862a358c70..2e870da8927a 100644
> --- a/drivers/gpu/drm/i915/intel_opregion.c
> +++ b/drivers/gpu/drm/i915/intel_opregion.c
> @@ -1061,16 +1061,5 @@ intel_opregion_get_panel_type(struct drm_i915_private *dev_priv)
> return -ENODEV;
> }
>
> - /*
> - * FIXME On Dell XPS 13 9350 the OpRegion panel type (0) gives us
> - * low vswing for eDP, whereas the VBT panel type (2) gives us normal
> - * vswing instead. Low vswing results in some display flickers, so
> - * let's simply ignore the OpRegion panel type on SKL for now.
> - */
> - if (IS_SKYLAKE(dev_priv)) {
> - DRM_DEBUG_KMS("Ignoring OpRegion panel type (%d)\n", ret - 1);
> - return -ENODEV;
> - }
> -
> return ret - 1;
> }
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Revert "drm/i915: Ignore panel type from OpRegion on SKL"
2017-03-08 14:53 ` Jani Nikula
@ 2017-03-14 10:25 ` Ville Syrjälä
0 siblings, 0 replies; 5+ messages in thread
From: Ville Syrjälä @ 2017-03-14 10:25 UTC (permalink / raw)
To: Jani Nikula; +Cc: James Bottomley, Daniel Vetter, intel-gfx
On Wed, Mar 08, 2017 at 04:53:58PM +0200, Jani Nikula wrote:
> On Wed, 08 Mar 2017, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > This reverts commit bb10d4ec3be4b069bfb61c60ca4f708f58f440f1.
> >
> > Since commit c8ebfad7a063 ("drm/i915: Ignore OpRegion panel type except
> > on select machines") we ignore the OpRegion panel type except for
> > specific machines (handled via a DMI match), so having SKL explicitly
> > excluded from using the OpRegion panel type is redundant. So let's
> > remove the SKL check.
> >
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Thanks. Pushed to dinq.
>
> > ---
> > drivers/gpu/drm/i915/intel_opregion.c | 11 -----------
> > 1 file changed, 11 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c
> > index 4a862a358c70..2e870da8927a 100644
> > --- a/drivers/gpu/drm/i915/intel_opregion.c
> > +++ b/drivers/gpu/drm/i915/intel_opregion.c
> > @@ -1061,16 +1061,5 @@ intel_opregion_get_panel_type(struct drm_i915_private *dev_priv)
> > return -ENODEV;
> > }
> >
> > - /*
> > - * FIXME On Dell XPS 13 9350 the OpRegion panel type (0) gives us
> > - * low vswing for eDP, whereas the VBT panel type (2) gives us normal
> > - * vswing instead. Low vswing results in some display flickers, so
> > - * let's simply ignore the OpRegion panel type on SKL for now.
> > - */
> > - if (IS_SKYLAKE(dev_priv)) {
> > - DRM_DEBUG_KMS("Ignoring OpRegion panel type (%d)\n", ret - 1);
> > - return -ENODEV;
> > - }
> > -
> > return ret - 1;
> > }
>
> --
> Jani Nikula, Intel Open Source Technology Center
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* ✗ Fi.CI.BAT: failure for Revert "drm/i915: Ignore panel type from OpRegion on SKL"
2017-03-08 14:33 [PATCH] Revert "drm/i915: Ignore panel type from OpRegion on SKL" ville.syrjala
2017-03-08 14:53 ` Jani Nikula
@ 2017-03-08 18:53 ` Patchwork
2017-03-13 21:17 ` ✓ Fi.CI.BAT: success " Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2017-03-08 18:53 UTC (permalink / raw)
To: ville.syrjala; +Cc: intel-gfx
== Series Details ==
Series: Revert "drm/i915: Ignore panel type from OpRegion on SKL"
URL : https://patchwork.freedesktop.org/series/20912/
State : failure
== Summary ==
Series 20912v1 Revert "drm/i915: Ignore panel type from OpRegion on SKL"
https://patchwork.freedesktop.org/api/1.0/series/20912/revisions/1/mbox/
Test gem_exec_flush:
Subgroup basic-batch-kernel-default-uc:
fail -> PASS (fi-snb-2600) fdo#100007
pass -> INCOMPLETE (fi-skl-6770hq)
Test gem_exec_suspend:
Subgroup basic-s3:
fail -> PASS (fi-kbl-7500u)
Subgroup basic-s4-devices:
dmesg-warn -> PASS (fi-bxt-t5700)
fail -> DMESG-WARN (fi-kbl-7500u) fdo#100099
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-a:
fail -> PASS (fi-kbl-7500u)
Subgroup suspend-read-crc-pipe-b:
fail -> PASS (fi-kbl-7500u)
Subgroup suspend-read-crc-pipe-c:
fail -> PASS (fi-kbl-7500u) fdo#100044
Test pm_rpm:
Subgroup basic-pci-d3-state:
pass -> INCOMPLETE (fi-byt-n2820) fdo#99740
fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
fdo#100099 https://bugs.freedesktop.org/show_bug.cgi?id=100099
fdo#100044 https://bugs.freedesktop.org/show_bug.cgi?id=100044
fdo#99740 https://bugs.freedesktop.org/show_bug.cgi?id=99740
fi-bdw-5557u total:278 pass:267 dwarn:0 dfail:0 fail:0 skip:11 time: 469s
fi-bsw-n3050 total:278 pass:239 dwarn:0 dfail:0 fail:0 skip:39 time: 617s
fi-bxt-j4205 total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time: 545s
fi-bxt-t5700 total:278 pass:258 dwarn:0 dfail:0 fail:0 skip:20 time: 613s
fi-byt-j1900 total:278 pass:251 dwarn:0 dfail:0 fail:0 skip:27 time: 506s
fi-byt-n2820 total:241 pass:210 dwarn:0 dfail:0 fail:0 skip:30 time: 0s
fi-hsw-4770 total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time: 434s
fi-hsw-4770r total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time: 438s
fi-ilk-650 total:278 pass:228 dwarn:0 dfail:0 fail:0 skip:50 time: 444s
fi-ivb-3520m total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time: 508s
fi-ivb-3770 total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time: 490s
fi-kbl-7500u total:278 pass:259 dwarn:1 dfail:0 fail:0 skip:18 time: 478s
fi-skl-6260u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time: 509s
fi-skl-6700hq total:278 pass:261 dwarn:0 dfail:0 fail:0 skip:17 time: 599s
fi-skl-6700k total:278 pass:256 dwarn:4 dfail:0 fail:0 skip:18 time: 498s
fi-skl-6770hq total:51 pass:49 dwarn:0 dfail:0 fail:0 skip:1 time: 0s
fi-snb-2520m total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time: 553s
fi-snb-2600 total:278 pass:249 dwarn:0 dfail:0 fail:0 skip:29 time: 420s
6f8585956c95605b9c797ffde8f65e408b8d1e33 drm-tip: 2017y-03m-08d-14h-47m-28s UTC integration manifest
6dec8b1 Revert "drm/i915: Ignore panel type from OpRegion on SKL"
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4101/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* ✓ Fi.CI.BAT: success for Revert "drm/i915: Ignore panel type from OpRegion on SKL"
2017-03-08 14:33 [PATCH] Revert "drm/i915: Ignore panel type from OpRegion on SKL" ville.syrjala
2017-03-08 14:53 ` Jani Nikula
2017-03-08 18:53 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2017-03-13 21:17 ` Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2017-03-13 21:17 UTC (permalink / raw)
To: ville.syrjala; +Cc: intel-gfx
== Series Details ==
Series: Revert "drm/i915: Ignore panel type from OpRegion on SKL"
URL : https://patchwork.freedesktop.org/series/20912/
State : success
== Summary ==
Series 20912v1 Revert "drm/i915: Ignore panel type from OpRegion on SKL"
https://patchwork.freedesktop.org/api/1.0/series/20912/revisions/1/mbox/
fi-bdw-5557u total:278 pass:267 dwarn:0 dfail:0 fail:0 skip:11 time: 460s
fi-bsw-n3050 total:278 pass:239 dwarn:0 dfail:0 fail:0 skip:39 time: 579s
fi-bxt-j4205 total:278 pass:259 dwarn:0 dfail:0 fail:0 skip:19 time: 541s
fi-bxt-t5700 total:278 pass:258 dwarn:0 dfail:0 fail:0 skip:20 time: 596s
fi-byt-j1900 total:278 pass:251 dwarn:0 dfail:0 fail:0 skip:27 time: 503s
fi-byt-n2820 total:278 pass:247 dwarn:0 dfail:0 fail:0 skip:31 time: 507s
fi-hsw-4770 total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time: 431s
fi-hsw-4770r total:278 pass:262 dwarn:0 dfail:0 fail:0 skip:16 time: 434s
fi-ilk-650 total:278 pass:228 dwarn:0 dfail:0 fail:0 skip:50 time: 443s
fi-ivb-3520m total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time: 511s
fi-ivb-3770 total:278 pass:260 dwarn:0 dfail:0 fail:0 skip:18 time: 499s
fi-kbl-7500u total:278 pass:259 dwarn:1 dfail:0 fail:0 skip:18 time: 476s
fi-skl-6260u total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time: 497s
fi-skl-6700hq total:278 pass:261 dwarn:0 dfail:0 fail:0 skip:17 time: 601s
fi-skl-6700k total:278 pass:256 dwarn:4 dfail:0 fail:0 skip:18 time: 496s
fi-skl-6770hq total:278 pass:268 dwarn:0 dfail:0 fail:0 skip:10 time: 549s
fi-snb-2520m total:278 pass:250 dwarn:0 dfail:0 fail:0 skip:28 time: 547s
fi-snb-2600 total:278 pass:249 dwarn:0 dfail:0 fail:0 skip:29 time: 415s
7748ac05e8cd90e45f039d434ac4e600e54fe6e9 drm-tip: 2017y-03m-13d-20h-07m-51s UTC integration manifest
018a86a Revert "drm/i915: Ignore panel type from OpRegion on SKL"
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4157/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-03-14 10:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-08 14:33 [PATCH] Revert "drm/i915: Ignore panel type from OpRegion on SKL" ville.syrjala
2017-03-08 14:53 ` Jani Nikula
2017-03-14 10:25 ` Ville Syrjälä
2017-03-08 18:53 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-03-13 21:17 ` ✓ Fi.CI.BAT: success " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.