diff for duplicates of <877fa7xq1v.fsf@linux.vnet.ibm.com> diff --git a/a/1.txt b/N1/1.txt index 43eeea9..7c21a55 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,6 +1,6 @@ christophe leroy <christophe.leroy@c-s.fr> writes: -> Le 19/09/2016 =C3=A0 07:50, Aneesh Kumar K.V a =C3=A9crit : +> Le 19/09/2016 à 07:50, Aneesh Kumar K.V a écrit : >> >> Christophe Leroy <christophe.leroy@c-s.fr> writes: >>> +#else @@ -15,17 +15,16 @@ christophe leroy <christophe.leroy@c-s.fr> writes: >> I was expecting that BUG will get removed in the next patch. But I don't >> see it in the next patch. Considering >> ->> @@ -475,11 +453,10 @@ static void free_hugepd_range(struct mmu_gather *t= -lb, hugepd_t *hpdp, int pdshif ->> for (i =3D 0; i < num_hugepd; i++, hpdp++) ->> hpdp->pd =3D 0; +>> @@ -475,11 +453,10 @@ static void free_hugepd_range(struct mmu_gather *tlb, hugepd_t *hpdp, int pdshif +>> for (i = 0; i < num_hugepd; i++, hpdp++) +>> hpdp->pd = 0; >> >> -#ifdef CONFIG_PPC_FSL_BOOK3E >> - hugepd_free(tlb, hugepte); >> -#else >> - pgtable_free_tlb(tlb, hugepte, pdshift - shift); >> -#endif ->> + if (shift >=3D pdshift) +>> + if (shift >= pdshift) >> + hugepd_free(tlb, hugepte); >> + else >> + pgtable_free_tlb(tlb, hugepte, pdshift - shift); @@ -34,15 +33,14 @@ lb, hugepd_t *hpdp, int pdshif >> What is that I am missing ? >> > -> Previously, call to hugepd_free() was compiled only when #ifdef=20 +> Previously, call to hugepd_free() was compiled only when #ifdef > CONFIG_PPC_FSL_BOOK3E -> Now, it is compiled at all time, but it should never be called if not=20 +> Now, it is compiled at all time, but it should never be called if not > CONFIG_PPC_FSL_BOOK3E because we always have shift < pdshift in that case. -> Then the function needs to be defined anyway but should never be called.= -=20 +> Then the function needs to be defined anyway but should never be called. > Should I just define it static inline {} ? > -For 8M with 4K mode, we have shift >=3D pdshift right ? +For 8M with 4K mode, we have shift >= pdshift right ? -aneesh diff --git a/a/content_digest b/N1/content_digest index a847288..fa08ce9 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -16,7 +16,7 @@ "b\0" "christophe leroy <christophe.leroy@c-s.fr> writes:\n" "\n" - "> Le 19/09/2016 =C3=A0 07:50, Aneesh Kumar K.V a =C3=A9crit :\n" + "> Le 19/09/2016 \303\240 07:50, Aneesh Kumar K.V a \303\251crit :\n" ">>\n" ">> Christophe Leroy <christophe.leroy@c-s.fr> writes:\n" ">>> +#else\n" @@ -31,17 +31,16 @@ ">> I was expecting that BUG will get removed in the next patch. But I don't\n" ">> see it in the next patch. Considering\n" ">>\n" - ">> @@ -475,11 +453,10 @@ static void free_hugepd_range(struct mmu_gather *t=\n" - "lb, hugepd_t *hpdp, int pdshif\n" - ">> for (i =3D 0; i < num_hugepd; i++, hpdp++)\n" - ">> hpdp->pd =3D 0;\n" + ">> @@ -475,11 +453,10 @@ static void free_hugepd_range(struct mmu_gather *tlb, hugepd_t *hpdp, int pdshif\n" + ">> for (i = 0; i < num_hugepd; i++, hpdp++)\n" + ">> hpdp->pd = 0;\n" ">>\n" ">> -#ifdef CONFIG_PPC_FSL_BOOK3E\n" ">> -\thugepd_free(tlb, hugepte);\n" ">> -#else\n" ">> -\tpgtable_free_tlb(tlb, hugepte, pdshift - shift);\n" ">> -#endif\n" - ">> +\tif (shift >=3D pdshift)\n" + ">> +\tif (shift >= pdshift)\n" ">> +\t\thugepd_free(tlb, hugepte);\n" ">> +\telse\n" ">> +\t\tpgtable_free_tlb(tlb, hugepte, pdshift - shift);\n" @@ -50,17 +49,16 @@ ">> What is that I am missing ?\n" ">>\n" ">\n" - "> Previously, call to hugepd_free() was compiled only when #ifdef=20\n" + "> Previously, call to hugepd_free() was compiled only when #ifdef \n" "> CONFIG_PPC_FSL_BOOK3E\n" - "> Now, it is compiled at all time, but it should never be called if not=20\n" + "> Now, it is compiled at all time, but it should never be called if not \n" "> CONFIG_PPC_FSL_BOOK3E because we always have shift < pdshift in that case.\n" - "> Then the function needs to be defined anyway but should never be called.=\n" - "=20\n" + "> Then the function needs to be defined anyway but should never be called. \n" "> Should I just define it static inline {} ?\n" ">\n" "\n" - "For 8M with 4K mode, we have shift >=3D pdshift right ?\n" + "For 8M with 4K mode, we have shift >= pdshift right ?\n" "\n" -aneesh -e843319379a8921a72ef589f6e62ca5097bc823662be68b46cc063f3e30eb9b4 +2ec13587ca3e3aaf981fa459fb9ac9448dbf60fe52c5189387659105e7daa550
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.