From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: christophe leroy <christophe.leroy@c-s.fr>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Scott Wood <oss@buserror.net>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 2/3] powerpc: get hugetlbpage handling more generic
Date: Tue, 20 Sep 2016 07:58:44 +0530 [thread overview]
Message-ID: <877fa7xq1v.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <68949cf6-c70b-f616-4586-fa438a7c17cd@c-s.fr>
christophe leroy <christophe.leroy@c-s.fr> writes:
> Le 19/09/2016 =C3=A0 07:50, Aneesh Kumar K.V a =C3=A9crit :
>>
>> Christophe Leroy <christophe.leroy@c-s.fr> writes:
>>> +#else
>>> +static void hugepd_free(struct mmu_gather *tlb, void *hugepte)
>>> +{
>>> + BUG();
>>> +}
>>> +
>>> #endif
>>
>>
>> I was expecting that BUG will get removed in the next patch. But I don't
>> see it in the next patch. Considering
>>
>> @@ -475,11 +453,10 @@ static void free_hugepd_range(struct mmu_gather *t=
lb, hugepd_t *hpdp, int pdshif
>> for (i =3D 0; i < num_hugepd; i++, hpdp++)
>> hpdp->pd =3D 0;
>>
>> -#ifdef CONFIG_PPC_FSL_BOOK3E
>> - hugepd_free(tlb, hugepte);
>> -#else
>> - pgtable_free_tlb(tlb, hugepte, pdshift - shift);
>> -#endif
>> + if (shift >=3D pdshift)
>> + hugepd_free(tlb, hugepte);
>> + else
>> + pgtable_free_tlb(tlb, hugepte, pdshift - shift);
>> }
>>
>> What is that I am missing ?
>>
>
> Previously, call to hugepd_free() was compiled only when #ifdef=20
> CONFIG_PPC_FSL_BOOK3E
> Now, it is compiled at all time, but it should never be called if not=20
> CONFIG_PPC_FSL_BOOK3E because we always have shift < pdshift in that case.
> Then the function needs to be defined anyway but should never be called.=
=20
> Should I just define it static inline {} ?
>
For 8M with 4K mode, we have shift >=3D pdshift right ?
-aneesh
WARNING: multiple messages have this Message-ID (diff)
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: christophe leroy <christophe.leroy@c-s.fr>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Scott Wood <oss@buserror.net>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 2/3] powerpc: get hugetlbpage handling more generic
Date: Tue, 20 Sep 2016 07:58:44 +0530 [thread overview]
Message-ID: <877fa7xq1v.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <68949cf6-c70b-f616-4586-fa438a7c17cd@c-s.fr>
christophe leroy <christophe.leroy@c-s.fr> writes:
> Le 19/09/2016 à 07:50, Aneesh Kumar K.V a écrit :
>>
>> Christophe Leroy <christophe.leroy@c-s.fr> writes:
>>> +#else
>>> +static void hugepd_free(struct mmu_gather *tlb, void *hugepte)
>>> +{
>>> + BUG();
>>> +}
>>> +
>>> #endif
>>
>>
>> I was expecting that BUG will get removed in the next patch. But I don't
>> see it in the next patch. Considering
>>
>> @@ -475,11 +453,10 @@ static void free_hugepd_range(struct mmu_gather *tlb, hugepd_t *hpdp, int pdshif
>> for (i = 0; i < num_hugepd; i++, hpdp++)
>> hpdp->pd = 0;
>>
>> -#ifdef CONFIG_PPC_FSL_BOOK3E
>> - hugepd_free(tlb, hugepte);
>> -#else
>> - pgtable_free_tlb(tlb, hugepte, pdshift - shift);
>> -#endif
>> + if (shift >= pdshift)
>> + hugepd_free(tlb, hugepte);
>> + else
>> + pgtable_free_tlb(tlb, hugepte, pdshift - shift);
>> }
>>
>> What is that I am missing ?
>>
>
> Previously, call to hugepd_free() was compiled only when #ifdef
> CONFIG_PPC_FSL_BOOK3E
> Now, it is compiled at all time, but it should never be called if not
> CONFIG_PPC_FSL_BOOK3E because we always have shift < pdshift in that case.
> Then the function needs to be defined anyway but should never be called.
> Should I just define it static inline {} ?
>
For 8M with 4K mode, we have shift >= pdshift right ?
-aneesh
next prev parent reply other threads:[~2016-09-20 2:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 7:40 [PATCH v2 0/3] powerpc: implementation of huge pages for 8xx Christophe Leroy
2016-09-16 7:40 ` [PATCH v2 1/3] powerpc: port 64 bits pgtable_cache to 32 bits Christophe Leroy
2016-09-19 5:22 ` Aneesh Kumar K.V
2016-09-19 18:46 ` christophe leroy
2016-09-16 7:40 ` [PATCH v2 2/3] powerpc: get hugetlbpage handling more generic Christophe Leroy
2016-09-19 5:45 ` Aneesh Kumar K.V
2016-09-19 18:32 ` christophe leroy
2016-09-20 2:45 ` Aneesh Kumar K.V
2016-09-21 6:13 ` Christophe Leroy
2016-09-19 5:50 ` Aneesh Kumar K.V
2016-09-19 18:36 ` christophe leroy
2016-09-20 2:28 ` Aneesh Kumar K.V [this message]
2016-09-20 2:28 ` Aneesh Kumar K.V
2016-09-20 5:22 ` Christophe Leroy
2016-09-16 7:40 ` [PATCH v2 3/3] powerpc/8xx: Implement support of hugepages Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fa7xq1v.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=oss@buserror.net \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.