[Qemu-devel] [PATCH] build-sys: delete TAGS in distclean only

[Qemu-devel] [PATCH] build-sys: delete TAGS in distclean only

[marcandre.lureau]

From: Marc-André Lureau <marcandre.lureau@redhat.com>

automake and other GNU build-sys generally keep TAGS file in make
'clean' rule and delete it only in 'distclean' (and 'mrproper' for
linux). Do the same for qemu.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index 651bb89..fd63e1b 100644
--- a/Makefile
+++ b/Makefile
@@ -347,7 +347,7 @@ clean:
 	rm -f qemu-options.def
 	rm -f *.msi
 	find . \( -name '*.l[oa]' -o -name '*.so' -o -name '*.dll' -o -name '*.mo' -o -name '*.[oda]' \) -type f -exec rm {} +
-	rm -f $(filter-out %.tlb,$(TOOLS)) $(HELPERS-y) qemu-ga TAGS cscope.* *.pod *~ */*~
+	rm -f $(filter-out %.tlb,$(TOOLS)) $(HELPERS-y) qemu-ga cscope.* *.pod *~ */*~
 	rm -f fsdev/*.pod
 	rm -rf .libs */.libs
 	rm -f qemu-img-cmds.h
@@ -380,7 +380,7 @@ distclean: clean
 	rm -f qemu-doc.fn qemu-doc.fns qemu-doc.info qemu-doc.ky qemu-doc.kys
 	rm -f qemu-doc.log qemu-doc.pdf qemu-doc.pg qemu-doc.toc qemu-doc.tp
 	rm -f qemu-doc.vr
-	rm -f config.log
+	rm -f config.log TAGS
 	rm -f linux-headers/asm
 	rm -f qemu-tech.info qemu-tech.aux qemu-tech.cp qemu-tech.dvi qemu-tech.fn qemu-tech.info qemu-tech.ky qemu-tech.log qemu-tech.pdf qemu-tech.pg qemu-tech.toc qemu-tech.tp qemu-tech.vr
 	for d in $(TARGET_DIRS); do \
-- 
2.7.4

Re: [Qemu-devel] [PATCH] build-sys: delete TAGS in distclean only

[Markus Armbruster]

marcandre.lureau@redhat.com writes:

> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> automake and other GNU build-sys generally keep TAGS file in make
> 'clean' rule and delete it only in 'distclean' (and 'mrproper' for
> linux). Do the same for qemu.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Reviewed-by: Markus Armbruster <armbru@redhat.com>

Cc'ing Paolo because I understand he already has some build system
patches queued.  If he doesn't want to take this one along, then try
qemu-trivial.