* i915: screen flicker @ 2016-04-26 21:46 Mihai Donțu 2016-04-27 7:09 ` Jani Nikula 0 siblings, 1 reply; 8+ messages in thread From: Mihai Donțu @ 2016-04-26 21:46 UTC (permalink / raw) To: Daniel Vetter; +Cc: dri-devel [-- Attachment #1: Type: text/plain, Size: 617 bytes --] Hi, I noticed that since I started using 4.6.0-rcX, my screen flickers once or twice after I stop using my laptop for ~1min or so. Given the behavior, my prime suspect is the PSR feature that you have announced for this release: http://blog.ffwll.ch/2016/03/neat-drmi915-stuff-for-46.html Is 'enable_psr' the right knob to use to turn this feature off and see if my suspicions are correct? Or is there a patch floating around that I can test? I have an Intel i7-4600U CPU. I also attached to this email and archive with the contents of /sys/kernel/debug/dri/0. Thank you, -- Mihai Donțu [-- Attachment #2: dri_0.tar.xz --] [-- Type: application/x-xz, Size: 87204 bytes --] [-- Attachment #3: Type: text/plain, Size: 160 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: i915: screen flicker 2016-04-26 21:46 i915: screen flicker Mihai Donțu @ 2016-04-27 7:09 ` Jani Nikula 2016-04-27 10:07 ` Mihai Donțu 0 siblings, 1 reply; 8+ messages in thread From: Jani Nikula @ 2016-04-27 7:09 UTC (permalink / raw) To: Mihai Donțu, Daniel Vetter; +Cc: dri-devel On Wed, 27 Apr 2016, Mihai Donțu <mihai.dontu@gmail.com> wrote: > Hi, > > I noticed that since I started using 4.6.0-rcX, my screen flickers once > or twice after I stop using my laptop for ~1min or so. Given the > behavior, my prime suspect is the PSR feature that you have announced > for this release: > > http://blog.ffwll.ch/2016/03/neat-drmi915-stuff-for-46.html > > Is 'enable_psr' the right knob to use to turn this feature off and see > if my suspicions are correct? Or is there a patch floating around that > I can test? i915.enable_psr=0 is the one to try, yes. BR, Jani. > > I have an Intel i7-4600U CPU. I also attached to this email and archive > with the contents of /sys/kernel/debug/dri/0. > > Thank you, -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: i915: screen flicker 2016-04-27 7:09 ` Jani Nikula @ 2016-04-27 10:07 ` Mihai Donțu 2016-04-27 10:35 ` Jani Nikula 0 siblings, 1 reply; 8+ messages in thread From: Mihai Donțu @ 2016-04-27 10:07 UTC (permalink / raw) To: Jani Nikula; +Cc: Daniel Vetter, dri-devel On Wed, 27 Apr 2016 10:09:32 +0300 Jani Nikula wrote: > On Wed, 27 Apr 2016, Mihai Donțu wrote: > > I noticed that since I started using 4.6.0-rcX, my screen flickers once > > or twice after I stop using my laptop for ~1min or so. Given the > > behavior, my prime suspect is the PSR feature that you have announced > > for this release: > > > > http://blog.ffwll.ch/2016/03/neat-drmi915-stuff-for-46.html > > > > Is 'enable_psr' the right knob to use to turn this feature off and see > > if my suspicions are correct? Or is there a patch floating around that > > I can test? > > i915.enable_psr=0 is the one to try, yes. I can confirm that with PSR off, the flicker goes away. > > I have an Intel i7-4600U CPU. I also attached to this email and archive > > with the contents of /sys/kernel/debug/dri/0. -- Mihai Donțu _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: i915: screen flicker 2016-04-27 10:07 ` Mihai Donțu @ 2016-04-27 10:35 ` Jani Nikula 2016-04-27 15:28 ` Rodrigo Vivi 0 siblings, 1 reply; 8+ messages in thread From: Jani Nikula @ 2016-04-27 10:35 UTC (permalink / raw) To: Mihai Donțu; +Cc: Daniel Vetter, dri-devel On Wed, 27 Apr 2016, Mihai Donțu <mihai.dontu@gmail.com> wrote: > On Wed, 27 Apr 2016 10:09:32 +0300 Jani Nikula wrote: >> On Wed, 27 Apr 2016, Mihai Donțu wrote: >> > I noticed that since I started using 4.6.0-rcX, my screen flickers once >> > or twice after I stop using my laptop for ~1min or so. Given the >> > behavior, my prime suspect is the PSR feature that you have announced >> > for this release: >> > >> > http://blog.ffwll.ch/2016/03/neat-drmi915-stuff-for-46.html >> > >> > Is 'enable_psr' the right knob to use to turn this feature off and see >> > if my suspicions are correct? Or is there a patch floating around that >> > I can test? >> >> i915.enable_psr=0 is the one to try, yes. > > I can confirm that with PSR off, the flicker goes away. Please file a bug at [1] and assign to Rodrigo (Cc'd). BR, Jani. [1] https://bugs.freedesktop.org/enter_bug.cgi?product=DRI&component=DRM/Intel -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: i915: screen flicker 2016-04-27 10:35 ` Jani Nikula @ 2016-04-27 15:28 ` Rodrigo Vivi 2016-04-27 17:36 ` Mihai Donțu 0 siblings, 1 reply; 8+ messages in thread From: Rodrigo Vivi @ 2016-04-27 15:28 UTC (permalink / raw) To: Jani Nikula, Pandiyan, Dhinakaran, Paulo Zanoni Cc: Daniel Vetter, DRI mailing list Hi Mihai, What platform do you have? HSW or BDW? If you don't know please provide lspci -nn What happens if you boot with i915.enable_psr=2? In case it helps, could you please boot with default i915.enable_psr=-1 appying this patch to your kernel to know what your VBT recommends: diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c index c3abae4..68bc405 100644 --- a/drivers/gpu/drm/i915/intel_psr.c +++ b/drivers/gpu/drm/i915/intel_psr.c @@ -798,6 +798,8 @@ void intel_psr_init(struct drm_device *dev) /* For new platforms let's respect VBT back again */ dev_priv->psr.link_standby = dev_priv->vbt.psr.full_link; + DRM_ERROR("PSR: VBT recommends link_standby %d, using %d\n", dev_priv->vbt.psr.full_link, dev_priv->psr.link_standby); + /* Override link_standby x link_off defaults */ if (i915.enable_psr == 2 && !dev_priv->psr.link_standby) { DRM_DEBUG_KMS("PSR: Forcing link standby\n"); //Thanks //Rodrigo. On Wed, Apr 27, 2016 at 3:35 AM, Jani Nikula <jani.nikula@linux.intel.com> wrote: > On Wed, 27 Apr 2016, Mihai Donțu <mihai.dontu@gmail.com> wrote: >> On Wed, 27 Apr 2016 10:09:32 +0300 Jani Nikula wrote: >>> On Wed, 27 Apr 2016, Mihai Donțu wrote: >>> > I noticed that since I started using 4.6.0-rcX, my screen flickers once >>> > or twice after I stop using my laptop for ~1min or so. Given the >>> > behavior, my prime suspect is the PSR feature that you have announced >>> > for this release: >>> > >>> > http://blog.ffwll.ch/2016/03/neat-drmi915-stuff-for-46.html >>> > >>> > Is 'enable_psr' the right knob to use to turn this feature off and see >>> > if my suspicions are correct? Or is there a patch floating around that >>> > I can test? >>> >>> i915.enable_psr=0 is the one to try, yes. >> >> I can confirm that with PSR off, the flicker goes away. > > Please file a bug at [1] and assign to Rodrigo (Cc'd). > > BR, > Jani. > > [1] https://bugs.freedesktop.org/enter_bug.cgi?product=DRI&component=DRM/Intel > > > -- > Jani Nikula, Intel Open Source Technology Center -- Rodrigo Vivi Blog: http://blog.vivi.eng.br _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: i915: screen flicker 2016-04-27 15:28 ` Rodrigo Vivi @ 2016-04-27 17:36 ` Mihai Donțu 2016-04-27 17:42 ` Mihai Donțu 0 siblings, 1 reply; 8+ messages in thread From: Mihai Donțu @ 2016-04-27 17:36 UTC (permalink / raw) To: Rodrigo Vivi; +Cc: dri-devel, Daniel Vetter, Pandiyan, Dhinakaran [-- Attachment #1: Type: text/plain, Size: 1402 bytes --] On Wed, 27 Apr 2016 08:28:20 -0700 Rodrigo Vivi wrote: > Hi Mihai, > > What platform do you have? HSW or BDW? I have an i7, Haswell CPU. > If you don't know please provide lspci -nn I have attached the output of lspci, just in case. :-) > What happens if you boot with i915.enable_psr=2? I'll try now. > In case it helps, could you please boot with default > i915.enable_psr=-1 appying this patch to your kernel to know what your > VBT recommends: > diff --git a/drivers/gpu/drm/i915/intel_psr.c > b/drivers/gpu/drm/i915/intel_psr.c > index c3abae4..68bc405 100644 > --- a/drivers/gpu/drm/i915/intel_psr.c > +++ b/drivers/gpu/drm/i915/intel_psr.c > @@ -798,6 +798,8 @@ void intel_psr_init(struct drm_device *dev) > /* For new platforms let's respect VBT back again */ > dev_priv->psr.link_standby = > dev_priv->vbt.psr.full_link; > > + DRM_ERROR("PSR: VBT recommends link_standby %d, using %d\n", > dev_priv->vbt.psr.full_link, dev_priv->psr.link_standby); > + > /* Override link_standby x link_off defaults */ > if (i915.enable_psr == 2 && !dev_priv->psr.link_standby) { > DRM_DEBUG_KMS("PSR: Forcing link standby\n"); > I applied your patch and booted with enable_psr=-1 [ 0.763651] [drm:intel_psr_init] *ERROR* PSR: VBT recommends link_standby 0, using 0 -- Mihai Donțu [-- Attachment #2: lspci.txt --] [-- Type: text/plain, Size: 1461 bytes --] 00:00.0 Host bridge [0600]: Intel Corporation Haswell-ULT DRAM Controller [8086:0a04] (rev 0b) 00:02.0 VGA compatible controller [0300]: Intel Corporation Haswell-ULT Integrated Graphics Controller [8086:0a16] (rev 0b) 00:03.0 Audio device [0403]: Intel Corporation Haswell-ULT HD Audio Controller [8086:0a0c] (rev 0b) 00:14.0 USB controller [0c03]: Intel Corporation 8 Series USB xHCI HC [8086:9c31] (rev 04) 00:16.0 Communication controller [0780]: Intel Corporation 8 Series HECI #0 [8086:9c3a] (rev 04) 00:16.3 Serial controller [0700]: Intel Corporation 8 Series HECI KT [8086:9c3d] (rev 04) 00:19.0 Ethernet controller [0200]: Intel Corporation Ethernet Connection I218-LM [8086:155a] (rev 04) 00:1b.0 Audio device [0403]: Intel Corporation 8 Series HD Audio Controller [8086:9c20] (rev 04) 00:1c.0 PCI bridge [0604]: Intel Corporation 8 Series PCI Express Root Port 1 [8086:9c10] (rev e4) 00:1c.3 PCI bridge [0604]: Intel Corporation 8 Series PCI Express Root Port 4 [8086:9c16] (rev e4) 00:1d.0 USB controller [0c03]: Intel Corporation 8 Series USB EHCI #1 [8086:9c26] (rev 04) 00:1f.0 ISA bridge [0601]: Intel Corporation 8 Series LPC Controller [8086:9c43] (rev 04) 00:1f.2 SATA controller [0106]: Intel Corporation 8 Series SATA Controller 1 [AHCI mode] [8086:9c03] (rev 04) 00:1f.3 SMBus [0c05]: Intel Corporation 8 Series SMBus Controller [8086:9c22] (rev 04) 02:00.0 Network controller [0280]: Intel Corporation Wireless 7260 [8086:08b1] (rev 73) [-- Attachment #3: Type: text/plain, Size: 160 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: i915: screen flicker 2016-04-27 17:36 ` Mihai Donțu @ 2016-04-27 17:42 ` Mihai Donțu 2016-04-28 8:02 ` Jani Nikula 0 siblings, 1 reply; 8+ messages in thread From: Mihai Donțu @ 2016-04-27 17:42 UTC (permalink / raw) To: Rodrigo Vivi; +Cc: dri-devel, Daniel Vetter, Pandiyan, Dhinakaran On Wed, 27 Apr 2016 20:36:13 +0300 Mihai Donțu wrote: > On Wed, 27 Apr 2016 08:28:20 -0700 Rodrigo Vivi wrote: > > Hi Mihai, > > > > What platform do you have? HSW or BDW? > > I have an i7, Haswell CPU. > > > If you don't know please provide lspci -nn > > I have attached the output of lspci, just in case. :-) > > > What happens if you boot with i915.enable_psr=2? > > I'll try now. The behaviour is worse now. The screen flickers every couple of seconds. > > In case it helps, could you please boot with default > > i915.enable_psr=-1 appying this patch to your kernel to know what your > > VBT recommends: > > diff --git a/drivers/gpu/drm/i915/intel_psr.c > > b/drivers/gpu/drm/i915/intel_psr.c > > index c3abae4..68bc405 100644 > > --- a/drivers/gpu/drm/i915/intel_psr.c > > +++ b/drivers/gpu/drm/i915/intel_psr.c > > @@ -798,6 +798,8 @@ void intel_psr_init(struct drm_device *dev) > > /* For new platforms let's respect VBT back again */ > > dev_priv->psr.link_standby = > > dev_priv->vbt.psr.full_link; > > > > + DRM_ERROR("PSR: VBT recommends link_standby %d, using %d\n", > > dev_priv->vbt.psr.full_link, dev_priv->psr.link_standby); > > + > > /* Override link_standby x link_off defaults */ > > if (i915.enable_psr == 2 && !dev_priv->psr.link_standby) { > > DRM_DEBUG_KMS("PSR: Forcing link standby\n"); > > > > I applied your patch and booted with enable_psr=-1 > > [ 0.763651] [drm:intel_psr_init] *ERROR* PSR: VBT recommends link_standby 0, using 0 -- Mihai Donțu _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: i915: screen flicker 2016-04-27 17:42 ` Mihai Donțu @ 2016-04-28 8:02 ` Jani Nikula 0 siblings, 0 replies; 8+ messages in thread From: Jani Nikula @ 2016-04-28 8:02 UTC (permalink / raw) To: Mihai Donțu, Rodrigo Vivi Cc: Daniel Vetter, Pandiyan, Dhinakaran, dri-devel On Wed, 27 Apr 2016, Mihai Donțu <mihai.dontu@gmail.com> wrote: > On Wed, 27 Apr 2016 20:36:13 +0300 Mihai Donțu wrote: >> On Wed, 27 Apr 2016 08:28:20 -0700 Rodrigo Vivi wrote: >> > Hi Mihai, >> > >> > What platform do you have? HSW or BDW? >> >> I have an i7, Haswell CPU. >> >> > If you don't know please provide lspci -nn >> >> I have attached the output of lspci, just in case. :-) >> >> > What happens if you boot with i915.enable_psr=2? >> >> I'll try now. > > The behaviour is worse now. The screen flickers every couple of seconds. Another report, please move the discussion there: https://bugs.freedesktop.org/show_bug.cgi?id=95176 Thanks, Jani. > >> > In case it helps, could you please boot with default >> > i915.enable_psr=-1 appying this patch to your kernel to know what your >> > VBT recommends: >> > diff --git a/drivers/gpu/drm/i915/intel_psr.c >> > b/drivers/gpu/drm/i915/intel_psr.c >> > index c3abae4..68bc405 100644 >> > --- a/drivers/gpu/drm/i915/intel_psr.c >> > +++ b/drivers/gpu/drm/i915/intel_psr.c >> > @@ -798,6 +798,8 @@ void intel_psr_init(struct drm_device *dev) >> > /* For new platforms let's respect VBT back again */ >> > dev_priv->psr.link_standby = >> > dev_priv->vbt.psr.full_link; >> > >> > + DRM_ERROR("PSR: VBT recommends link_standby %d, using %d\n", >> > dev_priv->vbt.psr.full_link, dev_priv->psr.link_standby); >> > + >> > /* Override link_standby x link_off defaults */ >> > if (i915.enable_psr == 2 && !dev_priv->psr.link_standby) { >> > DRM_DEBUG_KMS("PSR: Forcing link standby\n"); >> > >> >> I applied your patch and booted with enable_psr=-1 >> >> [ 0.763651] [drm:intel_psr_init] *ERROR* PSR: VBT recommends link_standby 0, using 0 -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-04-28 8:02 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-04-26 21:46 i915: screen flicker Mihai Donțu 2016-04-27 7:09 ` Jani Nikula 2016-04-27 10:07 ` Mihai Donțu 2016-04-27 10:35 ` Jani Nikula 2016-04-27 15:28 ` Rodrigo Vivi 2016-04-27 17:36 ` Mihai Donțu 2016-04-27 17:42 ` Mihai Donțu 2016-04-28 8:02 ` Jani Nikula
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.