All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] python-crossbar: propagate missing dependencies
@ 2016-03-10 20:16 Thomas Petazzoni
  2016-03-10 20:16 ` [Buildroot] [PATCH 2/2] python-msgpack: remove useless 'depends on' in comment Thomas Petazzoni
  2016-03-10 21:33 ` [Buildroot] [PATCH 1/2] python-crossbar: propagate missing dependencies Peter Korsgaard
  0 siblings, 2 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2016-03-10 20:16 UTC (permalink / raw)
  To: buildroot

python-crossbar selects python-msgpack which selects msgpack, which
depends on C++ and 4-byte __sync intrinsics. But python-crossbar does
not have the dependencies propagated.

Fixes:

  http://autobuild.buildroot.org/results/80f58b7264139dd82c690cb8aae97349aa412539/

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/python-crossbar/Config.in | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/package/python-crossbar/Config.in b/package/python-crossbar/Config.in
index 84c65c1..4e613db 100644
--- a/package/python-crossbar/Config.in
+++ b/package/python-crossbar/Config.in
@@ -29,9 +29,15 @@ config BR2_PACKAGE_PYTHON_CROSSBAR
 	select BR2_PACKAGE_PYTHON_TWISTED
 	select BR2_PACKAGE_PYTHON_UJSON
 	select BR2_PACKAGE_PYTHON_WSACCEL
+	depends on BR2_INSTALL_LIBSTDCPP # python-msgpack -> msgpack
+	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # python-msgpack -> msgpack
 	help
 	  Crossbar.io is an open-source WAMP application router that
 	  allows to build advanced applications from loosely-coupled
 	  components that can talk in real-time with each other.
 
 	  https://pypi.python.org/pypi/crossbar
+
+comment "python-crossbar needs a toolchain w/ C++"
+	depends on BR2_TOOLCHAIN_HAS_SYNC_4
+	depends on !BR2_INSTALL_LIBSTDCPP
-- 
2.6.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 2/2] python-msgpack: remove useless 'depends on' in comment
  2016-03-10 20:16 [Buildroot] [PATCH 1/2] python-crossbar: propagate missing dependencies Thomas Petazzoni
@ 2016-03-10 20:16 ` Thomas Petazzoni
  2016-03-10 21:33   ` Peter Korsgaard
  2016-03-10 21:33 ` [Buildroot] [PATCH 1/2] python-crossbar: propagate missing dependencies Peter Korsgaard
  1 sibling, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2016-03-10 20:16 UTC (permalink / raw)
  To: buildroot

In commit 6709fad224692ae5e0788bbd30145f7d622b52a4, python-msgpack was
bumped to a new version that has support for Python 3. The "depends on
BR2_PACKAGE_PYTHON' was removed for the main python-msgpack Config.in
option, but not from the comment. This commit fixes this
inconsistency.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/python-msgpack/Config.in | 1 -
 1 file changed, 1 deletion(-)

diff --git a/package/python-msgpack/Config.in b/package/python-msgpack/Config.in
index 7206c22..7dfe8e8 100644
--- a/package/python-msgpack/Config.in
+++ b/package/python-msgpack/Config.in
@@ -13,5 +13,4 @@ config BR2_PACKAGE_PYTHON_MSGPACK
 
 comment "python-msgpack needs a toolchain w/ C++"
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4
-	depends on BR2_PACKAGE_PYTHON
 	depends on !BR2_INSTALL_LIBSTDCPP
-- 
2.6.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 1/2] python-crossbar: propagate missing dependencies
  2016-03-10 20:16 [Buildroot] [PATCH 1/2] python-crossbar: propagate missing dependencies Thomas Petazzoni
  2016-03-10 20:16 ` [Buildroot] [PATCH 2/2] python-msgpack: remove useless 'depends on' in comment Thomas Petazzoni
@ 2016-03-10 21:33 ` Peter Korsgaard
  1 sibling, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2016-03-10 21:33 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > python-crossbar selects python-msgpack which selects msgpack, which
 > depends on C++ and 4-byte __sync intrinsics. But python-crossbar does
 > not have the dependencies propagated.

 > Fixes:

 >   http://autobuild.buildroot.org/results/80f58b7264139dd82c690cb8aae97349aa412539/

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 2/2] python-msgpack: remove useless 'depends on' in comment
  2016-03-10 20:16 ` [Buildroot] [PATCH 2/2] python-msgpack: remove useless 'depends on' in comment Thomas Petazzoni
@ 2016-03-10 21:33   ` Peter Korsgaard
  0 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2016-03-10 21:33 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > In commit 6709fad224692ae5e0788bbd30145f7d622b52a4, python-msgpack was
 > bumped to a new version that has support for Python 3. The "depends on
 > BR2_PACKAGE_PYTHON' was removed for the main python-msgpack Config.in
 > option, but not from the comment. This commit fixes this
 > inconsistency.

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-03-10 21:33 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-10 20:16 [Buildroot] [PATCH 1/2] python-crossbar: propagate missing dependencies Thomas Petazzoni
2016-03-10 20:16 ` [Buildroot] [PATCH 2/2] python-msgpack: remove useless 'depends on' in comment Thomas Petazzoni
2016-03-10 21:33   ` Peter Korsgaard
2016-03-10 21:33 ` [Buildroot] [PATCH 1/2] python-crossbar: propagate missing dependencies Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.