spi-bcm2835 depends GPIOLIB

spi-bcm2835 depends GPIOLIB

[Yoshinori Sato]

I got following error on CONFIG_GPIOLIB=n.

drivers/spi/spi-bcm2835.c: In function 'chip_match_name':
drivers/spi/spi-bcm2835.c:356:21: error: dereferencing pointer to incomplete type 'struct gpio_chip'
  return !strcmp(chip->label, data);
                     ^
drivers/spi/spi-bcm2835.c: In function 'bcm2835_spi_setup':
drivers/spi/spi-bcm2835.c:382:9: error: implicit declaration of function 'gpiochip_find' [-Werror=implicit-function-declaration]
  chip = gpiochip_find("pinctrl-bcm2835", chip_match_name);
         ^
drivers/spi/spi-bcm2835.c:382:7: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
  chip = gpiochip_find("pinctrl-bcm2835", chip_match_name);
       ^
drivers/spi/spi-bcm2835.c: In function 'chip_match_name':
drivers/spi/spi-bcm2835.c:357:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^

Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index 198f96b..d5ed2a0 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -77,6 +77,7 @@ config SPI_ATMEL
 
 config SPI_BCM2835
 	tristate "BCM2835 SPI controller"
+	depends on GPIOLIB
 	depends on ARCH_BCM2835 || COMPILE_TEST
 	help
 	  This selects a driver for the Broadcom BCM2835 SPI master.

-- 
Yoshinori Sato
<ysato@users.sourceforge.jp>

Re: spi-bcm2835 depends GPIOLIB

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

On Mon, May 04, 2015 at 12:16:36AM +0900, Yoshinori Sato wrote:
> I got following error on CONFIG_GPIOLIB=n.

Applied, thanks, but please use subject lines reflecting the style for
the subsystem.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: spi-bcm2835 depends GPIOLIB

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

On Mon, May 04, 2015 at 12:16:36AM +0900, Yoshinori Sato wrote:
> I got following error on CONFIG_GPIOLIB=n.

Applied, thanks, but please use subject lines reflecting the style for
the subsystem.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: spi-bcm2835 depends GPIOLIB

[Yoshinori Sato]

At Mon, 4 May 2015 13:00:46 +0100,
Mark Brown wrote:
> 
> On Mon, May 04, 2015 at 12:16:36AM +0900, Yoshinori Sato wrote:
> > I got following error on CONFIG_GPIOLIB=n.
> 
> Applied, thanks, but please use subject lines reflecting the style for
> the subsystem.

Oh. I'm sorry.
Thanks applied.

-- 
Yoshinori Sato
<ysato-Rn4VEauK+AKRv+LV9MX5uooqe+aC9MnS@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: spi-bcm2835 depends GPIOLIB

[Yoshinori Sato]

At Mon, 4 May 2015 13:00:46 +0100,
Mark Brown wrote:
> 
> On Mon, May 04, 2015 at 12:16:36AM +0900, Yoshinori Sato wrote:
> > I got following error on CONFIG_GPIOLIB=n.
> 
> Applied, thanks, but please use subject lines reflecting the style for
> the subsystem.

Oh. I'm sorry.
Thanks applied.

-- 
Yoshinori Sato
<ysato@users.sourceforge.jp>