From: robert.jarzmik@free.fr (Robert Jarzmik)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] net: smc91x: use run-time configuration on all ARM machines
Date: Sat, 28 Feb 2015 17:50:46 +0100 [thread overview]
Message-ID: <877fv22d5l.fsf@free.fr> (raw)
In-Reply-To: <2226303.iMQTNXSl1n@wuerfel> (Arnd Bergmann's message of "Wed, 25 Feb 2015 16:31:57 +0100")
Arnd Bergmann <arnd@arndb.de> writes:
> The smc91x driver traditionally gets configured at compile-time
> for whichever hardware it runs on. This no longer works on
> ARM as we continue to move to building all-in-one kernels.
>
> Most ARM configurations with this driver already use run-time
> configuration through DT or through platform_data, but a
> few have not been converted yet.
>
> I've checked all ARM boards that use this driver in their
> legacy board files, and converted the ones that were using
> compile-time configuration in smc91x.h to behave like the
> other ones and provide the interrupt polarity along with
> the MMIO configuration (width, stride) at platform device
> creation time.
>
> In particular, these combinations were previously selectable
> in Kconfig but in fact broken:
>
> - sa1100 assabet plus pleb
> - msm combined with any other armv6/v7 platform
> - pxa-idp combined with any non-DMA pxa variant
> - LogicPD PXA270 combined with any other pxa
> - nomadik combined with any other armv4/v5 platform,
> e.g. versatile.
>
> None of these seem critical enough to warrant a backport
> to stable, but it would be nice to clean this up for good.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ----
> I would like the patch to get merged through netdev, after
> Robert and/or Linus have verified it on at least some hardware.
For lubbock (smcs 91c96) and zylonite (smcs 91c111) :
Tested-by: Robert Jarzmik <robert.jarzmik@free.fr>
Cheers.
--
Robert
PS: My mainstone is a bit uncooperative right now, I'll have to convince her to
boot in the near future ...
WARNING: multiple messages have this Message-ID (diff)
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Arnd Bergmann <arnd@arndb.de>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
Linus Walleij <linus.walleij@linaro.org>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] net: smc91x: use run-time configuration on all ARM machines
Date: Sat, 28 Feb 2015 17:50:46 +0100 [thread overview]
Message-ID: <877fv22d5l.fsf@free.fr> (raw)
In-Reply-To: <2226303.iMQTNXSl1n@wuerfel> (Arnd Bergmann's message of "Wed, 25 Feb 2015 16:31:57 +0100")
Arnd Bergmann <arnd@arndb.de> writes:
> The smc91x driver traditionally gets configured at compile-time
> for whichever hardware it runs on. This no longer works on
> ARM as we continue to move to building all-in-one kernels.
>
> Most ARM configurations with this driver already use run-time
> configuration through DT or through platform_data, but a
> few have not been converted yet.
>
> I've checked all ARM boards that use this driver in their
> legacy board files, and converted the ones that were using
> compile-time configuration in smc91x.h to behave like the
> other ones and provide the interrupt polarity along with
> the MMIO configuration (width, stride) at platform device
> creation time.
>
> In particular, these combinations were previously selectable
> in Kconfig but in fact broken:
>
> - sa1100 assabet plus pleb
> - msm combined with any other armv6/v7 platform
> - pxa-idp combined with any non-DMA pxa variant
> - LogicPD PXA270 combined with any other pxa
> - nomadik combined with any other armv4/v5 platform,
> e.g. versatile.
>
> None of these seem critical enough to warrant a backport
> to stable, but it would be nice to clean this up for good.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ----
> I would like the patch to get merged through netdev, after
> Robert and/or Linus have verified it on at least some hardware.
For lubbock (smcs 91c96) and zylonite (smcs 91c111) :
Tested-by: Robert Jarzmik <robert.jarzmik@free.fr>
Cheers.
--
Robert
PS: My mainstone is a bit uncooperative right now, I'll have to convince her to
boot in the near future ...
next prev parent reply other threads:[~2015-02-28 16:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 15:31 [PATCH] net: smc91x: use run-time configuration on all ARM machines Arnd Bergmann
2015-02-25 15:31 ` Arnd Bergmann
2015-02-28 16:50 ` Robert Jarzmik [this message]
2015-02-28 16:50 ` Robert Jarzmik
2015-02-28 17:57 ` David Miller
2015-02-28 17:57 ` David Miller
2015-03-04 22:36 ` Arnd Bergmann
2015-03-04 22:36 ` Arnd Bergmann
2015-03-04 22:39 ` [PATCH] ARM: fix typos in smc91x platform data Arnd Bergmann
2015-03-04 22:39 ` Arnd Bergmann
2015-03-05 4:33 ` David Miller
2015-03-05 4:33 ` David Miller
2015-03-05 9:06 ` [PATCH] net: smc91x: use run-time configuration on all ARM machines Russell King - ARM Linux
2015-03-05 9:06 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fv22d5l.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.