From: Juan Quintela <quintela@redhat.com>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: amit.shah@redhat.com, qemu-ppc@nongnu.org,
Alexander Graf <agraf@suse.de>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] openpic: convert to vmstate
Date: Mon, 09 Feb 2015 14:50:03 +0100 [thread overview]
Message-ID: <877fvr19f8.fsf@neno.neno> (raw)
In-Reply-To: <54D8B58C.3020404@ilande.co.uk> (Mark Cave-Ayland's message of "Mon, 09 Feb 2015 13:26:36 +0000")
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> wrote:
> On 09/02/15 12:43, Alexander Graf wrote:
> Ha! I did actually do this but I accidentally messed up a rebase just
> before sending out the patchset so it got lost. But yes, I agree a
> version bump to 3 should be sufficient here.
>
> Just to put this in context: before the PPC loadvm/savevm patchset was
> posted to the list, I was bisecting down to around the 0.10-0.11
> timeframe to figure out where things broke, and even then the Mac
> machines wouldn't run correctly after loadvm. So I agree with Alex that
> any snapshots this old would be useless anyway.
>
> Based upon this, are there any other changes you would like before a respin?
I didn't knew that it was completely broken (TM).
As said in a different email, I think that using the _EQUAL() macro for
nb_cpus is a good idea. For the rest, I agree with it.
Later, Juan.
next prev parent reply other threads:[~2015-02-09 13:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-06 14:36 [Qemu-devel] [PATCH 0/2] openpic: convert to vmstate Mark Cave-Ayland
2015-02-06 14:36 ` [Qemu-devel] [PATCH 1/2] openpic: switch IRQQueue queue from inline to bitmap Mark Cave-Ayland
2015-02-06 14:36 ` [Qemu-devel] [PATCH 2/2] openpic: convert to vmstate Mark Cave-Ayland
2015-02-09 12:39 ` Juan Quintela
2015-02-09 12:43 ` [Qemu-devel] [Qemu-ppc] " Alexander Graf
2015-02-09 13:26 ` Mark Cave-Ayland
2015-02-09 13:50 ` Juan Quintela [this message]
2015-02-09 20:05 ` Mark Cave-Ayland
2015-02-09 13:47 ` Juan Quintela
2015-02-09 13:48 ` Juan Quintela
2015-02-06 14:51 ` [Qemu-devel] [Qemu-ppc] [PATCH 0/2] " Alexander Graf
2015-02-06 15:41 ` Mark Cave-Ayland
2015-02-11 11:51 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fvr19f8.fsf@neno.neno \
--to=quintela@redhat.com \
--cc=agraf@suse.de \
--cc=amit.shah@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.