From: Markus Armbruster <armbru@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 0/3] qmp: Add "blockdev-backup"
Date: Wed, 17 Dec 2014 11:44:51 +0100 [thread overview]
Message-ID: <877fxqv9lo.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <1415156231-6319-1-git-send-email-famz@redhat.com> (Fam Zheng's message of "Wed, 5 Nov 2014 10:57:08 +0800")
Fam Zheng <famz@redhat.com> writes:
> v3: Address Eric's comments on documentation.
> Squashed 3/4 into 2/4.
>
> v2: Address Markus' and Eric's comments:
> Fix qapi schema documentation.
> Fix versioning of transactions.
> Improve test case code by dropping inelegnet bool.
>
> The existing drive-backup command accepts a target file path, but that
> interface provides little flexibility on the properties of target block device,
> compared to what is possible with "blockdev-add", "drive_add" or "-drive".
>
> This is also a building block to allow image fleecing (creating a point in time
> snapshot and export with nbd-server-add).
>
> (For symmetry, blockdev-mirror will be added in a separate series.)
Trivial typos/pastos in PATCH 1, and a question on GenericError. If you
address these, you can add my R-by.
prev parent reply other threads:[~2014-12-17 10:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-05 2:57 [Qemu-devel] [PATCH v3 0/3] qmp: Add "blockdev-backup" Fam Zheng
2014-11-05 2:57 ` [Qemu-devel] [PATCH v3 1/3] qmp: Add command 'blockdev-backup' Fam Zheng
2014-11-19 16:23 ` Stefan Hajnoczi
2014-12-17 9:36 ` Markus Armbruster
2014-12-17 10:41 ` Fam Zheng
2014-12-19 8:20 ` Markus Armbruster
2014-12-23 2:10 ` Fam Zheng
2014-11-05 2:57 ` [Qemu-devel] [PATCH v3 2/3] block: Add blockdev-backup to transaction Fam Zheng
2014-12-17 9:40 ` Markus Armbruster
2014-12-17 10:44 ` Fam Zheng
2014-11-05 2:57 ` [Qemu-devel] [PATCH v3 3/3] qemu-iotests: Test blockdev-backup in 055 Fam Zheng
2014-12-17 10:41 ` Markus Armbruster
2014-12-17 10:44 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fxqv9lo.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.