All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH v3 5/8] ath10k: batch htt tx/rx completions
Date: Fri, 28 Feb 2014 11:00:43 +0200	[thread overview]
Message-ID: <877g8fd32c.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1393485587-16879-6-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Thu, 27 Feb 2014 08:19:44 +0100")

Michal Kazior <michal.kazior@tieto.com> writes:

> HTT Rx endpoint processes both frame rx
> indications and frame tx completion indications.
>
> Those completions typically come in batches and
> may be mixed so it makes sense to defer processing
> hoping to get a bunch of them and take advantage
> of hot caches.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>

[...]

> +void ath10k_htt_txrx_compl_task(unsigned long ptr)
> +{
> +	struct ath10k_htt *htt = (struct ath10k_htt *)ptr;
> +	struct htt_resp *resp;
> +	struct sk_buff *skb;

I think this can be a static function. Is it ok if I change this patch
with the diff below?

--- a/drivers/net/wireless/ath/ath10k/htt.h
+++ b/drivers/net/wireless/ath/ath10k/htt.h
@@ -1360,6 +1360,5 @@ int ath10k_htt_tx_alloc_msdu_id(struct ath10k_htt *htt);
 void ath10k_htt_tx_free_msdu_id(struct ath10k_htt *htt, u16 msdu_id);
 int ath10k_htt_mgmt_tx(struct ath10k_htt *htt, struct sk_buff *);
 int ath10k_htt_tx(struct ath10k_htt *htt, struct sk_buff *);
-void ath10k_htt_txrx_compl_task(unsigned long ptr);
 
 #endif
diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
index e362358240e8..3a02e654d871 100644
--- a/drivers/net/wireless/ath/ath10k/htt_rx.c
+++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
@@ -43,7 +43,7 @@
 
 
 static int ath10k_htt_rx_get_csum_state(struct sk_buff *skb);
-
+static void ath10k_htt_txrx_compl_task(unsigned long ptr);
 
 static int ath10k_htt_rx_ring_size(struct ath10k_htt *htt)
 {
@@ -1347,7 +1347,7 @@ void ath10k_htt_t2h_msg_handler(struct ath10k *ar, struct sk_buff *skb)
 	dev_kfree_skb_any(skb);
 }
 
-void ath10k_htt_txrx_compl_task(unsigned long ptr)
+static void ath10k_htt_txrx_compl_task(unsigned long ptr)
 {
 	struct ath10k_htt *htt = (struct ath10k_htt *)ptr;
 	struct htt_resp *resp;


-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v3 5/8] ath10k: batch htt tx/rx completions
Date: Fri, 28 Feb 2014 11:00:43 +0200	[thread overview]
Message-ID: <877g8fd32c.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1393485587-16879-6-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Thu, 27 Feb 2014 08:19:44 +0100")

Michal Kazior <michal.kazior@tieto.com> writes:

> HTT Rx endpoint processes both frame rx
> indications and frame tx completion indications.
>
> Those completions typically come in batches and
> may be mixed so it makes sense to defer processing
> hoping to get a bunch of them and take advantage
> of hot caches.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>

[...]

> +void ath10k_htt_txrx_compl_task(unsigned long ptr)
> +{
> +	struct ath10k_htt *htt = (struct ath10k_htt *)ptr;
> +	struct htt_resp *resp;
> +	struct sk_buff *skb;

I think this can be a static function. Is it ok if I change this patch
with the diff below?

--- a/drivers/net/wireless/ath/ath10k/htt.h
+++ b/drivers/net/wireless/ath/ath10k/htt.h
@@ -1360,6 +1360,5 @@ int ath10k_htt_tx_alloc_msdu_id(struct ath10k_htt *htt);
 void ath10k_htt_tx_free_msdu_id(struct ath10k_htt *htt, u16 msdu_id);
 int ath10k_htt_mgmt_tx(struct ath10k_htt *htt, struct sk_buff *);
 int ath10k_htt_tx(struct ath10k_htt *htt, struct sk_buff *);
-void ath10k_htt_txrx_compl_task(unsigned long ptr);
 
 #endif
diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
index e362358240e8..3a02e654d871 100644
--- a/drivers/net/wireless/ath/ath10k/htt_rx.c
+++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
@@ -43,7 +43,7 @@
 
 
 static int ath10k_htt_rx_get_csum_state(struct sk_buff *skb);
-
+static void ath10k_htt_txrx_compl_task(unsigned long ptr);
 
 static int ath10k_htt_rx_ring_size(struct ath10k_htt *htt)
 {
@@ -1347,7 +1347,7 @@ void ath10k_htt_t2h_msg_handler(struct ath10k *ar, struct sk_buff *skb)
 	dev_kfree_skb_any(skb);
 }
 
-void ath10k_htt_txrx_compl_task(unsigned long ptr)
+static void ath10k_htt_txrx_compl_task(unsigned long ptr)
 {
 	struct ath10k_htt *htt = (struct ath10k_htt *)ptr;
 	struct htt_resp *resp;


-- 
Kalle Valo

  reply	other threads:[~2014-02-28  9:01 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-17  9:32 [RFC/RFT 0/7] ath10k: performance improvements Michal Kazior
2014-02-17  9:32 ` Michal Kazior
2014-02-17  9:32 ` [RFC/RFT 1/7] ath10k: remove DMA mapping wrappers Michal Kazior
2014-02-17  9:32   ` Michal Kazior
2014-02-19 12:37   ` Kalle Valo
2014-02-19 12:37     ` Kalle Valo
2014-02-17  9:32 ` [RFC/RFT 2/7] ath10k: remove is_aborted from skb_cb Michal Kazior
2014-02-17  9:32   ` Michal Kazior
2014-02-17  9:32 ` [RFC/RFT 3/7] ath10k: replace send_head() with tx_sg() Michal Kazior
2014-02-17  9:32   ` Michal Kazior
2014-02-19 12:48   ` Kalle Valo
2014-02-19 12:48     ` Kalle Valo
2014-02-19 13:25     ` Michal Kazior
2014-02-19 13:25       ` Michal Kazior
2014-02-19 14:18       ` Kalle Valo
2014-02-19 14:18         ` Kalle Valo
2014-02-20  6:43         ` Michal Kazior
2014-02-20  6:43           ` Michal Kazior
2014-02-24 11:46           ` Kalle Valo
2014-02-24 11:46             ` Kalle Valo
2014-02-17  9:32 ` [RFC/RFT 4/7] ath10k: bypass htc for htt tx path Michal Kazior
2014-02-17  9:32   ` Michal Kazior
2014-02-19 14:56   ` Kalle Valo
2014-02-19 14:56     ` Kalle Valo
2014-02-17  9:32 ` [RFC/RFT 5/7] ath10k: batch htt tx/rx completions Michal Kazior
2014-02-17  9:32   ` Michal Kazior
2014-02-19 15:10   ` Kalle Valo
2014-02-19 15:10     ` Kalle Valo
2014-02-20 11:23     ` Michal Kazior
2014-02-20 11:23       ` Michal Kazior
2014-02-24 11:49       ` Kalle Valo
2014-02-24 11:49         ` Kalle Valo
2014-02-17  9:32 ` [RFC/RFT 6/7] ath10k: remove pci completion list Michal Kazior
2014-02-17  9:32   ` Michal Kazior
2014-02-17  9:32 ` [RFC/RFT 7/7] ath10k: minimize coherent dma accesses Michal Kazior
2014-02-17  9:32   ` Michal Kazior
2014-02-17 15:01 ` [RFC/RFT 0/7] ath10k: performance improvements Kalle Valo
2014-02-17 15:01   ` Kalle Valo
2014-02-19 15:16 ` Kalle Valo
2014-02-19 15:16   ` Kalle Valo
2014-02-26 11:34 ` [PATCH v2 0/8] " Michal Kazior
2014-02-26 11:34   ` Michal Kazior
2014-02-26 11:34   ` [PATCH v2 1/8] ath10k: remove DMA mapping wrappers Michal Kazior
2014-02-26 11:34     ` Michal Kazior
2014-02-26 11:34   ` [PATCH v2 2/8] ath10k: remove is_aborted from skb_cb Michal Kazior
2014-02-26 11:34     ` Michal Kazior
2014-02-26 12:09   ` [PATCH v2 0/8] ath10k: performance improvements Michal Kazior
2014-02-26 12:09     ` Michal Kazior
2014-02-27  7:19 ` [PATCH v3 " Michal Kazior
2014-02-27  7:19   ` Michal Kazior
2014-02-27  7:19   ` [PATCH v3 1/8] ath10k: remove DMA mapping wrappers Michal Kazior
2014-02-27  7:19     ` Michal Kazior
2014-02-27  7:19   ` [PATCH v3 2/8] ath10k: remove is_aborted from skb_cb Michal Kazior
2014-02-27  7:19     ` Michal Kazior
2014-02-27  7:19   ` [PATCH v3 3/8] ath10k: replace send_head() with tx_sg() Michal Kazior
2014-02-27  7:19     ` Michal Kazior
2014-02-27  7:19   ` [PATCH v3 4/8] ath10k: bypass htc for htt tx path Michal Kazior
2014-02-27  7:19     ` Michal Kazior
2014-02-28  9:06     ` Kalle Valo
2014-02-28  9:06       ` Kalle Valo
2014-02-28  9:15       ` Michal Kazior
2014-02-28  9:15         ` Michal Kazior
2014-02-28  9:28         ` Kalle Valo
2014-02-28  9:28           ` Kalle Valo
2014-02-28  9:54           ` Michal Kazior
2014-02-28  9:54             ` Michal Kazior
2014-02-27  7:19   ` [PATCH v3 5/8] ath10k: batch htt tx/rx completions Michal Kazior
2014-02-27  7:19     ` Michal Kazior
2014-02-28  9:00     ` Kalle Valo [this message]
2014-02-28  9:00       ` Kalle Valo
2014-02-28  9:07       ` Michal Kazior
2014-02-28  9:07         ` Michal Kazior
2014-02-27  7:19   ` [PATCH v3 6/8] ath10k: reduce htt tx/rx spinlock overhead Michal Kazior
2014-02-27  7:19     ` Michal Kazior
2014-02-27  7:19   ` [PATCH v3 7/8] ath10k: remove pci completion list Michal Kazior
2014-02-27  7:19     ` Michal Kazior
2014-02-27  7:19   ` [PATCH v3 8/8] ath10k: minimize coherent dma accesses Michal Kazior
2014-02-27  7:19     ` Michal Kazior
2014-02-28 10:13   ` [PATCH v3 0/8] ath10k: performance improvements Kalle Valo
2014-02-28 10:13     ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877g8fd32c.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=michal.kazior@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.