From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-fsdevel@vger.kernel.org, tux3@tux3.org,
Theodore Ts'o <tytso@mit.edu>, Al Viro <viro@zeniv.linux.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Optimize wait_sb_inodes()
Date: Fri, 28 Jun 2013 16:39:49 +0900 [thread overview]
Message-ID: <877gheof96.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <20130628052352.GA9047@dastard> (Dave Chinner's message of "Fri, 28 Jun 2013 15:23:52 +1000")
Dave Chinner <david@fromorbit.com> writes:
>> > A performance regression using fsstress? That's not a program
>> > intended to be a useful benchmark for measuring performance.
>>
>> Right. fsstress is used as stress tool for me too as part of CI, with
>> background vmstat 1. Anyway, it is why I noticed this.
>>
>> I agree it would not be high priority. But I don't think we should stop
>> to optimize it.
>
> But you're not proposing any sort of optimisation at all - you're
> simply proposing to hack around the problem so you don't have to
> care about it. The VFS is a shared resource - it has to work well
> for everyone - and that means we need to fix problems and not ignore
> them.
Agree, vfs has to work well for everyone. To work well, vfs should not
force unnecessary overhead/wait.
I'm not saying to stop optimizing wait_sb_inodes() itself, I'm saying it
is not enough.
Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
WARNING: multiple messages have this Message-ID (diff)
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Dave Chinner <david@fromorbit.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
tux3@tux3.org
Subject: Re: [PATCH] Optimize wait_sb_inodes()
Date: Fri, 28 Jun 2013 16:39:49 +0900 [thread overview]
Message-ID: <877gheof96.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <20130628052352.GA9047@dastard> (Dave Chinner's message of "Fri, 28 Jun 2013 15:23:52 +1000")
Dave Chinner <david@fromorbit.com> writes:
>> > A performance regression using fsstress? That's not a program
>> > intended to be a useful benchmark for measuring performance.
>>
>> Right. fsstress is used as stress tool for me too as part of CI, with
>> background vmstat 1. Anyway, it is why I noticed this.
>>
>> I agree it would not be high priority. But I don't think we should stop
>> to optimize it.
>
> But you're not proposing any sort of optimisation at all - you're
> simply proposing to hack around the problem so you don't have to
> care about it. The VFS is a shared resource - it has to work well
> for everyone - and that means we need to fix problems and not ignore
> them.
Agree, vfs has to work well for everyone. To work well, vfs should not
force unnecessary overhead/wait.
I'm not saying to stop optimizing wait_sb_inodes() itself, I'm saying it
is not enough.
Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2013-06-28 7:39 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-26 8:45 [PATCH] Optimize wait_sb_inodes() OGAWA Hirofumi
2013-06-26 8:45 ` OGAWA Hirofumi
2013-06-26 14:32 ` Jörn Engel
2013-06-27 0:01 ` OGAWA Hirofumi
2013-06-27 0:01 ` OGAWA Hirofumi
2013-06-26 23:11 ` Dave Chinner
2013-06-27 0:14 ` OGAWA Hirofumi
2013-06-27 0:14 ` OGAWA Hirofumi
2013-06-27 4:47 ` Dave Chinner
2013-06-27 5:18 ` OGAWA Hirofumi
2013-06-27 5:18 ` OGAWA Hirofumi
2013-06-27 6:38 ` Dave Chinner
2013-06-27 7:22 ` OGAWA Hirofumi
2013-06-27 7:22 ` OGAWA Hirofumi
2013-06-27 9:40 ` Dave Chinner
2013-06-27 10:06 ` OGAWA Hirofumi
2013-06-27 10:06 ` OGAWA Hirofumi
2013-06-27 18:36 ` Theodore Ts'o
2013-06-27 23:37 ` OGAWA Hirofumi
2013-06-27 23:37 ` OGAWA Hirofumi
2013-06-27 23:45 ` Theodore Ts'o
2013-06-28 0:30 ` OGAWA Hirofumi
2013-06-28 0:30 ` OGAWA Hirofumi
2013-06-28 5:23 ` Dave Chinner
2013-06-28 7:39 ` OGAWA Hirofumi [this message]
2013-06-28 7:39 ` OGAWA Hirofumi
2013-06-28 3:00 ` Daniel Phillips
2013-06-27 7:22 ` Daniel Phillips
2013-06-27 5:50 ` Daniel Phillips
2013-06-27 5:50 ` Daniel Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877gheof96.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tux3@tux3.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.