From: Anthony Liguori <aliguori@us.ibm.com>
To: Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
Subject: Re: [patch 4/6] Use global properties to emulate -no-kvm-pit-reinjection
Date: Wed, 03 Oct 2012 09:41:10 -0500 [thread overview]
Message-ID: <877gr7hb3t.fsf@codemonkey.ws> (raw)
In-Reply-To: <20121003105509.528026359@amt.cnet>
Marcelo Tosatti <mtosatti@redhat.com> writes:
> Commit 80019541e9c13fab476bee35edcef3e11646222c from qemu-kvm.git.
>
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> Use global properties to emulate -no-kvm-pit-reinjection
>
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>
Regards,
Anthony Liguori
>
> Index: qemu-compat-kvm/vl.c
> ===================================================================
> --- qemu-compat-kvm.orig/vl.c
> +++ qemu-compat-kvm/vl.c
> @@ -3071,6 +3071,21 @@ int main(int argc, char **argv, char **e
> "separately.\n");
> break;
> }
> + case QEMU_OPTION_no_kvm_pit_reinjection: {
> + static GlobalProperty kvm_pit_lost_tick_policy[] = {
> + {
> + .driver = "kvm-pit",
> + .property = "lost_tick_policy",
> + .value = "discard",
> + },
> + { /* end of list */ }
> + };
> +
> + fprintf(stderr, "Warning: option deprecated, use "
> + "lost_tick_policy property of kvm-pit instead.\n");
> + qdev_prop_register_global_list(kvm_pit_lost_tick_policy);
> + break;
> + }
> case QEMU_OPTION_usb:
> usb_enabled = 1;
> break;
> Index: qemu-compat-kvm/qemu-options.hx
> ===================================================================
> --- qemu-compat-kvm.orig/qemu-options.hx
> +++ qemu-compat-kvm/qemu-options.hx
> @@ -2844,7 +2844,10 @@ DEF("no-kvm-irqchip", 0, QEMU_OPTION_no_
> DEF("no-kvm-pit", 0, QEMU_OPTION_no_kvm_pit,
> "-no-kvm-pit disable KVM kernel mode PIT\n",
> QEMU_ARCH_I386)
> -
> +DEF("no-kvm-pit-reinjection", 0, QEMU_OPTION_no_kvm_pit_reinjection,
> + "-no-kvm-pit-reinjection\n"
> + " disable KVM kernel mode PIT interrupt reinjection\n",
> + QEMU_ARCH_I386)
>
> HXCOMM This is the last statement. Insert new options before this line!
> STEXI
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Anthony Liguori <aliguori@us.ibm.com>
To: Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [patch 4/6] Use global properties to emulate -no-kvm-pit-reinjection
Date: Wed, 03 Oct 2012 09:41:10 -0500 [thread overview]
Message-ID: <877gr7hb3t.fsf@codemonkey.ws> (raw)
In-Reply-To: <20121003105509.528026359@amt.cnet>
Marcelo Tosatti <mtosatti@redhat.com> writes:
> Commit 80019541e9c13fab476bee35edcef3e11646222c from qemu-kvm.git.
>
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> Use global properties to emulate -no-kvm-pit-reinjection
>
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>
Regards,
Anthony Liguori
>
> Index: qemu-compat-kvm/vl.c
> ===================================================================
> --- qemu-compat-kvm.orig/vl.c
> +++ qemu-compat-kvm/vl.c
> @@ -3071,6 +3071,21 @@ int main(int argc, char **argv, char **e
> "separately.\n");
> break;
> }
> + case QEMU_OPTION_no_kvm_pit_reinjection: {
> + static GlobalProperty kvm_pit_lost_tick_policy[] = {
> + {
> + .driver = "kvm-pit",
> + .property = "lost_tick_policy",
> + .value = "discard",
> + },
> + { /* end of list */ }
> + };
> +
> + fprintf(stderr, "Warning: option deprecated, use "
> + "lost_tick_policy property of kvm-pit instead.\n");
> + qdev_prop_register_global_list(kvm_pit_lost_tick_policy);
> + break;
> + }
> case QEMU_OPTION_usb:
> usb_enabled = 1;
> break;
> Index: qemu-compat-kvm/qemu-options.hx
> ===================================================================
> --- qemu-compat-kvm.orig/qemu-options.hx
> +++ qemu-compat-kvm/qemu-options.hx
> @@ -2844,7 +2844,10 @@ DEF("no-kvm-irqchip", 0, QEMU_OPTION_no_
> DEF("no-kvm-pit", 0, QEMU_OPTION_no_kvm_pit,
> "-no-kvm-pit disable KVM kernel mode PIT\n",
> QEMU_ARCH_I386)
> -
> +DEF("no-kvm-pit-reinjection", 0, QEMU_OPTION_no_kvm_pit_reinjection,
> + "-no-kvm-pit-reinjection\n"
> + " disable KVM kernel mode PIT interrupt reinjection\n",
> + QEMU_ARCH_I386)
>
> HXCOMM This is the last statement. Insert new options before this line!
> STEXI
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-10-03 14:41 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-03 10:52 [patch 0/6] qemu-kvm compat Marcelo Tosatti
2012-10-03 10:52 ` [Qemu-devel] " Marcelo Tosatti
2012-10-03 10:52 ` [patch 1/6] cirrus_vga: allow configurable vram size Marcelo Tosatti
2012-10-03 10:52 ` [Qemu-devel] " Marcelo Tosatti
2012-10-03 14:39 ` Anthony Liguori
2012-10-03 14:39 ` [Qemu-devel] " Anthony Liguori
2012-10-03 10:52 ` [patch 2/6] Use machine options to emulate -no-kvm-irqchip Marcelo Tosatti
2012-10-03 10:52 ` [Qemu-devel] " Marcelo Tosatti
2012-10-03 14:40 ` Anthony Liguori
2012-10-03 14:40 ` [Qemu-devel] " Anthony Liguori
2012-10-03 15:03 ` Marcelo Tosatti
2012-10-03 15:03 ` [Qemu-devel] " Marcelo Tosatti
2012-10-03 15:46 ` Jan Kiszka
2012-10-03 15:46 ` [Qemu-devel] " Jan Kiszka
2012-10-03 15:49 ` Jan Kiszka
2012-10-03 15:49 ` [Qemu-devel] " Jan Kiszka
2012-10-03 17:16 ` Anthony Liguori
2012-10-03 17:24 ` Jan Kiszka
2012-10-03 17:24 ` [Qemu-devel] " Jan Kiszka
2012-10-03 18:14 ` Anthony Liguori
2012-10-03 18:26 ` Marcelo Tosatti
2012-10-04 9:28 ` Jan Kiszka
2012-10-04 14:21 ` Anthony Liguori
2012-10-04 14:30 ` Jan Kiszka
2012-10-04 15:36 ` Andreas Färber
2012-10-04 16:04 ` Jan Kiszka
2012-10-04 16:13 ` Andreas Färber
2012-10-04 16:40 ` Jan Kiszka
2012-10-04 17:16 ` Marcelo Tosatti
2012-10-04 17:14 ` Marcelo Tosatti
2012-10-04 17:46 ` Anthony Liguori
2012-10-03 18:54 ` Aurelien Jarno
2012-10-03 18:54 ` Aurelien Jarno
2012-10-03 10:52 ` [patch 3/6] Use machine options to emulate -no-kvm-pit Marcelo Tosatti
2012-10-03 10:52 ` [Qemu-devel] " Marcelo Tosatti
2012-10-03 14:40 ` Anthony Liguori
2012-10-03 14:40 ` [Qemu-devel] " Anthony Liguori
2012-10-03 10:52 ` [patch 4/6] Use global properties to emulate -no-kvm-pit-reinjection Marcelo Tosatti
2012-10-03 10:52 ` [Qemu-devel] " Marcelo Tosatti
2012-10-03 14:41 ` Anthony Liguori [this message]
2012-10-03 14:41 ` Anthony Liguori
2012-10-03 10:53 ` [patch 5/6] Emulate qemu-kvms drive parameter boot=on|off Marcelo Tosatti
2012-10-03 10:53 ` [Qemu-devel] " Marcelo Tosatti
2012-10-03 14:43 ` Anthony Liguori
2012-10-03 14:43 ` [Qemu-devel] " Anthony Liguori
2012-10-03 10:53 ` [patch 6/6] Emulate qemu-kvms -tdf option Marcelo Tosatti
2012-10-03 10:53 ` [Qemu-devel] " Marcelo Tosatti
2012-10-03 14:44 ` Anthony Liguori
2012-10-03 14:44 ` [Qemu-devel] " Anthony Liguori
2012-10-03 14:45 ` [patch 0/6] qemu-kvm compat Anthony Liguori
2012-10-03 14:45 ` [Qemu-devel] " Anthony Liguori
2012-10-03 15:05 ` Marcelo Tosatti
2012-10-03 15:05 ` [Qemu-devel] " Marcelo Tosatti
2012-10-03 15:34 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877gr7hb3t.fsf@codemonkey.ws \
--to=aliguori@us.ibm.com \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.