From: Rusty Russell <rusty@rustcorp.com.au>
To: Greg KH <gregkh@linuxfoundation.org>,
Sasha Levin <levinsasha928@gmail.com>
Cc: Tim Abbott <tim.abbott@oracle.com>, stable@vger.kernel.org
Subject: Re: Patch Upstream: module: Remove module size limit
Date: Thu, 29 Mar 2012 15:25:20 +1030 [thread overview]
Message-ID: <877gy4ypjb.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20120328233252.GA16375@kroah.com>
On Wed, 28 Mar 2012 16:32:52 -0700, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Thu, Mar 29, 2012 at 01:22:23AM +0200, Sasha Levin wrote:
> > On Thu, Mar 29, 2012 at 1:09 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > > On Thu, Mar 29, 2012 at 12:57:47AM +0200, Sasha Levin wrote:
> > >> On Thu, Mar 29, 2012 at 12:41 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > >> > For the patch below, what are the "real world use cases" that would
> > >> > cause this to be needed in the stable kernel trees? Is there an
> > >> > in-kernel module that is affected by this limitation?
> > >>
> > >> There are no in-kernel modules which are affected, the "real world"
> > >> scenario is debug modules generated by Ksplice.
> > >
> > > So why is this needed for the stable kernels? This really looks like a
> > > feature not a bugfix to me, how about you?
> >
> > I guess it depends on whether you consider the inability to load
> > modules bigger than 64mb as a bug or not.
>
> As there is no in-kernel user with this problem, no, I don't think it's
> a bug that meets the rules documented in
> Documentation/stable_kernel_rules.txt, do you?
Your call, but it has been my policy to support ksplice, such as making
sure we export symbols it needs. And this really is a low-risk change.
Thanks,
Rusty.
--
How could I marry someone with more hair than me? http://baldalex.org
next prev parent reply other threads:[~2012-03-29 4:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120328220121.108CF26EF@git.kroah.org>
2012-03-28 22:41 ` Patch Upstream: module: Remove module size limit Greg KH
2012-03-28 22:57 ` Sasha Levin
2012-03-28 23:09 ` Greg KH
2012-03-28 23:22 ` Sasha Levin
2012-03-28 23:32 ` Greg KH
2012-03-29 4:55 ` Rusty Russell [this message]
2012-03-29 15:20 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877gy4ypjb.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=gregkh@linuxfoundation.org \
--cc=levinsasha928@gmail.com \
--cc=stable@vger.kernel.org \
--cc=tim.abbott@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.